From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/3] Gobi: Enable SIM driver forcing
Date: Mon, 02 May 2016 22:21:25 -0500 [thread overview]
Message-ID: <57281935.9000800@gmail.com> (raw)
In-Reply-To: <1462206794-14322-1-git-send-email-m.chaplet@kerlink.fr>
[-- Attachment #1: Type: text/plain, Size: 1311 bytes --]
Hi Martin,
On 05/02/2016 11:33 AM, Martin Chaplet wrote:
> Let modem detect part overload default SIM driver by using an additional
> property named "ForceSimLegacy" (boolean).
>
> Signed-off-by: Martin Chaplet <m.chaplet@kerlink.fr>
No Signed-off-by please.
> ---
> plugins/gobi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/plugins/gobi.c b/plugins/gobi.c
> index 4daa459..aad423d 100644
> --- a/plugins/gobi.c
> +++ b/plugins/gobi.c
> @@ -418,7 +418,7 @@ static void gobi_pre_sim(struct ofono_modem *modem)
>
> ofono_devinfo_create(modem, 0, "qmimodem", data->device);
>
> - if (data->features & GOBI_UIM)
> + if ( (data->features & GOBI_UIM) && !ofono_modem_get_boolean(modem, "ForceSimLegacy") )
Not our style. Also the logic would be cleaner if we do something like:
const char *sim_driver;
if (data->features & GOBI_UIM)
sim_driver = "qmimodem";
else if (data->features & GOBI_DMS)
sim_driver = "qmimodem-legacy";
if (ofono_modem_get_boolean(modem, "ForceSimLegacy"))
sim_driver = "qmimodem-legacy";
ofono_sim_create(...);
> ofono_sim_create(modem, 0, "qmimodem", data->device);
> else if (data->features & GOBI_DMS)
> ofono_sim_create(modem, 0, "qmimodem-legacy", data->device);
>
Regards,
-Denis
next prev parent reply other threads:[~2016-05-03 3:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-02 14:42 [PATCH 1/3] udevng: Add usbmisc scan for QMI devices Martin Chaplet
2016-05-02 14:42 ` [PATCH 2/3] Gobi: Enable SIM driver "manual" config Martin Chaplet
2016-05-02 15:13 ` Denis Kenzior
2016-05-02 15:27 ` Martin Chaplet
2016-05-02 14:42 ` [PATCH 3/3] Add support for Sierra MC73xx QMI modems Martin Chaplet
2016-05-02 15:20 ` Denis Kenzior
2016-05-02 15:37 ` Martin Chaplet
2016-05-02 16:33 ` [PATCH 1/3] Gobi: Enable SIM driver forcing Martin Chaplet
2016-05-02 16:33 ` [PATCH 2/3] Udevng: Improve modem properties detection Martin Chaplet
2016-05-03 3:23 ` Denis Kenzior
2016-05-03 8:40 ` Martin Chaplet
2016-05-02 16:33 ` [PATCH 3/3] Add support for Sierra MC73xx QMI modems Martin Chaplet
2016-05-03 3:21 ` Denis Kenzior [this message]
2016-05-02 20:24 ` =?unknown-8bit?q?Bj=C3=B8rn?= Mork
2016-05-03 8:27 ` Martin Chaplet
2016-05-03 8:55 ` =?unknown-8bit?q?Bj=C3=B8rn?= Mork
2016-05-02 15:12 ` [PATCH 1/3] udevng: Add usbmisc scan for QMI devices Denis Kenzior
-- strict thread matches above, loose matches on Subject: below --
2016-05-03 8:44 [PATCH 1/3] Gobi: Enable SIM driver forcing Martin Chaplet
2016-05-03 16:12 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57281935.9000800@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox