Re: [PATCH 1/1] Huawei E176: Mark primary and secondary device at ofono.rules TODO: Fix sim_add detection, add E1552 idProduct to ofono.rules

[Kalle Valo <kalle.valo@canonical.com>]

[-- Attachment #1: Type: text/plain, Size: 1581 bytes --]

Hi Florian,

thank you for the patch.

I'm curious, did you test ofono with Huawei E176? Did it work? Did you
have any problems?

Florian Steinel <Florian.Steinel@gmail.com> writes:

> diff --git a/plugins/ofono.rules b/plugins/ofono.rules
> index 0575362..abae06a 100644
> --- a/plugins/ofono.rules
> +++ b/plugins/ofono.rules
> @@ -1,11 +1,26 @@
>  # do not edit this file, it will be overwritten on update
>  
>  ACTION!="add|change", GOTO="ofono_end"
> +
> +SUBSYSTEM!="tty", GOTO="ofono_typ_end"
> +KERNEL!="ttyUSB[0-9]*", GOTO="ofono_typ_end"
> +
> +# HUAWEI E176
> +ENV{ID_VENDOR_ID}=="12d1", ENV{ID_MODEL_ID}=="1003", ENV{ID_IFACE}=="00", ENV{OFONO_TYP}="PRIMARY"
> +ENV{ID_VENDOR_ID}=="12d1", ENV{ID_MODEL_ID}=="1003", ENV{ID_IFACE}=="01", ENV{OFONO_TYP}="SECONDARY"
>
> +# HUAWEI E1552
> +# TODO: Add ID_MODEL_ID aka idProduct for E1552
> +#ENV{ID_VENDOR_ID}=="12d1", ENV{ID_MODEL_ID}=="1003", ENV{ID_IFACE}=="00", ENV{OFONO_TYP}="PRIMARY"
> +#ENV{ID_VENDOR_ID}=="12d1", ENV{ID_MODEL_ID}=="1003", ENV{ID_IFACE}=="02", ENV{OFONO_TYP}="SECONDARY"
> +
> +LABEL="ofono_typ_end"

I think adding usb ids to the rules file for each Huawei product is a
maintenance problem. There are so many devices out there, that handling
the usb ids for all of them is difficult.

I personally would prefer a solution which would dynamically probe the
ports and choose them based on results. I believe modemmanager does
something like this, but I haven't looked in detail.

But Denis and Marcel should comment here, they know best.

-- 
Kalle Valo