* [PATCH 1/2] src/main.c: removed call to g_thread_init
@ 2018-09-20 4:39 Giacinto Cifelli
2018-09-20 4:39 ` [PATCH 2/2] tools/auto-enable.c and tools/huawei-audio.c: removed calls " Giacinto Cifelli
2018-09-20 15:41 ` [PATCH 1/2] src/main.c: removed call " Denis Kenzior
0 siblings, 2 replies; 3+ messages in thread
From: Giacinto Cifelli @ 2018-09-20 4:39 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 617 bytes --]
according to g_thread documentation, this call is no longer needed,
and starting from g_thread version 2.32 it must not be used
---
src/main.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/src/main.c b/src/main.c
index 2d359dd..d8a06ba 100644
--- a/src/main.c
+++ b/src/main.c
@@ -211,11 +211,6 @@ int main(int argc, char **argv)
struct ell_event_source *source;
#endif
-#ifdef NEED_THREADS
- if (g_thread_supported() == FALSE)
- g_thread_init(NULL);
-#endif
-
context = g_option_context_new(NULL);
g_option_context_add_main_entries(context, options, NULL);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] tools/auto-enable.c and tools/huawei-audio.c: removed calls to g_thread_init
2018-09-20 4:39 [PATCH 1/2] src/main.c: removed call to g_thread_init Giacinto Cifelli
@ 2018-09-20 4:39 ` Giacinto Cifelli
2018-09-20 15:41 ` [PATCH 1/2] src/main.c: removed call " Denis Kenzior
1 sibling, 0 replies; 3+ messages in thread
From: Giacinto Cifelli @ 2018-09-20 4:39 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 1008 bytes --]
---
tools/auto-enable.c | 5 -----
tools/huawei-audio.c | 5 -----
2 files changed, 10 deletions(-)
diff --git a/tools/auto-enable.c b/tools/auto-enable.c
index 87fb0a8..5195aaa 100644
--- a/tools/auto-enable.c
+++ b/tools/auto-enable.c
@@ -492,11 +492,6 @@ int main(int argc, char **argv)
guint watch;
struct sigaction sa;
-#ifdef NEED_THREADS
- if (g_thread_supported() == FALSE)
- g_thread_init(NULL);
-#endif
-
context = g_option_context_new(NULL);
g_option_context_add_main_entries(context, options, NULL);
diff --git a/tools/huawei-audio.c b/tools/huawei-audio.c
index 9997a58..10b599f 100644
--- a/tools/huawei-audio.c
+++ b/tools/huawei-audio.c
@@ -775,11 +775,6 @@ int main(int argc, char **argv)
guint watch;
struct sigaction sa;
-#ifdef NEED_THREADS
- if (g_thread_supported() == FALSE)
- g_thread_init(NULL);
-#endif
-
context = g_option_context_new(NULL);
g_option_context_add_main_entries(context, options, NULL);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] src/main.c: removed call to g_thread_init
2018-09-20 4:39 [PATCH 1/2] src/main.c: removed call to g_thread_init Giacinto Cifelli
2018-09-20 4:39 ` [PATCH 2/2] tools/auto-enable.c and tools/huawei-audio.c: removed calls " Giacinto Cifelli
@ 2018-09-20 15:41 ` Denis Kenzior
1 sibling, 0 replies; 3+ messages in thread
From: Denis Kenzior @ 2018-09-20 15:41 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 346 bytes --]
Hi Giacinto,
On 09/19/2018 11:39 PM, Giacinto Cifelli wrote:
> according to g_thread documentation, this call is no longer needed,
> and starting from g_thread version 2.32 it must not be used
> ---
> src/main.c | 5 -----
> 1 file changed, 5 deletions(-)
>
Both applied after tweaking the commit messages.
Regards,
-Denis
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-20 15:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-20 4:39 [PATCH 1/2] src/main.c: removed call to g_thread_init Giacinto Cifelli
2018-09-20 4:39 ` [PATCH 2/2] tools/auto-enable.c and tools/huawei-audio.c: removed calls " Giacinto Cifelli
2018-09-20 15:41 ` [PATCH 1/2] src/main.c: removed call " Denis Kenzior
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox