[PATCH] mbim: add an optional TEMP_FAILURE_RETRY macro copy

[PATCH] mbim: add an optional TEMP_FAILURE_RETRY macro copy

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 890 bytes --]

Fixes build on musl which does not provide this macro

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 drivers/mbimmodem/mbim-private.h | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/mbimmodem/mbim-private.h b/drivers/mbimmodem/mbim-private.h
index e159235..51693ea 100644
--- a/drivers/mbimmodem/mbim-private.h
+++ b/drivers/mbimmodem/mbim-private.h
@@ -21,6 +21,15 @@
 
 #define align_len(len, boundary) (((len)+(boundary)-1) & ~((boundary)-1))
 
+#ifndef TEMP_FAILURE_RETRY
+#define TEMP_FAILURE_RETRY(expression) ({     \
+  __typeof(expression) __result;              \
+  do {                                        \
+    __result = (expression);                  \
+  } while (__result == -1 && errno == EINTR); \
+  __result; })
+#endif
+
 enum mbim_control_message {
 	MBIM_OPEN_MSG = 0x1,
 	MBIM_CLOSE_MSG = 0x2,
-- 
2.21.0

Re: [PATCH] mbim: add an optional TEMP_FAILURE_RETRY macro copy

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 501 bytes --]

Hi,

On 05/23/2019 08:20 PM, Khem Raj wrote:
> Fixes build on musl which does not provide this macro
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>

No Signed-off-by for oFono patch submissions please

> ---
>   drivers/mbimmodem/mbim-private.h | 9 +++++++++
>   1 file changed, 9 insertions(+)
> 

I solved this by introducing L_TFR in ell, commit:
8198b3689490eb81fdc7ce42f4ec1ac7321a1e3c

And reworked all use of TFR/TEMP_FAILURE_RETRY to use that instead.

Regards,
-Denis