Re: [PATCH v1] firmware: tee_bnxt: Use UUID API for exporting the UUID

Re: [PATCH v1] firmware: tee_bnxt: Use UUID API for exporting the UUID

[Andy Shevchenko]

[-- Attachment #1: Type: text/plain, Size: 1246 bytes --]

On Thu, Jun 18, 2020 at 01:56:48PM +0300, Andy Shevchenko wrote:
> On Wed, Apr 22, 2020 at 04:00:21PM +0300, Andy Shevchenko wrote:
> > There is export_uuid() function which exports uuid_t to the u8 array.
> > Use it instead of open coding variant.
> > 
> > This allows to hide the uuid_t internals.
> 
> Any comment on this?

Guys, who is going to pick this up?

> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >  drivers/firmware/broadcom/tee_bnxt_fw.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c
> > index ed10da5313e86..4cf0c2576037d 100644
> > --- a/drivers/firmware/broadcom/tee_bnxt_fw.c
> > +++ b/drivers/firmware/broadcom/tee_bnxt_fw.c
> > @@ -197,7 +197,7 @@ static int tee_bnxt_fw_probe(struct device *dev)
> >  		return -ENODEV;
> >  
> >  	/* Open session with Bnxt load Trusted App */
> > -	memcpy(sess_arg.uuid, bnxt_device->id.uuid.b, TEE_IOCTL_UUID_LEN);
> > +	export_uuid(sess_arg.uuid, &bnxt_device->id.uuid);
> >  	sess_arg.clnt_login = TEE_IOCTL_LOGIN_PUBLIC;
> >  	sess_arg.num_params = 0;
> >  

-- 
With Best Regards,
Andy Shevchenko