OP-TEE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rouven Czerwinski <r.czerwinski@pengutronix.de>
To: op-tee@lists.trustedfirmware.org
Subject: Re: [PATCH] tee: optee: remove need_resched() before cond_resched()
Date: Fri, 29 Jan 2021 14:42:44 +0100	[thread overview]
Message-ID: <6cbc0636-1465-9cc4-87ca-3f78d8f67775@pengutronix.de> (raw)
In-Reply-To: < <CAHUa44GsbxO=wJ_o-AZsxNvKOhn=y=dexkrN17zCy=7+0=1ZQg@mail.gmail.com>>

[-- Attachment #1: Type: text/plain, Size: 1018 bytes --]

On 29.01.21 14:29, Jens Wiklander wrote:
> Hi Rouven and Sumit,
> 
> On Mon, Jan 25, 2021 at 10:58 AM Jens Wiklander via OP-TEE
> <op-tee@lists.trustedfirmware.org> wrote:
>>
>> Hi Rouven and Sumit,
>>
>> On Mon, Jan 25, 2021 at 10:55 AM Jens Wiklander
>> <jens.wiklander@linaro.org> wrote:
>>>
>>> Testing need_resched() before cond_resched() is not needed as an
>>> equivalent test is done internally in cond_resched(). So drop the
>>> need_resched() test.
>>>
>>> Fixes: dcb3b06d9c34 ("tee: optee: replace might_sleep with cond_resched")
>>> Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
>>> ---
>>>   drivers/tee/optee/call.c | 3 +--
>>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> Can you please test to see that this works in your setups too?
> 
> Does this work for you? I'd like to get this patch ready for v5.12.

Sorry I did not get to this yet, I'll need to modify the existing 
kernelconfig again to reproduce the buggy configuration. I'll get this 
done by monday.

Regards,
Rouven

       reply	other threads:[~2021-01-29 13:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] < <CAHUa44GsbxO=wJ_o-AZsxNvKOhn=y=dexkrN17zCy=7+0=1ZQg@mail.gmail.com>
2021-01-29 13:42 ` Rouven Czerwinski [this message]
2021-01-31  8:13 ` [PATCH] tee: optee: remove need_resched() before cond_resched() Rouven Czerwinski
2021-02-01  5:02 ` Sumit Garg
2021-02-03  7:10 ` Jens Wiklander
     [not found] <=?utf-8?q?=3C0100017738faac80-87e5cf40-6a5a-4727-9c36-382fb909c?= =?utf-8?q?8ff-000000=40email=2Eamazonses=2Ecom=3E?=>
2021-01-29 13:29 ` Jens Wiklander
2021-01-25  9:54 Jens Wiklander
2021-01-25  9:57 ` Jens Wiklander
2021-01-29 13:58 ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6cbc0636-1465-9cc4-87ca-3f78d8f67775@pengutronix.de \
    --to=r.czerwinski@pengutronix.de \
    --cc=op-tee@lists.trustedfirmware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox