public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Thomas Perrot <thomas.perrot@bootlin.com>
To: joerg.sommer@navimatix.de, openembedded-core@lists.openembedded.org
Cc: thomas.perrot@bootlin.com, changqing.li@windriver.com, rs@ti.com,
	 ricardo.salveti@oss.qualcomm.com, raj.khem@gmail.com,
	antonin.godard@bootlin.com, 	richard.purdie@linuxfoundation.org
Subject: Re: [OE-core] [PATCH] lto.inc: add DEBUG_PREFIX_MAP back to TARGET_LDFLAGS
Date: Mon, 30 Mar 2026 11:59:51 +0200	[thread overview]
Message-ID: <0110332424c01404402aa58286399958e1449110.camel@bootlin.com> (raw)
In-Reply-To: <acg3xGOKkL769U3e@navimatix.de>

[-- Attachment #1: Type: text/plain, Size: 1991 bytes --]

   1. Hello,
      
On Sat, 2026-03-28 at 21:26 +0100, Jörg Sommer via
lists.openembedded.org wrote:
> Changqing Li via lists.openembedded.org schrieb am Mi 04. Feb, 13:26
> (+0800):
> > From: Changqing Li <changqing.li@windriver.com>
> > 
> > DEBUG_PREFIX_MAP is appended to TARGET_LDFLAGS in commit [1] for
> > fixing
> > reproducible issue when LTO is enabled. It is removed in comit [2]
> > since
> > this commit causes cgo binary not reproducible. But actually, we
> > still
> > need this DEBUG_PREFIX_MAP in LDFLAGS when LTO enabled. So, only
> > appened
> > it when LTO is enabled. Refer [3] for the history, with this patch,
> > patch [4] is also needed for cgo + lto enabled.
> 
> Gentle ping. This patch is missing, otherwise QA check buildpaths
> matches in
> nearly all packages.

I confirm this patch is required to fix QA check build paths for a few
packages. 
Kind regards,
Thomas Perrot

> 
> But this still leaves some packages with buildpaths, because there's
> a bug
> in gcc that it does not apply -ffile-prefix-map:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=124581
> 
> > diff --git a/meta/conf/distro/include/lto.inc
> > b/meta/conf/distro/include/lto.inc
> > index 227f0c5c2a..cef92901e3 100644
> > --- a/meta/conf/distro/include/lto.inc
> > +++ b/meta/conf/distro/include/lto.inc
> > @@ -49,5 +49,6 @@ LTO:toolchain-clang =
> > "${@bb.utils.contains('DISTRO_FEATURES', 'thin-lto', '-flt
> >  
> >  SELECTED_OPTIMIZATION:append =
> > "${@bb.utils.contains('DISTRO_FEATURES', 'lto', ' ${LTO}', '', d)}"
> >  TARGET_LDFLAGS:append:class-target =
> > "${@bb.utils.contains('DISTRO_FEATURES', 'lto', ' ${LTO}', '', d)}"
> > +TARGET_LDFLAGS:append:class-target =
> > "${@bb.utils.contains('DISTRO_FEATURES', 'lto', '
> > ${DEBUG_PREFIX_MAP}', '', d)}"
> 
> Possibly, I would join these lines.
> 
> 
> Best regards Jörg

-- 
Thomas Perrot, Bootlin Embedded Linux and kernel engineering
https://bootlin.com

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

  reply	other threads:[~2026-03-30 10:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-04  5:26 [PATCH] lto.inc: add DEBUG_PREFIX_MAP back to TARGET_LDFLAGS changqing.li
2026-02-04  9:34 ` Richard Purdie
2026-02-04 18:17 ` Ricardo de Araujo (Salveti)
2026-02-04 22:34   ` Richard Purdie
2026-03-28 20:26 ` [OE-core] " Jörg Sommer
2026-03-30  9:59   ` Thomas Perrot [this message]
2026-03-30 10:18     ` Richard Purdie
2026-03-30 10:23       ` Jörg Sommer
2026-03-30 10:50         ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0110332424c01404402aa58286399958e1449110.camel@bootlin.com \
    --to=thomas.perrot@bootlin.com \
    --cc=antonin.godard@bootlin.com \
    --cc=changqing.li@windriver.com \
    --cc=joerg.sommer@navimatix.de \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    --cc=ricardo.salveti@oss.qualcomm.com \
    --cc=richard.purdie@linuxfoundation.org \
    --cc=rs@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox