Re: [OE-core] [PATCH] lto.inc: add DEBUG_PREFIX_MAP back to TARGET_LDFLAGS

["Jörg Sommer" <joerg.sommer@navimatix.de>]

[-- Attachment #1: Type: text/plain, Size: 1789 bytes --]

Changqing Li via lists.openembedded.org schrieb am Mi 04. Feb, 13:26 (+0800):
> From: Changqing Li <changqing.li@windriver.com>
> 
> DEBUG_PREFIX_MAP is appended to TARGET_LDFLAGS in commit [1] for fixing
> reproducible issue when LTO is enabled. It is removed in comit [2] since
> this commit causes cgo binary not reproducible. But actually, we still
> need this DEBUG_PREFIX_MAP in LDFLAGS when LTO enabled. So, only appened
> it when LTO is enabled. Refer [3] for the history, with this patch,
> patch [4] is also needed for cgo + lto enabled.

Gentle ping. This patch is missing, otherwise QA check buildpaths matches in
nearly all packages.

But this still leaves some packages with buildpaths, because there's a bug
in gcc that it does not apply -ffile-prefix-map:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=124581

> diff --git a/meta/conf/distro/include/lto.inc b/meta/conf/distro/include/lto.inc
> index 227f0c5c2a..cef92901e3 100644
> --- a/meta/conf/distro/include/lto.inc
> +++ b/meta/conf/distro/include/lto.inc
> @@ -49,5 +49,6 @@ LTO:toolchain-clang = "${@bb.utils.contains('DISTRO_FEATURES', 'thin-lto', '-flt
>  
>  SELECTED_OPTIMIZATION:append = "${@bb.utils.contains('DISTRO_FEATURES', 'lto', ' ${LTO}', '', d)}"
>  TARGET_LDFLAGS:append:class-target = "${@bb.utils.contains('DISTRO_FEATURES', 'lto', ' ${LTO}', '', d)}"
> +TARGET_LDFLAGS:append:class-target = "${@bb.utils.contains('DISTRO_FEATURES', 'lto', ' ${DEBUG_PREFIX_MAP}', '', d)}"

Possibly, I would join these lines.


Best regards Jörg

-- 
Navimatix GmbH           T: 03641 - 327 99 0
Tatzendpromenade 2       F: 03641 - 526 306
07745 Jena               www.navimatix.de

Geschäftsführer: Steffen Späthe, Jan Rommeley
Registergericht: Amtsgericht Jena, HRB 501480

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5000 bytes --]