public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: ohnatiuk@cisco.com, Denys Dmytriyenko <denis@denix.org>
Cc: "openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH v2] gcc: remove paths to sysroot from configargs.h and checksum-options for gcc-cross-canadian
Date: Thu, 18 Jul 2024 09:09:50 +0100	[thread overview]
Message-ID: <011f18a97cd6ff44e917828739b62eb49efe2ee9.camel@linuxfoundation.org> (raw)
In-Reply-To: <SA1PR11MB582845C51666A74D1410542DCBAC2@SA1PR11MB5828.namprd11.prod.outlook.com>

On Thu, 2024-07-18 at 07:40 +0000, Oleksandr Hnatiuk via lists.openembedded.org wrote:
> I am aware of this issue. As stated in my commit, it is designed to
> improve reproducibility of gcc-cross-canadian as opposed to fully
> fixing it.
> 
> I have another patch I was going to submit which fully fixes this
> package by modifying the code of gcc's fixincludes program to not
> include full source directory, only source file name. However,
> removing these files entirely as you suggest will also work.
> 
> Of course, it would be best to fix this in code and submit the same
> patch to gcc upstream to fix this issue for everyone. However, this
> would take more time and require us to maintain another patch in
> openembedded-core. Not sure which approach is preferred in OE.

We've now worked out why we didn't see this in our CI and have patches
to fix that but that does mean we need the patches to fix this error
more urgently! If you have something please do send it as I was
thinking I might have to look at this today.

Ideally we'd fix this with something acceptable to upstream, they'd
take that and then we'd drop our changes next time we upgrade gcc.
Maintaining a backported patch is fine, it is the ones that never get
discussed with upstream we've been pushing back against.

Re: deleting the files, the question is whether they're being used. If
they are, we need to keep them. If they are never used, they could be
deleted. I don't know which is the case here.

Cheers,

Richard




  reply	other threads:[~2024-07-18  8:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-12 11:00 [PATCH] gcc: remove paths to sysroot from configargs.h and checksum-options for gcc-cross-canadian Oleksandr Hnatiuk
2024-07-12 11:17 ` [OE-core] " Alexander Kanavin
2024-07-12 19:22   ` Oleksandr Hnatiuk
2024-07-15 12:30     ` [OE-core] " Alexander Kanavin
2024-07-17  9:56   ` [PATCH v2] " Oleksandr Hnatiuk
2024-07-17  9:59     ` Oleksandr Hnatiuk
2024-07-18  0:21     ` [OE-core] " Denys Dmytriyenko
2024-07-18  7:40       ` Oleksandr Hnatiuk -X (ohnatiuk - GLOBALLOGIC INC at Cisco)
2024-07-18  8:09         ` Richard Purdie [this message]
     [not found]     ` <17E326C1F13DA2A9.25516@lists.openembedded.org>
2024-07-18  2:15       ` Denys Dmytriyenko
2024-07-18  8:36     ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=011f18a97cd6ff44e917828739b62eb49efe2ee9.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=denis@denix.org \
    --cc=ohnatiuk@cisco.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox