public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: "Oleksandr Hnatiuk" <ohnatiuk@cisco.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v2] gcc: remove paths to sysroot from configargs.h and checksum-options for gcc-cross-canadian
Date: Wed, 17 Jul 2024 02:59:29 -0700	[thread overview]
Message-ID: <23423.1721210369118673744@lists.openembedded.org> (raw)
In-Reply-To: <20240717095606.3572072-1-ohnatiuk@cisco.com>

[-- Attachment #1: Type: text/plain, Size: 846 bytes --]

For some reason this created a new topic rather than post to existing one...

I have refactored the code from my previous submission to move the code from all 3 places to functions.
For both functions: I have chosen sed code from gcc-cross.inc (replaces the paths with "/host" rather than "/" as gcc-target did). This unification shouldn't affect the functionality, only what will be seen instead of sysroot paths.
For remove_sysroot_paths_from_checksum_options: I saw that gcc-target.inc and gcc-cross.inc erase STAGING_DIR_TARGET and STAGING_DIR_HOST respectively. To preserve this behavior, I pass them as parameters and use ${1} in sed.

Since I am not that familiar with possible differences between regular shell scripting and shell scripting inside of bitbake recipes, could you confirm that I parameterized the function correctly?

[-- Attachment #2: Type: text/html, Size: 955 bytes --]

  reply	other threads:[~2024-07-17  9:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-12 11:00 [PATCH] gcc: remove paths to sysroot from configargs.h and checksum-options for gcc-cross-canadian Oleksandr Hnatiuk
2024-07-12 11:17 ` [OE-core] " Alexander Kanavin
2024-07-12 19:22   ` Oleksandr Hnatiuk
2024-07-15 12:30     ` [OE-core] " Alexander Kanavin
2024-07-17  9:56   ` [PATCH v2] " Oleksandr Hnatiuk
2024-07-17  9:59     ` Oleksandr Hnatiuk [this message]
2024-07-18  0:21     ` [OE-core] " Denys Dmytriyenko
2024-07-18  7:40       ` Oleksandr Hnatiuk -X (ohnatiuk - GLOBALLOGIC INC at Cisco)
2024-07-18  8:09         ` Richard Purdie
     [not found]     ` <17E326C1F13DA2A9.25516@lists.openembedded.org>
2024-07-18  2:15       ` Denys Dmytriyenko
2024-07-18  8:36     ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23423.1721210369118673744@lists.openembedded.org \
    --to=ohnatiuk@cisco.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox