From: Alexander Kanavin <alexander.kanavin@linux.intel.com>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>,
"openembedded-devel@lists.openembedded.org"
<openembedded-devel@lists.openembedded.org>,
Yocto Project <yocto@yoctoproject.org>
Subject: Attention all: patches for upstream source will be applied with stricter criteria for context
Date: Fri, 21 Oct 2016 15:55:08 +0300 [thread overview]
Message-ID: <03b5e98b-0724-daa2-8f78-ab4624f52752@linux.intel.com> (raw)
Hello all,
while updating gnutls to a newer version I came across a rather serious
issue: the way we patch source code is very lenient about the context
for the lines to be changed. Basically, it's enough for one line before
and after the changed line to match, because patch command's default
setting for 'fuzz factor' allows it. If these lines happen to be
whitespace or braces, then there's nothing to prevent the patch from
being applied incorrectly.
Here's a particularly nasty example of this happening completely
silently (compile step works fine too), with security implications:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=10450
I think this absolutely needs to be fixed. The downside is that this
will break a lot of patches across all layers - after setting the fuzz
to zero in oe-core we have 87 recipes that fail to be patched. Maxin and
I are currently going through them one by one and getting them fixed.
Regards,
Alex
next reply other threads:[~2016-10-21 12:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 12:55 Alexander Kanavin [this message]
[not found] ` <62045b91-79db-cc5e-c372-70041b7fcdaa@mvista.com>
2016-10-21 15:13 ` [yocto] Attention all: patches for upstream source will be applied with stricter criteria for context Alexander Kanavin
2016-10-21 17:05 ` Khem Raj
2016-10-24 11:30 ` Alexander Kanavin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03b5e98b-0724-daa2-8f78-ab4624f52752@linux.intel.com \
--to=alexander.kanavin@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=openembedded-devel@lists.openembedded.org \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox