From: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
"openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 4/7] glib-2.0-native: Break circular dependency on shared-mime-utils
Date: Sat, 16 Feb 2019 22:45:48 +0000 [thread overview]
Message-ID: <05262e8e31704f8a91db22e0ffb140db@XBOX04.axis.com> (raw)
In-Reply-To: <20190216214638.11456-4-richard.purdie@linuxfoundation.org>
> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org <openembedded-
> core-bounces@lists.openembedded.org> On Behalf Of Richard Purdie
> Sent: den 16 februari 2019 22:47
> To: openembedded-core@lists.openembedded.org
> Subject: [OE-core] [PATCH 4/7] glib-2.0-native: Break circular
> dependency on shared-mime-utils
>
> If we fix native RDEPENDS handling, it exposes a problem where there
> is a circular dependency between shared-mime-utils and glib-2.0-native.
>
> Break this dependency in the -native case.
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
> meta/recipes-core/glib-2.0/glib.inc | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-
> core/glib-2.0/glib.inc
> index c9093cee866..7e2847d4b22 100644
> --- a/meta/recipes-core/glib-2.0/glib.inc
> +++ b/meta/recipes-core/glib-2.0/glib.inc
> @@ -80,6 +80,7 @@ FILES_${PN}-utils = "${bindir}/*"
> RRECOMMENDS_${PN} += "shared-mime-info"
Wouldn't it be clearer to change this to:
RRECOMMENDS_${PN}_append_class-target = " shared-mime-info"
instead of adding the RRECOMMENDS_${PN}_class-native below?
> # When cross compiling for Windows we don't want to include this
> RRECOMMENDS_${PN}_remove_mingw32 = "shared-mime-info"
> +RRECOMMENDS_${PN}_class-native = ""
>
> ARM_INSTRUCTION_SET_armv4 = "arm"
> ARM_INSTRUCTION_SET_armv5 = "arm"
> --
> 2.20.1
//Peter
next prev parent reply other threads:[~2019-02-16 22:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-16 21:46 [PATCH 1/7] package: Rework debug source file handling Richard Purdie
2019-02-16 21:46 ` [PATCH 2/7] lib/oe/utils: Fix hang in multiprocess_launch() Richard Purdie
2019-02-16 21:46 ` [PATCH 3/7] quilt-native: Remove RDEPENDS on util-linux-native Richard Purdie
2019-02-16 21:46 ` [PATCH 4/7] glib-2.0-native: Break circular dependency on shared-mime-utils Richard Purdie
2019-02-16 22:45 ` Peter Kjellerstedt [this message]
2019-02-17 8:52 ` Richard Purdie
2019-02-16 21:46 ` [PATCH 5/7] font-util: Break circular native RDEPENDS Richard Purdie
2019-02-16 22:48 ` Peter Kjellerstedt
2019-02-16 21:46 ` [PATCH 6/7] native: Enable RDEPENDS handling Richard Purdie
2019-02-17 10:18 ` Richard Purdie
2019-02-16 21:46 ` [PATCH 7/7] quilt: Merge recipe files into a more coherent form Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05262e8e31704f8a91db22e0ffb140db@XBOX04.axis.com \
--to=peter.kjellerstedt@axis.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox