From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>,
"openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 4/7] glib-2.0-native: Break circular dependency on shared-mime-utils
Date: Sun, 17 Feb 2019 08:52:44 +0000 [thread overview]
Message-ID: <33c0eed2a4d8a49ef8489ab004058700a969e7e0.camel@linuxfoundation.org> (raw)
In-Reply-To: <05262e8e31704f8a91db22e0ffb140db@XBOX04.axis.com>
On Sat, 2019-02-16 at 22:45 +0000, Peter Kjellerstedt wrote:
> > diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-
> > core/glib-2.0/glib.inc
> > index c9093cee866..7e2847d4b22 100644
> > --- a/meta/recipes-core/glib-2.0/glib.inc
> > +++ b/meta/recipes-core/glib-2.0/glib.inc
> > @@ -80,6 +80,7 @@ FILES_${PN}-utils = "${bindir}/*"
> > RRECOMMENDS_${PN} += "shared-mime-info"
>
> Wouldn't it be clearer to change this to:
>
> RRECOMMENDS_${PN}_append_class-target = " shared-mime-info"
>
> instead of adding the RRECOMMENDS_${PN}_class-native below?
You could argue that both ways, I see the native case as the exception.
Having the mingw32 remove in there is ugly as well and cleaning that up
at the same time might swing it.
Cheers,
Richard
> > # When cross compiling for Windows we don't want to include this
> > RRECOMMENDS_${PN}_remove_mingw32 = "shared-mime-info"
> > +RRECOMMENDS_${PN}_class-native = ""
> >
> > ARM_INSTRUCTION_SET_armv4 = "arm"
> > ARM_INSTRUCTION_SET_armv5 = "arm"
> > --
> > 2.20.1
>
> //Peter
>
>
next prev parent reply other threads:[~2019-02-17 8:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-16 21:46 [PATCH 1/7] package: Rework debug source file handling Richard Purdie
2019-02-16 21:46 ` [PATCH 2/7] lib/oe/utils: Fix hang in multiprocess_launch() Richard Purdie
2019-02-16 21:46 ` [PATCH 3/7] quilt-native: Remove RDEPENDS on util-linux-native Richard Purdie
2019-02-16 21:46 ` [PATCH 4/7] glib-2.0-native: Break circular dependency on shared-mime-utils Richard Purdie
2019-02-16 22:45 ` Peter Kjellerstedt
2019-02-17 8:52 ` Richard Purdie [this message]
2019-02-16 21:46 ` [PATCH 5/7] font-util: Break circular native RDEPENDS Richard Purdie
2019-02-16 22:48 ` Peter Kjellerstedt
2019-02-16 21:46 ` [PATCH 6/7] native: Enable RDEPENDS handling Richard Purdie
2019-02-17 10:18 ` Richard Purdie
2019-02-16 21:46 ` [PATCH 7/7] quilt: Merge recipe files into a more coherent form Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33c0eed2a4d8a49ef8489ab004058700a969e7e0.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=peter.kjellerstedt@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox