[PATCH v2 1/5] rust: Fetch cargo from rust-snapshot dir.

public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed

* [PATCH v2 1/5] rust: Fetch cargo from rust-snapshot dir.
@ 2024-01-19 15:09 Yash.Shinde
  2024-01-19 15:09 ` [PATCH v2 2/5] rust: detect user-specified custom targets in compiletest Yash.Shinde
                   ` (6 more replies)
  0 siblings, 7 replies; 13+ messages in thread
From: Yash.Shinde @ 2024-01-19 15:09 UTC (permalink / raw)
  To: openembedded-core
  Cc: Randy.MacLeod, Umesh.Kallapa, Naveen.Gowda, Sundeep.Kokkonda,
	Shivaprasad.Moodalappa, Yash.Shinde

From: Yash Shinde <Yash.Shinde@windriver.com>

Fixes: Exception: no cargo executable found at
       `${B}/rustc-1.74.1-src/build/x86_64-unknown-linux-gnu/stage0/bin/cargo`

Fix the cargo binary path error on oe-selftest and path set to rust-snapshot dir.

Patch sent to upstream- https://github.com/rust-lang/rust/pull/120125

Signed-off-by: Yash Shinde <Yash.Shinde@windriver.com>
---
 .../rust/files/cargo-path.patch               | 37 +++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 meta/recipes-devtools/rust/files/cargo-path.patch

diff --git a/meta/recipes-devtools/rust/files/cargo-path.patch b/meta/recipes-devtools/rust/files/cargo-path.patch
new file mode 100644
index 0000000000..547df353d2
--- /dev/null
+++ b/meta/recipes-devtools/rust/files/cargo-path.patch
@@ -0,0 +1,37 @@
+Fix the cargo binary path error and ensure that it is fetched 
+during rustc bootstrap in rust oe-selftest. 
+
+======================================================================
+ERROR: test_cargoflags (bootstrap_test.BuildBootstrap)
+----------------------------------------------------------------------
+Traceback (most recent call last):
+  File "/home/build-st/tmp/work/cortexa57-poky-linux/rust/1.74.1/rustc-1.74.1-src/src/bootstrap/bootstrap_test.py", line 157, in test_cargoflags
+    args, _ = self.build_args(env={"CARGOFLAGS": "--timings"})
+  File "/home/build-st/tmp/work/cortexa57-poky-linux/rust/1.74.1/rustc-1.74.1-src/src/bootstrap/bootstrap_test.py", line 154, in build_args
+    return build.build_bootstrap_cmd(env), env
+  File "/home/build-st/tmp/work/cortexa57-poky-linux/rust/1.74.1/rustc-1.74.1-src/src/bootstrap/bootstrap.py", line 960, in build_bootstrap_cmd
+    raise Exception("no cargo executable found at `{}`".format(
+Exception: no cargo executable found at `/home/build-st/tmp/work/cortexa57-poky-linux/rust/1.74.1/rustc-1.74.1-src/build/x86_64-unknown-linux-gnu/stage0/bin/cargo`
+
+Upstream-Status: Submitted [https://github.com/rust-lang/rust/pull/120125]
+
+Signed-off-by: Yash Shinde <Yash.Shinde@windriver.com>
+---
+diff --git a/src/bootstrap/bootstrap.py b/src/bootstrap/bootstrap.py
+--- a/src/bootstrap/bootstrap.py
++++ b/src/bootstrap/bootstrap.py
+@@ -954,9 +954,11 @@
+         if deny_warnings:
+             env["RUSTFLAGS"] += " -Dwarnings"
+
+-        env["PATH"] = os.path.join(self.bin_root(), "bin") + \
+-            os.pathsep + env["PATH"]
+-        if not os.path.isfile(self.cargo()):
++        cargo_bin_path = os.path.join(self.bin_root(), "bin", "cargo")
++        if not os.path.isfile(cargo_bin_path):
++            cargo_bin_path = os.getenv("RUST_TARGET_PATH") + "rust-snapshot/bin/cargo"
++            env["PATH"] = os.path.dirname(cargo_bin_path) + os.pathsep + env["PATH"]
++        else:
+             raise Exception("no cargo executable found at `{}`".format(
+                 self.cargo()))
+         args = [self.cargo(), "build", "--manifest-path",
-- 
2.43.0



^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH v2 2/5] rust: detect user-specified custom targets in compiletest
  2024-01-19 15:09 [PATCH v2 1/5] rust: Fetch cargo from rust-snapshot dir Yash.Shinde
@ 2024-01-19 15:09 ` Yash.Shinde
  2024-01-19 15:09 ` [PATCH v2 3/5] rust: Enable RUSTC_BOOTSTRAP to use nightly features during rust oe-selftest Yash.Shinde
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 13+ messages in thread
From: Yash.Shinde @ 2024-01-19 15:09 UTC (permalink / raw)
  To: openembedded-core
  Cc: Randy.MacLeod, Umesh.Kallapa, Naveen.Gowda, Sundeep.Kokkonda,
	Shivaprasad.Moodalappa, Yash.Shinde

From: Yash Shinde <Yash.Shinde@windriver.com>

Fixes: thread 'main' panicked at 'failed to gather the target spec
       for '<arch>-unknown-linux-gnu', synthetic_targets.rs:66:9

Detect and fetch custom target configurations when rustc is
bootstrapped in rust oe-selftest.

Signed-off-by: Yash Shinde <Yash.Shinde@windriver.com>
---
 .../rust/files/custom-target-cfg.patch        | 90 +++++++++++++++++++
 1 file changed, 90 insertions(+)
 create mode 100644 meta/recipes-devtools/rust/files/custom-target-cfg.patch

diff --git a/meta/recipes-devtools/rust/files/custom-target-cfg.patch b/meta/recipes-devtools/rust/files/custom-target-cfg.patch
new file mode 100644
index 0000000000..15a7f252cc
--- /dev/null
+++ b/meta/recipes-devtools/rust/files/custom-target-cfg.patch
@@ -0,0 +1,90 @@
+Detect and fetch custom target configurations when rustc is
+bootstrapped in rust oe-selftest.
+
+Upstream-Status: Backport [https://github.com/rust-lang/rust/pull/119619/commits/26c71cbcf1a9bce6ceb962d753c467d098f63cf6]
+
+Signed-off-by: onur-ozkan <work@onurozkan.dev>
+Signed-off-by: Yash Shinde <Yash.Shinde@windriver.com>
+---
+diff --git a/src/tools/compiletest/src/common.rs b/src/tools/compiletest/src/common.rs
+index e85f6319936..c45c0b3c652 100644
+--- a/src/tools/compiletest/src/common.rs
++++ b/src/tools/compiletest/src/common.rs
+@@ -479,6 +479,7 @@ fn new(config: &Config) -> TargetCfgs {
+         let mut targets: HashMap<String, TargetCfg> = serde_json::from_str(&rustc_output(
+             config,
+             &["--print=all-target-specs-json", "-Zunstable-options"],
++            Default::default(),
+         ))
+         .unwrap();
+
+@@ -491,16 +492,33 @@ fn new(config: &Config) -> TargetCfgs {
+         let mut all_families = HashSet::new();
+         let mut all_pointer_widths = HashSet::new();
+
+-        // Handle custom target specs, which are not included in `--print=all-target-specs-json`.
+-        if config.target.ends_with(".json") {
+-            targets.insert(
+-                config.target.clone(),
+-                serde_json::from_str(&rustc_output(
+-                    config,
+-                    &["--print=target-spec-json", "-Zunstable-options", "--target", &config.target],
+-                ))
+-                .unwrap(),
+-            );
++        // If current target is not included in the `--print=all-target-specs-json` output,
++        // we check whether it is a custom target from the user or a synthetic target from bootstrap.
++        if !targets.contains_key(&config.target) {
++            let mut envs: HashMap<String, String> = HashMap::new();
++
++            if let Ok(t) = std::env::var("RUST_TARGET_PATH") {
++                envs.insert("RUST_TARGET_PATH".into(), t);
++            }
++
++            // This returns false only when the target is neither a synthetic target
++            // nor a custom target from the user, indicating it is most likely invalid.
++            if config.target.ends_with(".json") || !envs.is_empty() {
++                targets.insert(
++                    config.target.clone(),
++                    serde_json::from_str(&rustc_output(
++                        config,
++                        &[
++                            "--print=target-spec-json",
++                            "-Zunstable-options",
++                            "--target",
++                            &config.target,
++                        ],
++                        envs,
++                    ))
++                    .unwrap(),
++                );
++            }
+         }
+
+         for (target, cfg) in targets.iter() {
+@@ -545,7 +563,9 @@ fn get_current_target_config(
+         // code below extracts them from `--print=cfg`: make sure to only override fields that can
+         // actually be changed with `-C` flags.
+         for config in
+-            rustc_output(config, &["--print=cfg", "--target", &config.target]).trim().lines()
++            rustc_output(config, &["--print=cfg", "--target", &config.target], Default::default())
++                .trim()
++                .lines()
+         {
+             let (name, value) = config
+                 .split_once("=\"")
+@@ -624,11 +644,12 @@ pub enum Endian {
+     Big,
+ }
+
+-fn rustc_output(config: &Config, args: &[&str]) -> String {
++fn rustc_output(config: &Config, args: &[&str], envs: HashMap<String, String>) -> String {
+     let mut command = Command::new(&config.rustc_path);
+     add_dylib_path(&mut command, iter::once(&config.compile_lib_path));
+     command.args(&config.target_rustcflags).args(args);
+     command.env("RUSTC_BOOTSTRAP", "1");
++    command.envs(envs);
+
+     let output = match command.output() {
+         Ok(output) => output,
+
-- 
2.43.0



^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH v2 3/5] rust: Enable RUSTC_BOOTSTRAP to use nightly features during rust oe-selftest.
  2024-01-19 15:09 [PATCH v2 1/5] rust: Fetch cargo from rust-snapshot dir Yash.Shinde
  2024-01-19 15:09 ` [PATCH v2 2/5] rust: detect user-specified custom targets in compiletest Yash.Shinde
@ 2024-01-19 15:09 ` Yash.Shinde
  2024-01-19 15:09 ` [PATCH v2 4/5] rust: Fix assertion failure error on oe-selftest Yash.Shinde
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 13+ messages in thread
From: Yash.Shinde @ 2024-01-19 15:09 UTC (permalink / raw)
  To: openembedded-core
  Cc: Randy.MacLeod, Umesh.Kallapa, Naveen.Gowda, Sundeep.Kokkonda,
	Shivaprasad.Moodalappa, Yash.Shinde

From: Yash Shinde <Yash.Shinde@windriver.com>

Fixes: error: the option `Z` is only accepted on the nightly compiler

When rust.channel is set to either beta or stable, we can't use
nightly features on bootstrap without RUSTC_BOOTSTRAP.
Set RUSTC_BOOTSTRAP=1 to use nightly features on stable or beta.

Signed-off-by: Yash Shinde <Yash.Shinde@windriver.com>
---
 .../rust/files/rustc-bootstrap.patch          | 21 +++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 meta/recipes-devtools/rust/files/rustc-bootstrap.patch

diff --git a/meta/recipes-devtools/rust/files/rustc-bootstrap.patch b/meta/recipes-devtools/rust/files/rustc-bootstrap.patch
new file mode 100644
index 0000000000..406fc610bb
--- /dev/null
+++ b/meta/recipes-devtools/rust/files/rustc-bootstrap.patch
@@ -0,0 +1,21 @@
+When rust.channel is set to either beta or stable, we can't use
+nightly features on bootstrap without RUSTC_BOOTSTRAP. Set RUSTC_BOOTSTRAP=1
+to use nightly features on stable or beta.
+
+Upstream-Status: Backport [https://github.com/rust-lang/rust/pull/119619/commits/8aa7dd06f6e50621dc10f9f9490681be8a45876f]
+
+Signed-off-by: onur-ozkan <work@onurozkan.dev>
+Signed-off-by: Yash Shinde <Yash.Shinde@windriver.com>
+---
+diff --git a/src/bootstrap/synthetic_targets.rs b/ src/bootstrap/synthetic_targets.rs
+index d2c65b740da..45baf56f46b 100644
+--- a/src/bootstrap/synthetic_targets.rs
++++ b/src/bootstrap/synthetic_targets.rs
+@@ -59,6 +59,7 @@ fn create_synthetic_target(
+     let mut cmd = Command::new(builder.rustc(compiler));
+     cmd.arg("--target").arg(base.rustc_target_arg());
+     cmd.args(["-Zunstable-options", "--print", "target-spec-json"]);
++    cmd.env("RUSTC_BOOTSTRAP", "1");
+     cmd.stdout(Stdio::piped());
+
+     let output = cmd.spawn().unwrap().wait_with_output().unwrap();
-- 
2.43.0



^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH v2 4/5] rust: Fix assertion failure error on oe-selftest
  2024-01-19 15:09 [PATCH v2 1/5] rust: Fetch cargo from rust-snapshot dir Yash.Shinde
  2024-01-19 15:09 ` [PATCH v2 2/5] rust: detect user-specified custom targets in compiletest Yash.Shinde
  2024-01-19 15:09 ` [PATCH v2 3/5] rust: Enable RUSTC_BOOTSTRAP to use nightly features during rust oe-selftest Yash.Shinde
@ 2024-01-19 15:09 ` Yash.Shinde
  2024-01-19 15:09 ` [PATCH v2 5/5] rust: Enable rust oe-selftest Yash.Shinde
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 13+ messages in thread
From: Yash.Shinde @ 2024-01-19 15:09 UTC (permalink / raw)
  To: openembedded-core
  Cc: Randy.MacLeod, Umesh.Kallapa, Naveen.Gowda, Sundeep.Kokkonda,
	Shivaprasad.Moodalappa, Yash.Shinde

From: Yash Shinde <Yash.Shinde@windriver.com>

Fixes: thread 'main' panicked at 'assertion failed: `(left == right)`
left: `x86_64-unknown-linux-gnu`,
right: `x86_64-poky-linux-gnu`: Cannot obtain compiler for non-native build triple at stage 0', compile.rs:1474:13

Add correct target value for cross-compiled targets on stage1 during rust oe-selfest.

Signed-off-by: Yash Shinde <Yash.Shinde@windriver.com>
---
 .../rust/files/target-build-value.patch       | 26 +++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 meta/recipes-devtools/rust/files/target-build-value.patch

diff --git a/meta/recipes-devtools/rust/files/target-build-value.patch b/meta/recipes-devtools/rust/files/target-build-value.patch
new file mode 100644
index 0000000000..23e8c76801
--- /dev/null
+++ b/meta/recipes-devtools/rust/files/target-build-value.patch
@@ -0,0 +1,26 @@
+Add correct build value for cross-compiled targets on stage1 when
+bootstapping rustc.
+
+Upstream-Status: Backport [https://github.com/rust-lang/rust/pull/119619/commits/b888e2f82b9dbe81875f50d13adbc0271a9401ff]
+
+Signed-off-by: onur-ozkan <work@onurozkan.dev>
+Signed-off-by: Yash Shinde <Yash.Shinde@windriver.com>
+---
+diff --git a/src/bootstrap/test.rs b/src/bootstrap/test.rs
+--- a/src/bootstrap/test.rs
++++ b/src/bootstrap/test.rs
+@@ -1489,8 +1489,12 @@
+         // NOTE: Only stage 1 is special cased because we need the rustc_private artifacts to match the
+         // running compiler in stage 2 when plugins run.
+         let stage_id = if suite == "ui-fulldeps" && compiler.stage == 1 {
+-            compiler = builder.compiler(compiler.stage - 1, target);
+-            format!("stage{}-{}", compiler.stage + 1, target)
++            // At stage 0 (stage - 1) we are using the beta compiler. Using `self.target` can lead finding
++            // an incorrect compiler path on cross-targets, as the stage 0 beta compiler is always equal
++            // to `build.build` in the configuration.
++            let build = builder.build.build;
++            compiler = builder.compiler(compiler.stage - 1, build);
++            format!("stage{}-{}", compiler.stage + 1, build)
+         } else {
+             format!("stage{}-{}", compiler.stage, target)
+         };
-- 
2.43.0



^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH v2 5/5] rust: Enable rust oe-selftest.
  2024-01-19 15:09 [PATCH v2 1/5] rust: Fetch cargo from rust-snapshot dir Yash.Shinde
                   ` (2 preceding siblings ...)
  2024-01-19 15:09 ` [PATCH v2 4/5] rust: Fix assertion failure error on oe-selftest Yash.Shinde
@ 2024-01-19 15:09 ` Yash.Shinde
  2024-01-20 17:01   ` Randy MacLeod
  2024-01-20  8:42 ` [OE-core] [PATCH v2 1/5] rust: Fetch cargo from rust-snapshot dir Richard Purdie
                   ` (2 subsequent siblings)
  6 siblings, 1 reply; 13+ messages in thread
From: Yash.Shinde @ 2024-01-19 15:09 UTC (permalink / raw)
  To: openembedded-core
  Cc: Randy.MacLeod, Umesh.Kallapa, Naveen.Gowda, Sundeep.Kokkonda,
	Shivaprasad.Moodalappa, Yash.Shinde

From: Yash Shinde <Yash.Shinde@windriver.com>

Tests which are failing from below modules are added to exclude list
	tests/run-make
	tests/rustdoc
	tests/mir-opt
	tests/ui-fulldeps

* Redundent test cases whose parent dir is also present in  exclud list are removed.

* Newly addded tests are sorted and updated.

* Overall exclude tests count in exclude list is now reduced to 114.

* The testing is done on arm32, arm64, mips64, x86 and  x86_64 targets.

Signed-off-by: Yash Shinde <Yash.Shinde@windriver.com>
---
 meta/lib/oeqa/selftest/cases/rust.py       | 165 +++++----------------
 meta/recipes-devtools/rust/rust-source.inc |   4 +
 2 files changed, 43 insertions(+), 126 deletions(-)

diff --git a/meta/lib/oeqa/selftest/cases/rust.py b/meta/lib/oeqa/selftest/cases/rust.py
index 6dbc517006..7d0efb1b01 100644
--- a/meta/lib/oeqa/selftest/cases/rust.py
+++ b/meta/lib/oeqa/selftest/cases/rust.py
@@ -40,7 +40,7 @@ def parse_results(filename):
 class RustSelfTestSystemEmulated(OESelftestTestCase, OEPTestResultTestCase):
     def test_rust(self, *args, **kwargs):
         # Disable Rust Oe-selftest
-        self.skipTest("The Rust Oe-selftest is disabled.")
+        #self.skipTest("The Rust Oe-selftest is disabled.")
 
         # build remote-test-server before image build
         recipe = "rust"
@@ -73,156 +73,90 @@ class RustSelfTestSystemEmulated(OESelftestTestCase, OEPTestResultTestCase):
                             'src/librustdoc',
                             'src/rustdoc-json-types',
                             'src/tools/compiletest/src/common.rs',
+                            'src/tools/jsondoclint',
                             'src/tools/lint-docs',
+                            'src/tools/replace-version-placeholder',
                             'src/tools/rust-analyzer',
                             'src/tools/rustdoc-themes',
                             'src/tools/tidy',
                             'tests/assembly/asm/aarch64-outline-atomics.rs',
+                            'tests/codegen/abi-efiapi.rs',
+                            'tests/codegen/abi-efiapi.rs',
                             'tests/codegen/abi-main-signature-32bit-c-int.rs',
                             'tests/codegen/abi-repr-ext.rs',
+                            'tests/codegen/abi-sysv64.rs',
                             'tests/codegen/abi-x86-interrupt.rs',
+                            'tests/codegen/align-byval.rs',
+                            'tests/codegen/align-fn.rs',
+                            'tests/codegen/asm-powerpc-clobbers.rs',
+                            'tests/codegen/async-fn-debug-awaitee-field.rs',
+                            'tests/codegen/binary-search-index-no-bound-check.rs',
                             'tests/codegen/branch-protection.rs',
+                            'tests/codegen/call-metadata.rs',
                             'tests/codegen/catch-unwind.rs',
                             'tests/codegen/cf-protection.rs',
+                            'tests/codegen/debug-column.rs',
+                            'tests/codegen/debug-limited.rs',
+                            'tests/codegen/debuginfo-generic-closure-env-names.rs',
+                            'tests/codegen/drop.rs',
+                            'tests/codegen/dst-vtable-align-nonzero.rs',
+                            'tests/codegen/enable-lto-unit-splitting.rs',
                             'tests/codegen/enum-bounds-check-derived-idx.rs',
+                            'tests/codegen/enum/enum-u128.rs',
+                            'tests/codegen/fn-impl-trait-self.rs',
                             'tests/codegen/force-unwind-tables.rs',
+                            'tests/codegen/inherit_overflow.rs',
+                            'tests/codegen/inherit_overflow.rs',
+                            'tests/codegen/inline-function-args-debug-info.rs',
                             'tests/codegen/intrinsic-no-unnamed-attr.rs',
+                            'tests/codegen/intrinsics/mask.rs',
+                            'tests/codegen/intrinsics/transmute-niched.rs',
                             'tests/codegen/issues/issue-103840.rs',
                             'tests/codegen/issues/issue-47278.rs',
+                            'tests/codegen/issues/issue-73258.rs',
                             'tests/codegen/issues/issue-73827-bounds-check-index-in-subexpr.rs',
+                            'tests/codegen/issues/issue-75546.rs',
+                            'tests/codegen/issues/issue-77812.rs',
+                            'tests/codegen/issues/issue-98156-const-arg-temp-lifetime.rs',
                             'tests/codegen/lifetime_start_end.rs',
+                            'tests/codegen/llvm-ident.rs',
                             'tests/codegen/local-generics-in-exe-internalized.rs',
+                            'tests/codegen/mainsubprogram.rs',
                             'tests/codegen/match-unoptimized.rs',
+                            'tests/codegen/move-operands.rs',
                             'tests/codegen/noalias-rwlockreadguard.rs',
                             'tests/codegen/non-terminate/nonempty-infinite-loop.rs',
                             'tests/codegen/noreturn-uninhabited.rs',
                             'tests/codegen/repr-transparent-aggregates-3.rs',
+                            'tests/codegen/repr/transparent-mips64.rs',
                             'tests/codegen/sse42-implies-crc32.rs',
                             'tests/codegen/thread-local.rs',
                             'tests/codegen/uninit-consts.rs',
+                            'tests/mir-opt/',
                             'tests/pretty/raw-str-nonexpr.rs',
                             'tests/run-make',
-                            'tests/run-make/cdylib-fewer-symbols/foo.rs',
-                            'tests/run-make/doctests-keep-binaries/t.rs',
-                            'tests/run-make-fulldeps',
-                            'tests/run-make/issue-22131/foo.rs',
-                            'tests/run-make/issue-36710/Makefile',
-                            'tests/run-make/issue-47551',
-                            'tests/run-make/pgo-branch-weights',
-                            'tests/run-make/pgo-gen',
-                            'tests/run-make/pgo-gen-lto',
-                            'tests/run-make/pgo-indirect-call-promotion',
-                            'tests/run-make/pgo-use',
-                            'tests/run-make/pointer-auth-link-with-c/Makefile',
-                            'tests/run-make/profile',
-                            'tests/run-make/static-pie',
-                            'tests/run-make/sysroot-crates-are-unstable',
-                            'tests/run-make/target-specs',
                             'tests/rustdoc',
-                            'tests/rustdoc/async-move-doctest.rs',
-                            'tests/rustdoc/async-trait.rs',
-                            'tests/rustdoc/auto-traits.rs',
-                            'tests/rustdoc/check-source-code-urls-to-def.rs',
-                            'tests/rustdoc/comment-in-doctest.rs',
-                            'tests/rustdoc/const-generics/const-generics-docs.rs',
-                            'tests/rustdoc/cross-crate-hidden-assoc-trait-items.rs',
-                            'tests/rustdoc/cross-crate-hidden-impl-parameter.rs',
-                            'tests/rustdoc/cross-crate-links.rs',
-                            'tests/rustdoc/cross-crate-primitive-doc.rs',
-                            'tests/rustdoc/doctest-manual-crate-name.rs',
-                            'tests/rustdoc/edition-doctest.rs',
-                            'tests/rustdoc/edition-flag.rs',
-                            'tests/rustdoc/elided-lifetime.rs',
-                            'tests/rustdoc/external-macro-src.rs',
-                            'tests/rustdoc/extern-html-root-url.rs',
-                            'tests/rustdoc/extern-impl-trait.rs',
-                            'tests/rustdoc/hide-unstable-trait.rs',
-                            'tests/rustdoc/inline_cross/add-docs.rs',
-                            'tests/rustdoc/inline_cross/default-trait-method.rs',
-                            'tests/rustdoc/inline_cross/dyn_trait.rs',
-                            'tests/rustdoc/inline_cross/impl_trait.rs',
-                            'tests/rustdoc/inline_cross/issue-24183.rs',
-                            'tests/rustdoc/inline_cross/macros.rs',
-                            'tests/rustdoc/inline_cross/trait-vis.rs',
-                            'tests/rustdoc/inline_cross/use_crate.rs',
-                            'tests/rustdoc/intra-doc-crate/self.rs',
-                            'tests/rustdoc/intra-doc/cross-crate/additional_doc.rs',
-                            'tests/rustdoc/intra-doc/cross-crate/basic.rs',
-                            'tests/rustdoc/intra-doc/cross-crate/crate.rs',
-                            'tests/rustdoc/intra-doc/cross-crate/hidden.rs',
-                            'tests/rustdoc/intra-doc/cross-crate/macro.rs',
-                            'tests/rustdoc/intra-doc/cross-crate/module.rs',
-                            'tests/rustdoc/intra-doc/cross-crate/submodule-inner.rs',
-                            'tests/rustdoc/intra-doc/cross-crate/submodule-outer.rs',
-                            'tests/rustdoc/intra-doc/cross-crate/traits.rs',
-                            'tests/rustdoc/intra-doc/extern-builtin-type-impl.rs',
-                            'tests/rustdoc/intra-doc/extern-crate-only-used-in-link.rs',
-                            'tests/rustdoc/intra-doc/extern-crate.rs',
-                            'tests/rustdoc/intra-doc/extern-inherent-impl.rs',
-                            'tests/rustdoc/intra-doc/extern-reference-link.rs',
-                            'tests/rustdoc/intra-doc/issue-103463.rs',
-                            'tests/rustdoc/intra-doc/issue-104145.rs',
-                            'tests/rustdoc/intra-doc/issue-66159.rs',
-                            'tests/rustdoc/intra-doc/pub-use.rs',
-                            'tests/rustdoc/intra-doc/reexport-additional-docs.rs',
-                            'tests/rustdoc/issue-18199.rs',
-                            'tests/rustdoc/issue-23106.rs',
-                            'tests/rustdoc/issue-23744.rs',
-                            'tests/rustdoc/issue-25944.rs',
-                            'tests/rustdoc/issue-30252.rs',
-                            'tests/rustdoc/issue-38129.rs',
-                            'tests/rustdoc/issue-40936.rs',
-                            'tests/rustdoc/issue-43153.rs',
-                            'tests/rustdoc/issue-46727.rs',
-                            'tests/rustdoc/issue-48377.rs',
-                            'tests/rustdoc/issue-48414.rs',
-                            'tests/rustdoc/issue-53689.rs',
-                            'tests/rustdoc/issue-54478-demo-allocator.rs',
-                            'tests/rustdoc/issue-57180.rs',
-                            'tests/rustdoc/issue-61592.rs',
-                            'tests/rustdoc/issue-73061-cross-crate-opaque-assoc-type.rs',
-                            'tests/rustdoc/issue-75588.rs',
-                            'tests/rustdoc/issue-85454.rs',
-                            'tests/rustdoc/issue-86620.rs',
-                            'tests/rustdoc-json',
                             'tests/rustdoc-js-std',
-                            'tests/rustdoc/macro_pub_in_module.rs',
-                            'tests/rustdoc/masked.rs',
-                            'tests/rustdoc/normalize-assoc-item.rs',
-                            'tests/rustdoc/no-stack-overflow-25295.rs',
-                            'tests/rustdoc/primitive-reexport.rs',
-                            'tests/rustdoc/process-termination.rs',
-                            'tests/rustdoc/pub-extern-crate.rs',
-                            'tests/rustdoc/pub-use-extern-macros.rs',
-                            'tests/rustdoc/reexport-check.rs',
-                            'tests/rustdoc/reexport-dep-foreign-fn.rs',
-                            'tests/rustdoc/reexport-doc.rs',
-                            'tests/rustdoc/reexports-priv.rs',
-                            'tests/rustdoc/reexports.rs',
-                            'tests/rustdoc/rustc,-incoherent-impls.rs',
-                            'tests/rustdoc/test_option_check/bar.rs',
-                            'tests/rustdoc/test_option_check/test.rs',
-                            'tests/rustdoc/trait-alias-mention.rs',
-                            'tests/rustdoc/trait-visibility.rs',
+                            'tests/rustdoc-json',
                             'tests/rustdoc-ui/cfg-test.rs',
                             'tests/rustdoc-ui/check-cfg-test.rs',
                             'tests/rustdoc-ui/display-output.rs',
                             'tests/rustdoc-ui/doc-comment-multi-line-attr.rs',
                             'tests/rustdoc-ui/doc-comment-multi-line-cfg-attr.rs',
                             'tests/rustdoc-ui/doc-test-doctest-feature.rs',
+                            'tests/rustdoc-ui/doc-test-rustdoc-feature.rs',
                             'tests/rustdoc-ui/doctest-multiline-crate-attribute.rs',
                             'tests/rustdoc-ui/doctest-output.rs',
-                            'tests/rustdoc-ui/doc-test-rustdoc-feature.rs',
                             'tests/rustdoc-ui/failed-doctest-compile-fail.rs',
                             'tests/rustdoc-ui/issue-80992.rs',
                             'tests/rustdoc-ui/issue-91134.rs',
+                            'tests/rustdoc-ui/no-run-flag.rs',
                             'tests/rustdoc-ui/nocapture-fail.rs',
                             'tests/rustdoc-ui/nocapture.rs',
-                            'tests/rustdoc-ui/no-run-flag.rs',
                             'tests/rustdoc-ui/run-directory.rs',
                             'tests/rustdoc-ui/test-no_std.rs',
                             'tests/rustdoc-ui/test-type.rs',
-                            'tests/rustdoc/unit-return.rs',
+                            'tests/ui-fulldeps/',
                             'tests/ui/abi/stack-probes-lto.rs',
                             'tests/ui/abi/stack-probes.rs',
                             'tests/ui/array-slice-vec/subslice-patterns-const-eval-match.rs',
@@ -233,31 +167,10 @@ class RustSelfTestSystemEmulated(OESelftestTestCase, OEPTestResultTestCase):
                             'tests/ui/debuginfo/debuginfo-emit-llvm-ir-and-split-debuginfo.rs',
                             'tests/ui/drop/dynamic-drop.rs',
                             'tests/ui/empty_global_asm.rs',
-                            'tests/ui-fulldeps/deriving-encodable-decodable-box.rs',
-                            'tests/ui-fulldeps/deriving-encodable-decodable-cell-refcell.rs',
-                            'tests/ui-fulldeps/deriving-global.rs',
-                            'tests/ui-fulldeps/deriving-hygiene.rs',
-                            'tests/ui-fulldeps/dropck_tarena_sound_drop.rs',
-                            'tests/ui-fulldeps/empty-struct-braces-derive.rs',
-                            'tests/ui-fulldeps/internal-lints/bad_opt_access.rs',
-                            'tests/ui-fulldeps/internal-lints/bad_opt_access.stderr',
-                            'tests/ui-fulldeps/internal-lints/default_hash_types.rs',
-                            'tests/ui-fulldeps/internal-lints/diagnostics.rs',
-                            'tests/ui-fulldeps/internal-lints/lint_pass_impl_without_macro.rs',
-                            'tests/ui-fulldeps/internal-lints/qualified_ty_ty_ctxt.rs',
-                            'tests/ui-fulldeps/internal-lints/query_stability.rs',
-                            'tests/ui-fulldeps/internal-lints/rustc_pass_by_value.rs',
-                            'tests/ui-fulldeps/internal-lints/ty_tykind_usage.rs',
-                            'tests/ui-fulldeps/issue-14021.rs',
-                            'tests/ui-fulldeps/lint-group-denied-lint-allowed.rs',
-                            'tests/ui-fulldeps/lint-group-forbid-always-trumps-cli.rs',
-                            'tests/ui-fulldeps/lint-pass-macros.rs',
-                            'tests/ui-fulldeps/regions-mock-tcx.rs',
-                            'tests/ui-fulldeps/rustc_encodable_hygiene.rs',
-                            'tests/ui-fulldeps/session-diagnostic/enforce_slug_naming.rs',
                             'tests/ui/functions-closures/fn-help-with-err.rs',
                             'tests/ui/linkage-attr/issue-10755.rs',
                             'tests/ui/macros/restricted-shadowing-legacy.rs',
+                            'tests/ui/numbers-arithmetic/u128.rs',
                             'tests/ui/process/nofile-limit.rs',
                             'tests/ui/process/process-panic-after-fork.rs',
                             'tests/ui/process/process-sigpipe.rs',
diff --git a/meta/recipes-devtools/rust/rust-source.inc b/meta/recipes-devtools/rust/rust-source.inc
index 83a0dbc15f..e02829e6b3 100644
--- a/meta/recipes-devtools/rust/rust-source.inc
+++ b/meta/recipes-devtools/rust/rust-source.inc
@@ -10,6 +10,10 @@ SRC_URI += "https://static.rust-lang.org/dist/rustc-${RUST_VERSION}-src.tar.xz;n
             file://0004-musl-Define-O_LARGEFILE-for-riscv32.patch;patchdir=${RUSTSRC} \
             file://0005-musl-Define-SOCK_SEQPACKET-in-common-place.patch;patchdir=${RUSTSRC} \
             file://0001-Revert-Map-source-absolute-paths-to-OUT_DIR-as-relat.patch;patchdir=${RUSTSRC} \
+            file://cargo-path.patch;patchdir=${RUSTSRC} \
+            file://custom-target-cfg.patch;patchdir=${RUSTSRC} \
+            file://rustc-bootstrap.patch;patchdir=${RUSTSRC} \
+            file://target-build-value.patch;patchdir=${RUSTSRC} \
 "
 SRC_URI[rust.sha256sum] = "b98c09d968529212fb29eec7d6d3e9bdaa869810679b7fb86a1ca69469d75f5e"
 
-- 
2.43.0



^ permalink raw reply related	[flat|nested] 13+ messages in thread

* Re: [PATCH v2 5/5] rust: Enable rust oe-selftest.
  2024-01-19 15:09 ` [PATCH v2 5/5] rust: Enable rust oe-selftest Yash.Shinde
@ 2024-01-20 17:01   ` Randy MacLeod
  2024-01-22 10:59     ` Yash Shinde
  0 siblings, 1 reply; 13+ messages in thread
From: Randy MacLeod @ 2024-01-20 17:01 UTC (permalink / raw)
  To: Yash.Shinde, openembedded-core, Richard Purdie
  Cc: Umesh.Kallapa, Naveen.Gowda, Sundeep.Kokkonda,
	Shivaprasad.Moodalappa

[-- Attachment #1: Type: text/plain, Size: 14038 bytes --]

I like that you have broken the original patch down into 5 patches that 
are easier to
understand.

On 2024-01-19 10:09 a.m., Yash.Shinde@windriver.com wrote:
> From: Yash Shinde<Yash.Shinde@windriver.com>
>
> Tests which are failing from below modules are added to exclude list
> 	tests/run-make
> 	tests/rustdoc
> 	tests/mir-opt
> 	tests/ui-fulldeps
>
> * Redundent test cases whose parent dir is also present in  exclud list are removed.
>
> * Newly addded tests are sorted and updated.
>
> * Overall exclude tests count in exclude list is now reduced to 114.
We need to resolve the mips32 problems that Richard pointed out.

Should we skip all the rust tests for mips32?


Please submit a v3 with the mips fix/avoidance and split this exclude 
list commit down into 3 steps:

  1. Sort the existing list of tests
  2. Remove the test cases whose parent dir is also present in the 
exclude list

  3. Add the new tests that are to be excluded.

This may seem really pedantic but otherwise the changes are really hard 
to review.

The way I think about this is that someone looking at the commit log 
might be interested
in exactly which tests are in being added to the exclude list so that 
should be clear from 3.
1. won't really be of interest so most people will skip over that
2. also won't be of interest to most people
but you need 1 and 2 to make 3 be apparent to people who want that info 
quickly.

Thanks,

../Randy

>
> * The testing is done on arm32, arm64, mips64, x86 and  x86_64 targets.
>
> Signed-off-by: Yash Shinde<Yash.Shinde@windriver.com>
> ---
>   meta/lib/oeqa/selftest/cases/rust.py       | 165 +++++----------------
>   meta/recipes-devtools/rust/rust-source.inc |   4 +
>   2 files changed, 43 insertions(+), 126 deletions(-)
>
> diff --git a/meta/lib/oeqa/selftest/cases/rust.py b/meta/lib/oeqa/selftest/cases/rust.py
> index 6dbc517006..7d0efb1b01 100644
> --- a/meta/lib/oeqa/selftest/cases/rust.py
> +++ b/meta/lib/oeqa/selftest/cases/rust.py
> @@ -40,7 +40,7 @@ def parse_results(filename):
>   class RustSelfTestSystemEmulated(OESelftestTestCase, OEPTestResultTestCase):
>       def test_rust(self, *args, **kwargs):
>           # Disable Rust Oe-selftest
> -        self.skipTest("The Rust Oe-selftest is disabled.")
> +        #self.skipTest("The Rust Oe-selftest is disabled.")
>   
>           # build remote-test-server before image build
>           recipe = "rust" @@ -73,156 +73,90 @@ class 
> RustSelfTestSystemEmulated(OESelftestTestCase, OEPTestResultTestCase): 
> 'src/librustdoc', 'src/rustdoc-json-types', 
> 'src/tools/compiletest/src/common.rs', + 'src/tools/jsondoclint', 
> 'src/tools/lint-docs', + 'src/tools/replace-version-placeholder', 
> 'src/tools/rust-analyzer', 'src/tools/rustdoc-themes', 
> 'src/tools/tidy', 'tests/assembly/asm/aarch64-outline-atomics.rs', + 
> 'tests/codegen/abi-efiapi.rs', + 'tests/codegen/abi-efiapi.rs', 
> 'tests/codegen/abi-main-signature-32bit-c-int.rs', 
> 'tests/codegen/abi-repr-ext.rs', + 'tests/codegen/abi-sysv64.rs', 
> 'tests/codegen/abi-x86-interrupt.rs', + 
> 'tests/codegen/align-byval.rs', + 'tests/codegen/align-fn.rs', + 
> 'tests/codegen/asm-powerpc-clobbers.rs', + 
> 'tests/codegen/async-fn-debug-awaitee-field.rs', + 
> 'tests/codegen/binary-search-index-no-bound-check.rs', 
> 'tests/codegen/branch-protection.rs', + 
> 'tests/codegen/call-metadata.rs', 'tests/codegen/catch-unwind.rs', 
> 'tests/codegen/cf-protection.rs', + 'tests/codegen/debug-column.rs', + 
> 'tests/codegen/debug-limited.rs', + 
> 'tests/codegen/debuginfo-generic-closure-env-names.rs', + 
> 'tests/codegen/drop.rs', + 
> 'tests/codegen/dst-vtable-align-nonzero.rs', + 
> 'tests/codegen/enable-lto-unit-splitting.rs', 
> 'tests/codegen/enum-bounds-check-derived-idx.rs', + 
> 'tests/codegen/enum/enum-u128.rs', + 
> 'tests/codegen/fn-impl-trait-self.rs', 
> 'tests/codegen/force-unwind-tables.rs', + 
> 'tests/codegen/inherit_overflow.rs', + 
> 'tests/codegen/inherit_overflow.rs', + 
> 'tests/codegen/inline-function-args-debug-info.rs', 
> 'tests/codegen/intrinsic-no-unnamed-attr.rs', + 
> 'tests/codegen/intrinsics/mask.rs', + 
> 'tests/codegen/intrinsics/transmute-niched.rs', 
> 'tests/codegen/issues/issue-103840.rs', 
> 'tests/codegen/issues/issue-47278.rs', + 
> 'tests/codegen/issues/issue-73258.rs', 
> 'tests/codegen/issues/issue-73827-bounds-check-index-in-subexpr.rs', + 
> 'tests/codegen/issues/issue-75546.rs', + 
> 'tests/codegen/issues/issue-77812.rs', + 
> 'tests/codegen/issues/issue-98156-const-arg-temp-lifetime.rs', 
> 'tests/codegen/lifetime_start_end.rs', + 
> 'tests/codegen/llvm-ident.rs', 
> 'tests/codegen/local-generics-in-exe-internalized.rs', + 
> 'tests/codegen/mainsubprogram.rs', 
> 'tests/codegen/match-unoptimized.rs', + 
> 'tests/codegen/move-operands.rs', 
> 'tests/codegen/noalias-rwlockreadguard.rs', 
> 'tests/codegen/non-terminate/nonempty-infinite-loop.rs', 
> 'tests/codegen/noreturn-uninhabited.rs', 
> 'tests/codegen/repr-transparent-aggregates-3.rs', + 
> 'tests/codegen/repr/transparent-mips64.rs', 
> 'tests/codegen/sse42-implies-crc32.rs', 
> 'tests/codegen/thread-local.rs', 'tests/codegen/uninit-consts.rs', + 
> 'tests/mir-opt/', 'tests/pretty/raw-str-nonexpr.rs', 'tests/run-make', 
> - 'tests/run-make/cdylib-fewer-symbols/foo.rs', - 
> 'tests/run-make/doctests-keep-binaries/t.rs', - 
> 'tests/run-make-fulldeps', - 'tests/run-make/issue-22131/foo.rs', - 
> 'tests/run-make/issue-36710/Makefile', - 'tests/run-make/issue-47551', 
> - 'tests/run-make/pgo-branch-weights', - 'tests/run-make/pgo-gen', - 
> 'tests/run-make/pgo-gen-lto', - 
> 'tests/run-make/pgo-indirect-call-promotion', - 
> 'tests/run-make/pgo-use', - 
> 'tests/run-make/pointer-auth-link-with-c/Makefile', - 
> 'tests/run-make/profile', - 'tests/run-make/static-pie', - 
> 'tests/run-make/sysroot-crates-are-unstable', - 
> 'tests/run-make/target-specs', 'tests/rustdoc', - 
> 'tests/rustdoc/async-move-doctest.rs', - 
> 'tests/rustdoc/async-trait.rs', - 'tests/rustdoc/auto-traits.rs', - 
> 'tests/rustdoc/check-source-code-urls-to-def.rs', - 
> 'tests/rustdoc/comment-in-doctest.rs', - 
> 'tests/rustdoc/const-generics/const-generics-docs.rs', - 
> 'tests/rustdoc/cross-crate-hidden-assoc-trait-items.rs', - 
> 'tests/rustdoc/cross-crate-hidden-impl-parameter.rs', - 
> 'tests/rustdoc/cross-crate-links.rs', - 
> 'tests/rustdoc/cross-crate-primitive-doc.rs', - 
> 'tests/rustdoc/doctest-manual-crate-name.rs', - 
> 'tests/rustdoc/edition-doctest.rs', - 'tests/rustdoc/edition-flag.rs', 
> - 'tests/rustdoc/elided-lifetime.rs', - 
> 'tests/rustdoc/external-macro-src.rs', - 
> 'tests/rustdoc/extern-html-root-url.rs', - 
> 'tests/rustdoc/extern-impl-trait.rs', - 
> 'tests/rustdoc/hide-unstable-trait.rs', - 
> 'tests/rustdoc/inline_cross/add-docs.rs', - 
> 'tests/rustdoc/inline_cross/default-trait-method.rs', - 
> 'tests/rustdoc/inline_cross/dyn_trait.rs', - 
> 'tests/rustdoc/inline_cross/impl_trait.rs', - 
> 'tests/rustdoc/inline_cross/issue-24183.rs', - 
> 'tests/rustdoc/inline_cross/macros.rs', - 
> 'tests/rustdoc/inline_cross/trait-vis.rs', - 
> 'tests/rustdoc/inline_cross/use_crate.rs', - 
> 'tests/rustdoc/intra-doc-crate/self.rs', - 
> 'tests/rustdoc/intra-doc/cross-crate/additional_doc.rs', - 
> 'tests/rustdoc/intra-doc/cross-crate/basic.rs', - 
> 'tests/rustdoc/intra-doc/cross-crate/crate.rs', - 
> 'tests/rustdoc/intra-doc/cross-crate/hidden.rs', - 
> 'tests/rustdoc/intra-doc/cross-crate/macro.rs', - 
> 'tests/rustdoc/intra-doc/cross-crate/module.rs', - 
> 'tests/rustdoc/intra-doc/cross-crate/submodule-inner.rs', - 
> 'tests/rustdoc/intra-doc/cross-crate/submodule-outer.rs', - 
> 'tests/rustdoc/intra-doc/cross-crate/traits.rs', - 
> 'tests/rustdoc/intra-doc/extern-builtin-type-impl.rs', - 
> 'tests/rustdoc/intra-doc/extern-crate-only-used-in-link.rs', - 
> 'tests/rustdoc/intra-doc/extern-crate.rs', - 
> 'tests/rustdoc/intra-doc/extern-inherent-impl.rs', - 
> 'tests/rustdoc/intra-doc/extern-reference-link.rs', - 
> 'tests/rustdoc/intra-doc/issue-103463.rs', - 
> 'tests/rustdoc/intra-doc/issue-104145.rs', - 
> 'tests/rustdoc/intra-doc/issue-66159.rs', - 
> 'tests/rustdoc/intra-doc/pub-use.rs', - 
> 'tests/rustdoc/intra-doc/reexport-additional-docs.rs', - 
> 'tests/rustdoc/issue-18199.rs', - 'tests/rustdoc/issue-23106.rs', - 
> 'tests/rustdoc/issue-23744.rs', - 'tests/rustdoc/issue-25944.rs', - 
> 'tests/rustdoc/issue-30252.rs', - 'tests/rustdoc/issue-38129.rs', - 
> 'tests/rustdoc/issue-40936.rs', - 'tests/rustdoc/issue-43153.rs', - 
> 'tests/rustdoc/issue-46727.rs', - 'tests/rustdoc/issue-48377.rs', - 
> 'tests/rustdoc/issue-48414.rs', - 'tests/rustdoc/issue-53689.rs', - 
> 'tests/rustdoc/issue-54478-demo-allocator.rs', - 
> 'tests/rustdoc/issue-57180.rs', - 'tests/rustdoc/issue-61592.rs', - 
> 'tests/rustdoc/issue-73061-cross-crate-opaque-assoc-type.rs', - 
> 'tests/rustdoc/issue-75588.rs', - 'tests/rustdoc/issue-85454.rs', - 
> 'tests/rustdoc/issue-86620.rs', - 'tests/rustdoc-json', 
> 'tests/rustdoc-js-std', - 'tests/rustdoc/macro_pub_in_module.rs', - 
> 'tests/rustdoc/masked.rs', - 'tests/rustdoc/normalize-assoc-item.rs', 
> - 'tests/rustdoc/no-stack-overflow-25295.rs', - 
> 'tests/rustdoc/primitive-reexport.rs', - 
> 'tests/rustdoc/process-termination.rs', - 
> 'tests/rustdoc/pub-extern-crate.rs', - 
> 'tests/rustdoc/pub-use-extern-macros.rs', - 
> 'tests/rustdoc/reexport-check.rs', - 
> 'tests/rustdoc/reexport-dep-foreign-fn.rs', - 
> 'tests/rustdoc/reexport-doc.rs', - 'tests/rustdoc/reexports-priv.rs', 
> - 'tests/rustdoc/reexports.rs', - 
> 'tests/rustdoc/rustc,-incoherent-impls.rs', - 
> 'tests/rustdoc/test_option_check/bar.rs', - 
> 'tests/rustdoc/test_option_check/test.rs', - 
> 'tests/rustdoc/trait-alias-mention.rs', - 
> 'tests/rustdoc/trait-visibility.rs', + 'tests/rustdoc-json', 
> 'tests/rustdoc-ui/cfg-test.rs', 'tests/rustdoc-ui/check-cfg-test.rs', 
> 'tests/rustdoc-ui/display-output.rs', 
> 'tests/rustdoc-ui/doc-comment-multi-line-attr.rs', 
> 'tests/rustdoc-ui/doc-comment-multi-line-cfg-attr.rs', 
> 'tests/rustdoc-ui/doc-test-doctest-feature.rs', + 
> 'tests/rustdoc-ui/doc-test-rustdoc-feature.rs', 
> 'tests/rustdoc-ui/doctest-multiline-crate-attribute.rs', 
> 'tests/rustdoc-ui/doctest-output.rs', - 
> 'tests/rustdoc-ui/doc-test-rustdoc-feature.rs', 
> 'tests/rustdoc-ui/failed-doctest-compile-fail.rs', 
> 'tests/rustdoc-ui/issue-80992.rs', 'tests/rustdoc-ui/issue-91134.rs', 
> + 'tests/rustdoc-ui/no-run-flag.rs', 
> 'tests/rustdoc-ui/nocapture-fail.rs', 'tests/rustdoc-ui/nocapture.rs', 
> - 'tests/rustdoc-ui/no-run-flag.rs', 
> 'tests/rustdoc-ui/run-directory.rs', 
> 'tests/rustdoc-ui/test-no_std.rs', 'tests/rustdoc-ui/test-type.rs', - 
> 'tests/rustdoc/unit-return.rs', + 'tests/ui-fulldeps/', 
> 'tests/ui/abi/stack-probes-lto.rs', 'tests/ui/abi/stack-probes.rs', 
> 'tests/ui/array-slice-vec/subslice-patterns-const-eval-match.rs', @@ 
> -233,31 +167,10 @@ class 
> RustSelfTestSystemEmulated(OESelftestTestCase, OEPTestResultTestCase): 
> 'tests/ui/debuginfo/debuginfo-emit-llvm-ir-and-split-debuginfo.rs', 
> 'tests/ui/drop/dynamic-drop.rs', 'tests/ui/empty_global_asm.rs', - 
> 'tests/ui-fulldeps/deriving-encodable-decodable-box.rs', - 
> 'tests/ui-fulldeps/deriving-encodable-decodable-cell-refcell.rs', - 
> 'tests/ui-fulldeps/deriving-global.rs', - 
> 'tests/ui-fulldeps/deriving-hygiene.rs', - 
> 'tests/ui-fulldeps/dropck_tarena_sound_drop.rs', - 
> 'tests/ui-fulldeps/empty-struct-braces-derive.rs', - 
> 'tests/ui-fulldeps/internal-lints/bad_opt_access.rs', - 
> 'tests/ui-fulldeps/internal-lints/bad_opt_access.stderr', - 
> 'tests/ui-fulldeps/internal-lints/default_hash_types.rs', - 
> 'tests/ui-fulldeps/internal-lints/diagnostics.rs', - 
> 'tests/ui-fulldeps/internal-lints/lint_pass_impl_without_macro.rs', - 
> 'tests/ui-fulldeps/internal-lints/qualified_ty_ty_ctxt.rs', - 
> 'tests/ui-fulldeps/internal-lints/query_stability.rs', - 
> 'tests/ui-fulldeps/internal-lints/rustc_pass_by_value.rs', - 
> 'tests/ui-fulldeps/internal-lints/ty_tykind_usage.rs', - 
> 'tests/ui-fulldeps/issue-14021.rs', - 
> 'tests/ui-fulldeps/lint-group-denied-lint-allowed.rs', - 
> 'tests/ui-fulldeps/lint-group-forbid-always-trumps-cli.rs', - 
> 'tests/ui-fulldeps/lint-pass-macros.rs', - 
> 'tests/ui-fulldeps/regions-mock-tcx.rs', - 
> 'tests/ui-fulldeps/rustc_encodable_hygiene.rs', - 
> 'tests/ui-fulldeps/session-diagnostic/enforce_slug_naming.rs', 
> 'tests/ui/functions-closures/fn-help-with-err.rs', 
> 'tests/ui/linkage-attr/issue-10755.rs', 
> 'tests/ui/macros/restricted-shadowing-legacy.rs', + 
> 'tests/ui/numbers-arithmetic/u128.rs', 
> 'tests/ui/process/nofile-limit.rs', 
> 'tests/ui/process/process-panic-after-fork.rs', 
> 'tests/ui/process/process-sigpipe.rs', diff --git 
> a/meta/recipes-devtools/rust/rust-source.inc 
> b/meta/recipes-devtools/rust/rust-source.inc index 
> 83a0dbc15f..e02829e6b3 100644 --- 
> a/meta/recipes-devtools/rust/rust-source.inc +++ 
> b/meta/recipes-devtools/rust/rust-source.inc @@ -10,6 +10,10 @@ 
> SRC_URI += "https://static.rust-lang.org/dist/rustc-${RUST_VERSION}-src.tar.xz;n
>               file://0004-musl-Define-O_LARGEFILE-for-riscv32.patch;patchdir=${RUSTSRC} \
>               file://0005-musl-Define-SOCK_SEQPACKET-in-common-place.patch;patchdir=${RUSTSRC} \
>               file://0001-Revert-Map-source-absolute-paths-to-OUT_DIR-as-relat.patch;patchdir=${RUSTSRC} \
> +            file://cargo-path.patch;patchdir=${RUSTSRC} \
> +            file://custom-target-cfg.patch;patchdir=${RUSTSRC} \
> +            file://rustc-bootstrap.patch;patchdir=${RUSTSRC} \
> +            file://target-build-value.patch;patchdir=${RUSTSRC} \
>   "
>   SRC_URI[rust.sha256sum] = "b98c09d968529212fb29eec7d6d3e9bdaa869810679b7fb86a1ca69469d75f5e"
>   


-- 
# Randy MacLeod
# Wind River Linux

[-- Attachment #2: Type: text/html, Size: 30426 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v2 5/5] rust: Enable rust oe-selftest.
  2024-01-20 17:01   ` Randy MacLeod
@ 2024-01-22 10:59     ` Yash Shinde
  2024-01-22 11:01       ` Shinde, Yash
  0 siblings, 1 reply; 13+ messages in thread
From: Yash Shinde @ 2024-01-22 10:59 UTC (permalink / raw)
  To: Randy MacLeod, openembedded-core, Richard Purdie
  Cc: Umesh.Kallapa, Naveen.Gowda, Sundeep.Kokkonda,
	Shivaprasad.Moodalappa

[-- Attachment #1: Type: text/plain, Size: 14752 bytes --]


On 20-01-2024 22:31, Randy MacLeod wrote:
> I like that you have broken the original patch down into 5 patches 
> that are easier to
> understand.
>
> On 2024-01-19 10:09 a.m., Yash.Shinde@windriver.com wrote:
>> From: Yash Shinde<Yash.Shinde@windriver.com>
>>
>> Tests which are failing from below modules are added to exclude list
>> 	tests/run-make
>> 	tests/rustdoc
>> 	tests/mir-opt
>> 	tests/ui-fulldeps
>>
>> * Redundent test cases whose parent dir is also present in  exclud list are removed.
>>
>> * Newly addded tests are sorted and updated.
>>
>> * Overall exclude tests count in exclude list is now reduced to 114.
> We need to resolve the mips32 problems that Richard pointed out.
>
> Should we skip all the rust tests for mips32?
>
In previous oe-selftest implementation, we skipped rust tests for mips32.
I think we should continue with it as rust tests are unstable with mips32.

>
> Please submit a v3 with the mips fix/avoidance and split this exclude 
> list commit down into 3 steps:
>
>  1. Sort the existing list of tests
>  2. Remove the test cases whose parent dir is also present in the 
> exclude list
>
>  3. Add the new tests that are to be excluded.
>
> This may seem really pedantic but otherwise the changes are really 
> hard to review.
>
> The way I think about this is that someone looking at the commit log 
> might be interested
> in exactly which tests are in being added to the exclude list so that 
> should be clear from 3.
> 1. won't really be of interest so most people will skip over that
> 2. also won't be of interest to most people
> but you need 1 and 2 to make 3 be apparent to people who want that 
> info quickly.
>
For 1 the existing list of tests are already sorted.
I will send a v3 with separate commits for:

1. newly added test cases
2. removing test cases whose parent dir is also present in the exclude 
list 3. sorting the overall final list Regards, Yash

> Thanks,
>
> ../Randy
>
>> * The testing is done on arm32, arm64, mips64, x86 and  x86_64 targets.
>>
>> Signed-off-by: Yash Shinde<Yash.Shinde@windriver.com>
>> ---
>>   meta/lib/oeqa/selftest/cases/rust.py       | 165 +++++----------------
>>   meta/recipes-devtools/rust/rust-source.inc |   4 +
>>   2 files changed, 43 insertions(+), 126 deletions(-)
>>
>> diff --git a/meta/lib/oeqa/selftest/cases/rust.py b/meta/lib/oeqa/selftest/cases/rust.py
>> index 6dbc517006..7d0efb1b01 100644
>> --- a/meta/lib/oeqa/selftest/cases/rust.py
>> +++ b/meta/lib/oeqa/selftest/cases/rust.py
>> @@ -40,7 +40,7 @@ def parse_results(filename):
>>   class RustSelfTestSystemEmulated(OESelftestTestCase, OEPTestResultTestCase):
>>       def test_rust(self, *args, **kwargs):
>>           # Disable Rust Oe-selftest
>> -        self.skipTest("The Rust Oe-selftest is disabled.")
>> +        #self.skipTest("The Rust Oe-selftest is disabled.")
>>   
>>           # build remote-test-server before image build
>>           recipe = "rust" @@ -73,156 +73,90 @@ class 
>> RustSelfTestSystemEmulated(OESelftestTestCase, 
>> OEPTestResultTestCase): 'src/librustdoc', 'src/rustdoc-json-types', 
>> 'src/tools/compiletest/src/common.rs', + 'src/tools/jsondoclint', 
>> 'src/tools/lint-docs', + 'src/tools/replace-version-placeholder', 
>> 'src/tools/rust-analyzer', 'src/tools/rustdoc-themes', 
>> 'src/tools/tidy', 'tests/assembly/asm/aarch64-outline-atomics.rs', + 
>> 'tests/codegen/abi-efiapi.rs', + 'tests/codegen/abi-efiapi.rs', 
>> 'tests/codegen/abi-main-signature-32bit-c-int.rs', 
>> 'tests/codegen/abi-repr-ext.rs', + 'tests/codegen/abi-sysv64.rs', 
>> 'tests/codegen/abi-x86-interrupt.rs', + 
>> 'tests/codegen/align-byval.rs', + 'tests/codegen/align-fn.rs', + 
>> 'tests/codegen/asm-powerpc-clobbers.rs', + 
>> 'tests/codegen/async-fn-debug-awaitee-field.rs', + 
>> 'tests/codegen/binary-search-index-no-bound-check.rs', 
>> 'tests/codegen/branch-protection.rs', + 
>> 'tests/codegen/call-metadata.rs', 'tests/codegen/catch-unwind.rs', 
>> 'tests/codegen/cf-protection.rs', + 'tests/codegen/debug-column.rs', 
>> + 'tests/codegen/debug-limited.rs', + 
>> 'tests/codegen/debuginfo-generic-closure-env-names.rs', + 
>> 'tests/codegen/drop.rs', + 
>> 'tests/codegen/dst-vtable-align-nonzero.rs', + 
>> 'tests/codegen/enable-lto-unit-splitting.rs', 
>> 'tests/codegen/enum-bounds-check-derived-idx.rs', + 
>> 'tests/codegen/enum/enum-u128.rs', + 
>> 'tests/codegen/fn-impl-trait-self.rs', 
>> 'tests/codegen/force-unwind-tables.rs', + 
>> 'tests/codegen/inherit_overflow.rs', + 
>> 'tests/codegen/inherit_overflow.rs', + 
>> 'tests/codegen/inline-function-args-debug-info.rs', 
>> 'tests/codegen/intrinsic-no-unnamed-attr.rs', + 
>> 'tests/codegen/intrinsics/mask.rs', + 
>> 'tests/codegen/intrinsics/transmute-niched.rs', 
>> 'tests/codegen/issues/issue-103840.rs', 
>> 'tests/codegen/issues/issue-47278.rs', + 
>> 'tests/codegen/issues/issue-73258.rs', 
>> 'tests/codegen/issues/issue-73827-bounds-check-index-in-subexpr.rs', 
>> + 'tests/codegen/issues/issue-75546.rs', + 
>> 'tests/codegen/issues/issue-77812.rs', + 
>> 'tests/codegen/issues/issue-98156-const-arg-temp-lifetime.rs', 
>> 'tests/codegen/lifetime_start_end.rs', + 
>> 'tests/codegen/llvm-ident.rs', 
>> 'tests/codegen/local-generics-in-exe-internalized.rs', + 
>> 'tests/codegen/mainsubprogram.rs', 
>> 'tests/codegen/match-unoptimized.rs', + 
>> 'tests/codegen/move-operands.rs', 
>> 'tests/codegen/noalias-rwlockreadguard.rs', 
>> 'tests/codegen/non-terminate/nonempty-infinite-loop.rs', 
>> 'tests/codegen/noreturn-uninhabited.rs', 
>> 'tests/codegen/repr-transparent-aggregates-3.rs', + 
>> 'tests/codegen/repr/transparent-mips64.rs', 
>> 'tests/codegen/sse42-implies-crc32.rs', 
>> 'tests/codegen/thread-local.rs', 'tests/codegen/uninit-consts.rs', + 
>> 'tests/mir-opt/', 'tests/pretty/raw-str-nonexpr.rs', 
>> 'tests/run-make', - 'tests/run-make/cdylib-fewer-symbols/foo.rs', - 
>> 'tests/run-make/doctests-keep-binaries/t.rs', - 
>> 'tests/run-make-fulldeps', - 'tests/run-make/issue-22131/foo.rs', - 
>> 'tests/run-make/issue-36710/Makefile', - 
>> 'tests/run-make/issue-47551', - 'tests/run-make/pgo-branch-weights', 
>> - 'tests/run-make/pgo-gen', - 'tests/run-make/pgo-gen-lto', - 
>> 'tests/run-make/pgo-indirect-call-promotion', - 
>> 'tests/run-make/pgo-use', - 
>> 'tests/run-make/pointer-auth-link-with-c/Makefile', - 
>> 'tests/run-make/profile', - 'tests/run-make/static-pie', - 
>> 'tests/run-make/sysroot-crates-are-unstable', - 
>> 'tests/run-make/target-specs', 'tests/rustdoc', - 
>> 'tests/rustdoc/async-move-doctest.rs', - 
>> 'tests/rustdoc/async-trait.rs', - 'tests/rustdoc/auto-traits.rs', - 
>> 'tests/rustdoc/check-source-code-urls-to-def.rs', - 
>> 'tests/rustdoc/comment-in-doctest.rs', - 
>> 'tests/rustdoc/const-generics/const-generics-docs.rs', - 
>> 'tests/rustdoc/cross-crate-hidden-assoc-trait-items.rs', - 
>> 'tests/rustdoc/cross-crate-hidden-impl-parameter.rs', - 
>> 'tests/rustdoc/cross-crate-links.rs', - 
>> 'tests/rustdoc/cross-crate-primitive-doc.rs', - 
>> 'tests/rustdoc/doctest-manual-crate-name.rs', - 
>> 'tests/rustdoc/edition-doctest.rs', - 
>> 'tests/rustdoc/edition-flag.rs', - 
>> 'tests/rustdoc/elided-lifetime.rs', - 
>> 'tests/rustdoc/external-macro-src.rs', - 
>> 'tests/rustdoc/extern-html-root-url.rs', - 
>> 'tests/rustdoc/extern-impl-trait.rs', - 
>> 'tests/rustdoc/hide-unstable-trait.rs', - 
>> 'tests/rustdoc/inline_cross/add-docs.rs', - 
>> 'tests/rustdoc/inline_cross/default-trait-method.rs', - 
>> 'tests/rustdoc/inline_cross/dyn_trait.rs', - 
>> 'tests/rustdoc/inline_cross/impl_trait.rs', - 
>> 'tests/rustdoc/inline_cross/issue-24183.rs', - 
>> 'tests/rustdoc/inline_cross/macros.rs', - 
>> 'tests/rustdoc/inline_cross/trait-vis.rs', - 
>> 'tests/rustdoc/inline_cross/use_crate.rs', - 
>> 'tests/rustdoc/intra-doc-crate/self.rs', - 
>> 'tests/rustdoc/intra-doc/cross-crate/additional_doc.rs', - 
>> 'tests/rustdoc/intra-doc/cross-crate/basic.rs', - 
>> 'tests/rustdoc/intra-doc/cross-crate/crate.rs', - 
>> 'tests/rustdoc/intra-doc/cross-crate/hidden.rs', - 
>> 'tests/rustdoc/intra-doc/cross-crate/macro.rs', - 
>> 'tests/rustdoc/intra-doc/cross-crate/module.rs', - 
>> 'tests/rustdoc/intra-doc/cross-crate/submodule-inner.rs', - 
>> 'tests/rustdoc/intra-doc/cross-crate/submodule-outer.rs', - 
>> 'tests/rustdoc/intra-doc/cross-crate/traits.rs', - 
>> 'tests/rustdoc/intra-doc/extern-builtin-type-impl.rs', - 
>> 'tests/rustdoc/intra-doc/extern-crate-only-used-in-link.rs', - 
>> 'tests/rustdoc/intra-doc/extern-crate.rs', - 
>> 'tests/rustdoc/intra-doc/extern-inherent-impl.rs', - 
>> 'tests/rustdoc/intra-doc/extern-reference-link.rs', - 
>> 'tests/rustdoc/intra-doc/issue-103463.rs', - 
>> 'tests/rustdoc/intra-doc/issue-104145.rs', - 
>> 'tests/rustdoc/intra-doc/issue-66159.rs', - 
>> 'tests/rustdoc/intra-doc/pub-use.rs', - 
>> 'tests/rustdoc/intra-doc/reexport-additional-docs.rs', - 
>> 'tests/rustdoc/issue-18199.rs', - 'tests/rustdoc/issue-23106.rs', - 
>> 'tests/rustdoc/issue-23744.rs', - 'tests/rustdoc/issue-25944.rs', - 
>> 'tests/rustdoc/issue-30252.rs', - 'tests/rustdoc/issue-38129.rs', - 
>> 'tests/rustdoc/issue-40936.rs', - 'tests/rustdoc/issue-43153.rs', - 
>> 'tests/rustdoc/issue-46727.rs', - 'tests/rustdoc/issue-48377.rs', - 
>> 'tests/rustdoc/issue-48414.rs', - 'tests/rustdoc/issue-53689.rs', - 
>> 'tests/rustdoc/issue-54478-demo-allocator.rs', - 
>> 'tests/rustdoc/issue-57180.rs', - 'tests/rustdoc/issue-61592.rs', - 
>> 'tests/rustdoc/issue-73061-cross-crate-opaque-assoc-type.rs', - 
>> 'tests/rustdoc/issue-75588.rs', - 'tests/rustdoc/issue-85454.rs', - 
>> 'tests/rustdoc/issue-86620.rs', - 'tests/rustdoc-json', 
>> 'tests/rustdoc-js-std', - 'tests/rustdoc/macro_pub_in_module.rs', - 
>> 'tests/rustdoc/masked.rs', - 'tests/rustdoc/normalize-assoc-item.rs', 
>> - 'tests/rustdoc/no-stack-overflow-25295.rs', - 
>> 'tests/rustdoc/primitive-reexport.rs', - 
>> 'tests/rustdoc/process-termination.rs', - 
>> 'tests/rustdoc/pub-extern-crate.rs', - 
>> 'tests/rustdoc/pub-use-extern-macros.rs', - 
>> 'tests/rustdoc/reexport-check.rs', - 
>> 'tests/rustdoc/reexport-dep-foreign-fn.rs', - 
>> 'tests/rustdoc/reexport-doc.rs', - 'tests/rustdoc/reexports-priv.rs', 
>> - 'tests/rustdoc/reexports.rs', - 
>> 'tests/rustdoc/rustc,-incoherent-impls.rs', - 
>> 'tests/rustdoc/test_option_check/bar.rs', - 
>> 'tests/rustdoc/test_option_check/test.rs', - 
>> 'tests/rustdoc/trait-alias-mention.rs', - 
>> 'tests/rustdoc/trait-visibility.rs', + 'tests/rustdoc-json', 
>> 'tests/rustdoc-ui/cfg-test.rs', 'tests/rustdoc-ui/check-cfg-test.rs', 
>> 'tests/rustdoc-ui/display-output.rs', 
>> 'tests/rustdoc-ui/doc-comment-multi-line-attr.rs', 
>> 'tests/rustdoc-ui/doc-comment-multi-line-cfg-attr.rs', 
>> 'tests/rustdoc-ui/doc-test-doctest-feature.rs', + 
>> 'tests/rustdoc-ui/doc-test-rustdoc-feature.rs', 
>> 'tests/rustdoc-ui/doctest-multiline-crate-attribute.rs', 
>> 'tests/rustdoc-ui/doctest-output.rs', - 
>> 'tests/rustdoc-ui/doc-test-rustdoc-feature.rs', 
>> 'tests/rustdoc-ui/failed-doctest-compile-fail.rs', 
>> 'tests/rustdoc-ui/issue-80992.rs', 'tests/rustdoc-ui/issue-91134.rs', 
>> + 'tests/rustdoc-ui/no-run-flag.rs', 
>> 'tests/rustdoc-ui/nocapture-fail.rs', 
>> 'tests/rustdoc-ui/nocapture.rs', - 'tests/rustdoc-ui/no-run-flag.rs', 
>> 'tests/rustdoc-ui/run-directory.rs', 
>> 'tests/rustdoc-ui/test-no_std.rs', 'tests/rustdoc-ui/test-type.rs', - 
>> 'tests/rustdoc/unit-return.rs', + 'tests/ui-fulldeps/', 
>> 'tests/ui/abi/stack-probes-lto.rs', 'tests/ui/abi/stack-probes.rs', 
>> 'tests/ui/array-slice-vec/subslice-patterns-const-eval-match.rs', @@ 
>> -233,31 +167,10 @@ class 
>> RustSelfTestSystemEmulated(OESelftestTestCase, 
>> OEPTestResultTestCase): 
>> 'tests/ui/debuginfo/debuginfo-emit-llvm-ir-and-split-debuginfo.rs', 
>> 'tests/ui/drop/dynamic-drop.rs', 'tests/ui/empty_global_asm.rs', - 
>> 'tests/ui-fulldeps/deriving-encodable-decodable-box.rs', - 
>> 'tests/ui-fulldeps/deriving-encodable-decodable-cell-refcell.rs', - 
>> 'tests/ui-fulldeps/deriving-global.rs', - 
>> 'tests/ui-fulldeps/deriving-hygiene.rs', - 
>> 'tests/ui-fulldeps/dropck_tarena_sound_drop.rs', - 
>> 'tests/ui-fulldeps/empty-struct-braces-derive.rs', - 
>> 'tests/ui-fulldeps/internal-lints/bad_opt_access.rs', - 
>> 'tests/ui-fulldeps/internal-lints/bad_opt_access.stderr', - 
>> 'tests/ui-fulldeps/internal-lints/default_hash_types.rs', - 
>> 'tests/ui-fulldeps/internal-lints/diagnostics.rs', - 
>> 'tests/ui-fulldeps/internal-lints/lint_pass_impl_without_macro.rs', - 
>> 'tests/ui-fulldeps/internal-lints/qualified_ty_ty_ctxt.rs', - 
>> 'tests/ui-fulldeps/internal-lints/query_stability.rs', - 
>> 'tests/ui-fulldeps/internal-lints/rustc_pass_by_value.rs', - 
>> 'tests/ui-fulldeps/internal-lints/ty_tykind_usage.rs', - 
>> 'tests/ui-fulldeps/issue-14021.rs', - 
>> 'tests/ui-fulldeps/lint-group-denied-lint-allowed.rs', - 
>> 'tests/ui-fulldeps/lint-group-forbid-always-trumps-cli.rs', - 
>> 'tests/ui-fulldeps/lint-pass-macros.rs', - 
>> 'tests/ui-fulldeps/regions-mock-tcx.rs', - 
>> 'tests/ui-fulldeps/rustc_encodable_hygiene.rs', - 
>> 'tests/ui-fulldeps/session-diagnostic/enforce_slug_naming.rs', 
>> 'tests/ui/functions-closures/fn-help-with-err.rs', 
>> 'tests/ui/linkage-attr/issue-10755.rs', 
>> 'tests/ui/macros/restricted-shadowing-legacy.rs', + 
>> 'tests/ui/numbers-arithmetic/u128.rs', 
>> 'tests/ui/process/nofile-limit.rs', 
>> 'tests/ui/process/process-panic-after-fork.rs', 
>> 'tests/ui/process/process-sigpipe.rs', diff --git 
>> a/meta/recipes-devtools/rust/rust-source.inc 
>> b/meta/recipes-devtools/rust/rust-source.inc index 
>> 83a0dbc15f..e02829e6b3 100644 --- 
>> a/meta/recipes-devtools/rust/rust-source.inc +++ 
>> b/meta/recipes-devtools/rust/rust-source.inc @@ -10,6 +10,10 @@ 
>> SRC_URI += "https://static.rust-lang.org/dist/rustc-${RUST_VERSION}-src.tar.xz;n
>>               file://0004-musl-Define-O_LARGEFILE-for-riscv32.patch;patchdir=${RUSTSRC} \
>>               file://0005-musl-Define-SOCK_SEQPACKET-in-common-place.patch;patchdir=${RUSTSRC} \
>>               file://0001-Revert-Map-source-absolute-paths-to-OUT_DIR-as-relat.patch;patchdir=${RUSTSRC} \
>> +file://cargo-path.patch;patchdir=${RUSTSRC} \
>> +file://custom-target-cfg.patch;patchdir=${RUSTSRC} \
>> +file://rustc-bootstrap.patch;patchdir=${RUSTSRC} \
>> +file://target-build-value.patch;patchdir=${RUSTSRC} \
>>   "
>>   SRC_URI[rust.sha256sum] = "b98c09d968529212fb29eec7d6d3e9bdaa869810679b7fb86a1ca69469d75f5e"
>>   
>
>
> -- 
> # Randy MacLeod
> # Wind River Linux

[-- Attachment #2: Type: text/html, Size: 32402 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v2 5/5] rust: Enable rust oe-selftest.
  2024-01-22 10:59     ` Yash Shinde
@ 2024-01-22 11:01       ` Shinde, Yash
  0 siblings, 0 replies; 13+ messages in thread
From: Shinde, Yash @ 2024-01-22 11:01 UTC (permalink / raw)
  To: Randy MacLeod, openembedded-core, Richard Purdie
  Cc: Umesh.Kallapa, Naveen.Gowda, Sundeep.Kokkonda,
	Shivaprasad.Moodalappa

[-- Attachment #1: Type: text/plain, Size: 31061 bytes --]

On 20-01-2024 22:31, Randy MacLeod wrote:

> 
> I like that you have broken the original patch down into 5 patches that
> are easier to
> understand.
> 
> On 2024-01-19 10:09 a.m., Yash.Shinde@windriver.com wrote:
> 
>> From: Yash Shinde <Yash.Shinde@windriver.com> ( Yash.Shinde@windriver.com )
>> 
>> 
>> Tests which are failing from below modules are added to exclude list
>> 
>> tests/run-make
>> 	tests/rustdoc
>> 	tests/mir-opt
>> 	tests/ui-fulldeps
>> 
>> *
>> Redundent test cases whose parent dir is also present in  exclud list are
>> removed.
>> 
>> * Newly addded tests are sorted and updated.
>> 
>> * Overall exclude
>> tests count in exclude list is now reduced to 114.
> 
> We need to resolve the mips32 problems that Richard pointed out.
> 
> 
> Should we skip all the rust tests for mips32?
> 
> 

In previous oe-selftest implementation, we skipped rust tests for mips32.
I think we should continue with it as rust tests are unstable with mips32.

> 
> 
> 
> 
> 
> Please submit a v3 with the mips fix/avoidance and split this exclude list
> commit down into 3 steps:
> 
> 1. Sort the existing list of tests
> 2. Remove the test cases whose parent dir is also present in the exclude
> list
> 
> 3. Add the new tests that are to be excluded.
> 
> 
> 
> This may seem really pedantic but otherwise the changes are really hard to
> review.
> 
> 
> 
> The way I think about this is that someone looking at the commit log might
> be interested
> in exactly which tests are in being added to the exclude list so that
> should be clear from 3.
> 1. won't really be of interest so most people will skip over that
> 2. also won't be of interest to most people
> but you need 1 and 2 to make 3 be apparent to people who want that info
> quickly.
> 
> 

For 1 the existing list of tests are already sorted.
I will send a v3 with separate commits for:

1. newly added test cases
2. removing test cases whose parent dir is also present in the exclude list
3. sorting the overall final list

Regards,
Yash

> 
> 
> 
> Thanks,
> 
> 
> 
> ../Randy
> 
> 
>> * The testing is done on arm32, arm64, mips64, x86 and  x86_64 targets.
>> 
>> Signed-off-by: Yash Shinde <Yash.Shinde@windriver.com> (
>> Yash.Shinde@windriver.com )
>> ---
>>  meta/lib/oeqa/selftest/cases/rust.py     
>> | 165 +++++----------------
>>  meta/recipes-devtools/rust/rust-source.inc | 
>> 4 +
>>  2 files changed, 43 insertions(+), 126 deletions(-)
>> 
>> diff --git
>> a/meta/lib/oeqa/selftest/cases/rust.py
>> b/meta/lib/oeqa/selftest/cases/rust.py
>> index 6dbc517006..7d0efb1b01 100644
>> --- a/meta/lib/oeqa/selftest/cases/rust.py
>> +++
>> b/meta/lib/oeqa/selftest/cases/rust.py
>> @@ -40,7 +40,7 @@ def
>> parse_results(filename):
>>  class
>> RustSelfTestSystemEmulated(OESelftestTestCase, OEPTestResultTestCase):
>>    
>> def test_rust(self, *args, **kwargs):
>>          # Disable Rust Oe-selftest
>> -        self.skipTest("The Rust Oe-selftest is disabled.")
>> +       
>> #self.skipTest("The Rust Oe-selftest is disabled.")
>>  
>>          # build
>> remote-test-server before image build
>>          recipe = "rust "
>> @@ -73,156 +73,90 @@ class
>> RustSelfTestSystemEmulated(OESelftestTestCase, OEPTestResultTestCase):
>>    
>> 'src/librustdoc',
>>                              'src/rustdoc-json-types',
>>  
>> 'src/tools/compiletest/src/common.rs',
>> +                           
>> 'src/tools/jsondoclint',
>>                             
>> 'src/tools/lint-docs',
>> +                           
>> 'src/tools/replace-version-placeholder',
>>                             
>> 'src/tools/rust-analyzer',
>>                             
>> 'src/tools/rustdoc-themes',
>>                              'src/tools/tidy',
>> 'tests/assembly/asm/aarch64-outline-atomics.rs',
>> +                        
>> 'tests/codegen/abi-efiapi.rs',
>> +                           
>> 'tests/codegen/abi-efiapi.rs',
>>                             
>> 'tests/codegen/abi-main-signature-32bit-c-int.rs',
>>                        
>> 'tests/codegen/abi-repr-ext.rs',
>> +                           
>> 'tests/codegen/abi-sysv64.rs',
>>                             
>> 'tests/codegen/abi-x86-interrupt.rs',
>> +                           
>> 'tests/codegen/align-byval.rs',
>> +                           
>> 'tests/codegen/align-fn.rs',
>> +                           
>> 'tests/codegen/asm-powerpc-clobbers.rs',
>> +                           
>> 'tests/codegen/async-fn-debug-awaitee-field.rs',
>> +                        
>> 'tests/codegen/binary-search-index-no-bound-check.rs',
>>                    
>> 'tests/codegen/branch-protection.rs',
>> +                           
>> 'tests/codegen/call-metadata.rs',
>>                             
>> 'tests/codegen/catch-unwind.rs',
>>                             
>> 'tests/codegen/cf-protection.rs',
>> +                           
>> 'tests/codegen/debug-column.rs',
>> +                           
>> 'tests/codegen/debug-limited.rs',
>> +                           
>> 'tests/codegen/debuginfo-generic-closure-env-names.rs',
>> +                 
>> 'tests/codegen/drop.rs',
>> +                           
>> 'tests/codegen/dst-vtable-align-nonzero.rs',
>> +                           
>> 'tests/codegen/enable-lto-unit-splitting.rs',
>>                             
>> 'tests/codegen/enum-bounds-check-derived-idx.rs',
>> +                       
>> 'tests/codegen/enum/enum-u128.rs',
>> +                           
>> 'tests/codegen/fn-impl-trait-self.rs',
>>                             
>> 'tests/codegen/force-unwind-tables.rs',
>> +                           
>> 'tests/codegen/inherit_overflow.rs',
>> +                           
>> 'tests/codegen/inherit_overflow.rs',
>> +                           
>> 'tests/codegen/inline-function-args-debug-info.rs',
>>                       
>> 'tests/codegen/intrinsic-no-unnamed-attr.rs',
>> +                           
>> 'tests/codegen/intrinsics/mask.rs',
>> +                           
>> 'tests/codegen/intrinsics/transmute-niched.rs',
>>                           
>> 'tests/codegen/issues/issue-103840.rs',
>>                             
>> 'tests/codegen/issues/issue-47278.rs',
>> +                           
>> 'tests/codegen/issues/issue-73258.rs',
>>                             
>> 'tests/codegen/issues/issue-73827-bounds-check-index-in-subexpr.rs',
>> +    
>> 'tests/codegen/issues/issue-75546.rs',
>> +                           
>> 'tests/codegen/issues/issue-77812.rs',
>> +                           
>> 'tests/codegen/issues/issue-98156-const-arg-temp-lifetime.rs',
>>            
>> 'tests/codegen/lifetime_start_end.rs',
>> +                           
>> 'tests/codegen/llvm-ident.rs',
>>                             
>> 'tests/codegen/local-generics-in-exe-internalized.rs',
>> +                  
>> 'tests/codegen/mainsubprogram.rs',
>>                             
>> 'tests/codegen/match-unoptimized.rs',
>> +                           
>> 'tests/codegen/move-operands.rs',
>>                             
>> 'tests/codegen/noalias-rwlockreadguard.rs',
>>                             
>> 'tests/codegen/non-terminate/nonempty-infinite-loop.rs',
>>                  
>> 'tests/codegen/noreturn-uninhabited.rs',
>>                             
>> 'tests/codegen/repr-transparent-aggregates-3.rs',
>> +                       
>> 'tests/codegen/repr/transparent-mips64.rs',
>>                             
>> 'tests/codegen/sse42-implies-crc32.rs',
>>                             
>> 'tests/codegen/thread-local.rs',
>>                             
>> 'tests/codegen/uninit-consts.rs',
>> +                           
>> 'tests/mir-opt/',
>>                             
>> 'tests/pretty/raw-str-nonexpr.rs',
>>                             
>> 'tests/run-make',
>> -                           
>> 'tests/run-make/cdylib-fewer-symbols/foo.rs',
>> -                           
>> 'tests/run-make/doctests-keep-binaries/t.rs',
>> -                           
>> 'tests/run-make-fulldeps',
>> -                           
>> 'tests/run-make/issue-22131/foo.rs',
>> -                           
>> 'tests/run-make/issue-36710/Makefile',
>> -                           
>> 'tests/run-make/issue-47551',
>> -                           
>> 'tests/run-make/pgo-branch-weights',
>> -                           
>> 'tests/run-make/pgo-gen',
>> -                           
>> 'tests/run-make/pgo-gen-lto',
>> -                           
>> 'tests/run-make/pgo-indirect-call-promotion',
>> -                           
>> 'tests/run-make/pgo-use',
>> -                           
>> 'tests/run-make/pointer-auth-link-with-c/Makefile',
>> -                     
>> 'tests/run-make/profile',
>> -                           
>> 'tests/run-make/static-pie',
>> -                           
>> 'tests/run-make/sysroot-crates-are-unstable',
>> -                           
>> 'tests/run-make/target-specs',
>>                             
>> 'tests/rustdoc',
>> -                           
>> 'tests/rustdoc/async-move-doctest.rs',
>> -                           
>> 'tests/rustdoc/async-trait.rs',
>> -                           
>> 'tests/rustdoc/auto-traits.rs',
>> -                           
>> 'tests/rustdoc/check-source-code-urls-to-def.rs',
>> -                       
>> 'tests/rustdoc/comment-in-doctest.rs',
>> -                           
>> 'tests/rustdoc/const-generics/const-generics-docs.rs',
>> -                  
>> 'tests/rustdoc/cross-crate-hidden-assoc-trait-items.rs',
>> -                
>> 'tests/rustdoc/cross-crate-hidden-impl-parameter.rs',
>> -                   
>> 'tests/rustdoc/cross-crate-links.rs',
>> -                           
>> 'tests/rustdoc/cross-crate-primitive-doc.rs',
>> -                           
>> 'tests/rustdoc/doctest-manual-crate-name.rs',
>> -                           
>> 'tests/rustdoc/edition-doctest.rs',
>> -                           
>> 'tests/rustdoc/edition-flag.rs',
>> -                           
>> 'tests/rustdoc/elided-lifetime.rs',
>> -                           
>> 'tests/rustdoc/external-macro-src.rs',
>> -                           
>> 'tests/rustdoc/extern-html-root-url.rs',
>> -                           
>> 'tests/rustdoc/extern-impl-trait.rs',
>> -                           
>> 'tests/rustdoc/hide-unstable-trait.rs',
>> -                           
>> 'tests/rustdoc/inline_cross/add-docs.rs',
>> -                           
>> 'tests/rustdoc/inline_cross/default-trait-method.rs',
>> -                   
>> 'tests/rustdoc/inline_cross/dyn_trait.rs',
>> -                           
>> 'tests/rustdoc/inline_cross/impl_trait.rs',
>> -                           
>> 'tests/rustdoc/inline_cross/issue-24183.rs',
>> -                           
>> 'tests/rustdoc/inline_cross/macros.rs',
>> -                           
>> 'tests/rustdoc/inline_cross/trait-vis.rs',
>> -                           
>> 'tests/rustdoc/inline_cross/use_crate.rs',
>> -                           
>> 'tests/rustdoc/intra-doc-crate/self.rs',
>> -                           
>> 'tests/rustdoc/intra-doc/cross-crate/additional_doc.rs',
>> -                
>> 'tests/rustdoc/intra-doc/cross-crate/basic.rs',
>> -                         
>> 'tests/rustdoc/intra-doc/cross-crate/crate.rs',
>> -                         
>> 'tests/rustdoc/intra-doc/cross-crate/hidden.rs',
>> -                        
>> 'tests/rustdoc/intra-doc/cross-crate/macro.rs',
>> -                         
>> 'tests/rustdoc/intra-doc/cross-crate/module.rs',
>> -                        
>> 'tests/rustdoc/intra-doc/cross-crate/submodule-inner.rs',
>> -               
>> 'tests/rustdoc/intra-doc/cross-crate/submodule-outer.rs',
>> -               
>> 'tests/rustdoc/intra-doc/cross-crate/traits.rs',
>> -                        
>> 'tests/rustdoc/intra-doc/extern-builtin-type-impl.rs',
>> -                  
>> 'tests/rustdoc/intra-doc/extern-crate-only-used-in-link.rs',
>> -            
>> 'tests/rustdoc/intra-doc/extern-crate.rs',
>> -                           
>> 'tests/rustdoc/intra-doc/extern-inherent-impl.rs',
>> -                      
>> 'tests/rustdoc/intra-doc/extern-reference-link.rs',
>> -                     
>> 'tests/rustdoc/intra-doc/issue-103463.rs',
>> -                           
>> 'tests/rustdoc/intra-doc/issue-104145.rs',
>> -                           
>> 'tests/rustdoc/intra-doc/issue-66159.rs',
>> -                           
>> 'tests/rustdoc/intra-doc/pub-use.rs',
>> -                           
>> 'tests/rustdoc/intra-doc/reexport-additional-docs.rs',
>> -                  
>> 'tests/rustdoc/issue-18199.rs',
>> -                           
>> 'tests/rustdoc/issue-23106.rs',
>> -                           
>> 'tests/rustdoc/issue-23744.rs',
>> -                           
>> 'tests/rustdoc/issue-25944.rs',
>> -                           
>> 'tests/rustdoc/issue-30252.rs',
>> -                           
>> 'tests/rustdoc/issue-38129.rs',
>> -                           
>> 'tests/rustdoc/issue-40936.rs',
>> -                           
>> 'tests/rustdoc/issue-43153.rs',
>> -                           
>> 'tests/rustdoc/issue-46727.rs',
>> -                           
>> 'tests/rustdoc/issue-48377.rs',
>> -                           
>> 'tests/rustdoc/issue-48414.rs',
>> -                           
>> 'tests/rustdoc/issue-53689.rs',
>> -                           
>> 'tests/rustdoc/issue-54478-demo-allocator.rs',
>> -                          
>> 'tests/rustdoc/issue-57180.rs',
>> -                           
>> 'tests/rustdoc/issue-61592.rs',
>> -                           
>> 'tests/rustdoc/issue-73061-cross-crate-opaque-assoc-type.rs',
>> -           
>> 'tests/rustdoc/issue-75588.rs',
>> -                           
>> 'tests/rustdoc/issue-85454.rs',
>> -                           
>> 'tests/rustdoc/issue-86620.rs',
>> -                           
>> 'tests/rustdoc-json',
>>                              'tests/rustdoc-js-std',
>> -                            'tests/rustdoc/macro_pub_in_module.rs',
>> -    
>> 'tests/rustdoc/masked.rs',
>> -                           
>> 'tests/rustdoc/normalize-assoc-item.rs',
>> -                           
>> 'tests/rustdoc/no-stack-overflow-25295.rs',
>> -                           
>> 'tests/rustdoc/primitive-reexport.rs',
>> -                           
>> 'tests/rustdoc/process-termination.rs',
>> -                           
>> 'tests/rustdoc/pub-extern-crate.rs',
>> -                           
>> 'tests/rustdoc/pub-use-extern-macros.rs',
>> -                           
>> 'tests/rustdoc/reexport-check.rs',
>> -                           
>> 'tests/rustdoc/reexport-dep-foreign-fn.rs',
>> -                           
>> 'tests/rustdoc/reexport-doc.rs',
>> -                           
>> 'tests/rustdoc/reexports-priv.rs',
>> -                           
>> 'tests/rustdoc/reexports.rs',
>> -                           
>> 'tests/rustdoc/rustc,-incoherent-impls.rs',
>> -                           
>> 'tests/rustdoc/test_option_check/bar.rs',
>> -                           
>> 'tests/rustdoc/test_option_check/test.rs',
>> -                           
>> 'tests/rustdoc/trait-alias-mention.rs',
>> -                           
>> 'tests/rustdoc/trait-visibility.rs',
>> +                           
>> 'tests/rustdoc-json',
>>                             
>> 'tests/rustdoc-ui/cfg-test.rs',
>>                             
>> 'tests/rustdoc-ui/check-cfg-test.rs',
>>                             
>> 'tests/rustdoc-ui/display-output.rs',
>>                             
>> 'tests/rustdoc-ui/doc-comment-multi-line-attr.rs',
>>                        
>> 'tests/rustdoc-ui/doc-comment-multi-line-cfg-attr.rs',
>>                    
>> 'tests/rustdoc-ui/doc-test-doctest-feature.rs',
>> +                         
>> 'tests/rustdoc-ui/doc-test-rustdoc-feature.rs',
>>                           
>> 'tests/rustdoc-ui/doctest-multiline-crate-attribute.rs',
>>                  
>> 'tests/rustdoc-ui/doctest-output.rs',
>> -                           
>> 'tests/rustdoc-ui/doc-test-rustdoc-feature.rs',
>>                           
>> 'tests/rustdoc-ui/failed-doctest-compile-fail.rs',
>>                        
>> 'tests/rustdoc-ui/issue-80992.rs',
>>                             
>> 'tests/rustdoc-ui/issue-91134.rs',
>> +                           
>> 'tests/rustdoc-ui/no-run-flag.rs',
>>                             
>> 'tests/rustdoc-ui/nocapture-fail.rs',
>>                             
>> 'tests/rustdoc-ui/nocapture.rs',
>> -                           
>> 'tests/rustdoc-ui/no-run-flag.rs',
>>                             
>> 'tests/rustdoc-ui/run-directory.rs',
>>                             
>> 'tests/rustdoc-ui/test-no_std.rs',
>>                             
>> 'tests/rustdoc-ui/test-type.rs',
>> -                           
>> 'tests/rustdoc/unit-return.rs',
>> +                           
>> 'tests/ui-fulldeps/',
>>                             
>> 'tests/ui/abi/stack-probes-lto.rs',
>>                             
>> 'tests/ui/abi/stack-probes.rs',
>>                             
>> 'tests/ui/array-slice-vec/subslice-patterns-const-eval-match.rs',
>> @@
>> -233,31 +167,10 @@ class RustSelfTestSystemEmulated(OESelftestTestCase,
>> OEPTestResultTestCase):
>>                             
>> 'tests/ui/debuginfo/debuginfo-emit-llvm-ir-and-split-debuginfo.rs',
>>       
>> 'tests/ui/drop/dynamic-drop.rs',
>>                             
>> 'tests/ui/empty_global_asm.rs',
>> -                           
>> 'tests/ui-fulldeps/deriving-encodable-decodable-box.rs',
>> -                
>> 'tests/ui-fulldeps/deriving-encodable-decodable-cell-refcell.rs',
>> -       
>> 'tests/ui-fulldeps/deriving-global.rs',
>> -                           
>> 'tests/ui-fulldeps/deriving-hygiene.rs',
>> -                           
>> 'tests/ui-fulldeps/dropck_tarena_sound_drop.rs',
>> -                        
>> 'tests/ui-fulldeps/empty-struct-braces-derive.rs',
>> -                      
>> 'tests/ui-fulldeps/internal-lints/bad_opt_access.rs',
>> -                   
>> 'tests/ui-fulldeps/internal-lints/bad_opt_access.stderr',
>> -               
>> 'tests/ui-fulldeps/internal-lints/default_hash_types.rs',
>> -               
>> 'tests/ui-fulldeps/internal-lints/diagnostics.rs',
>> -                      
>> 'tests/ui-fulldeps/internal-lints/lint_pass_impl_without_macro.rs',
>> -     
>> 'tests/ui-fulldeps/internal-lints/qualified_ty_ty_ctxt.rs',
>> -             
>> 'tests/ui-fulldeps/internal-lints/query_stability.rs',
>> -                  
>> 'tests/ui-fulldeps/internal-lints/rustc_pass_by_value.rs',
>> -              
>> 'tests/ui-fulldeps/internal-lints/ty_tykind_usage.rs',
>> -                  
>> 'tests/ui-fulldeps/issue-14021.rs',
>> -                           
>> 'tests/ui-fulldeps/lint-group-denied-lint-allowed.rs',
>> -                  
>> 'tests/ui-fulldeps/lint-group-forbid-always-trumps-cli.rs',
>> -             
>> 'tests/ui-fulldeps/lint-pass-macros.rs',
>> -                           
>> 'tests/ui-fulldeps/regions-mock-tcx.rs',
>> -                           
>> 'tests/ui-fulldeps/rustc_encodable_hygiene.rs',
>> -                         
>> 'tests/ui-fulldeps/session-diagnostic/enforce_slug_naming.rs',
>>            
>> 'tests/ui/functions-closures/fn-help-with-err.rs',
>>                        
>> 'tests/ui/linkage-attr/issue-10755.rs',
>>                             
>> 'tests/ui/macros/restricted-shadowing-legacy.rs',
>> +                       
>> 'tests/ui/numbers-arithmetic/u128.rs',
>>                             
>> 'tests/ui/process/nofile-limit.rs',
>>                             
>> 'tests/ui/process/process-panic-after-fork.rs',
>>                           
>> 'tests/ui/process/process-sigpipe.rs',
>> diff --git
>> a/meta/recipes-devtools/rust/rust-source.inc
>> b/meta/recipes-devtools/rust/rust-source.inc
>> index 83a0dbc15f..e02829e6b3
>> 100644
>> --- a/meta/recipes-devtools/rust/rust-source.inc
>> +++
>> b/meta/recipes-devtools/rust/rust-source.inc
>> @@ -10,6 +10,10 @@ SRC_URI +=
>> " (
>> @@-73,156+73,90@@classRustSelfTestSystemEmulated(OESelftestTestCase,OEPTestResultTestCase):'src/librustdoc','src/rustdoc-json-types','src/tools/compiletest/src/common.rs',+'src/tools/jsondoclint','src/tools/lint-docs',+'src/tools/replace-version-placeholder','src/tools/rust-analyzer','src/tools/rustdoc-themes','src/tools/tidy','tests/assembly/asm/aarch64-outline-atomics.rs',+'tests/codegen/abi-efiapi.rs',+'tests/codegen/abi-efiapi.rs','tests/codegen/abi-main-signature-32bit-c-int.rs','tests/codegen/abi-repr-ext.rs',+'tests/codegen/abi-sysv64.rs','tests/codegen/abi-x86-interrupt.rs',+'tests/codegen/align-byval.rs',+'tests/codegen/align-fn.rs',+'tests/codegen/asm-powerpc-clobbers.rs',+'tests/codegen/async-fn-debug-awaitee-field.rs',+'tests/codegen/binary-search-index-no-bound-check.rs','tests/codegen/branch-protection.rs',+'tests/codegen/call-metadata.rs','tests/codegen/catch-unwind.rs','tests/codegen/cf-protection.rs',+'tests/codegen/debug-column.rs',+'tests/codegen/debug-limited.rs',+'tests/codegen/debuginfo-generic-closure-env-names.rs',+'tests/codegen/drop.rs',+'tests/codegen/dst-vtable-align-nonzero.rs',+'tests/codegen/enable-lto-unit-splitting.rs','tests/codegen/enum-bounds-check-derived-idx.rs',+'tests/codegen/enum/enum-u128.rs',+'tests/codegen/fn-impl-trait-self.rs','tests/codegen/force-unwind-tables.rs',+'tests/codegen/inherit_overflow.rs',+'tests/codegen/inherit_overflow.rs',+'tests/codegen/inline-function-args-debug-info.rs','tests/codegen/intrinsic-no-unnamed-attr.rs',+'tests/codegen/intrinsics/mask.rs',+'tests/codegen/intrinsics/transmute-niched.rs','tests/codegen/issues/issue-103840.rs','tests/codegen/issues/issue-47278.rs',+'tests/codegen/issues/issue-73258.rs','tests/codegen/issues/issue-73827-bounds-check-index-in-subexpr.rs',+'tests/codegen/issues/issue-75546.rs',+'tests/codegen/issues/issue-77812.rs',+'tests/codegen/issues/issue-98156-const-arg-temp-lifetime.rs','tests/codegen/lifetime_start_end.rs',+'tests/codegen/llvm-ident.rs','tests/codegen/local-generics-in-exe-internalized.rs',+'tests/codegen/mainsubprogram.rs','tests/codegen/match-unoptimized.rs',+'tests/codegen/move-operands.rs','tests/codegen/noalias-rwlockreadguard.rs','tests/codegen/non-terminate/nonempty-infinite-loop.rs','tests/codegen/noreturn-uninhabited.rs','tests/codegen/repr-transparent-aggregates-3.rs',+'tests/codegen/repr/transparent-mips64.rs','tests/codegen/sse42-implies-crc32.rs','tests/codegen/thread-local.rs','tests/codegen/uninit-consts.rs',+'tests/mir-opt/','tests/pretty/raw-str-nonexpr.rs','tests/run-make',-'tests/run-make/cdylib-fewer-symbols/foo.rs',-'tests/run-make/doctests-keep-binaries/t.rs',-'tests/run-make-fulldeps',-'tests/run-make/issue-22131/foo.rs',-'tests/run-make/issue-36710/Makefile',-'tests/run-make/issue-47551',-'tests/run-make/pgo-branch-weights',-'tests/run-make/pgo-gen',-'tests/run-make/pgo-gen-lto',-'tests/run-make/pgo-indirect-call-promotion',-'tests/run-make/pgo-use',-'tests/run-make/pointer-auth-link-with-c/Makefile',-'tests/run-make/profile',-'tests/run-make/static-pie',-'tests/run-make/sysroot-crates-are-unstable',-'tests/run-make/target-specs','tests/rustdoc',-'tests/rustdoc/async-move-doctest.rs',-'tests/rustdoc/async-trait.rs',-'tests/rustdoc/auto-traits.rs',-'tests/rustdoc/check-source-code-urls-to-def.rs',-'tests/rustdoc/comment-in-doctest.rs',-'tests/rustdoc/const-generics/const-generics-docs.rs',-'tests/rustdoc/cross-crate-hidden-assoc-trait-items.rs',-'tests/rustdoc/cross-crate-hidden-impl-parameter.rs',-'tests/rustdoc/cross-crate-links.rs',-'tests/rustdoc/cross-crate-primitive-doc.rs',-'tests/rustdoc/doctest-manual-crate-name.rs',-'tests/rustdoc/edition-doctest.rs',-'tests/rustdoc/edition-flag.rs',-'tests/rustdoc/elided-lifetime.rs',-'tests/rustdoc/external-macro-src.rs',-'tests/rustdoc/extern-html-root-url.rs',-'tests/rustdoc/extern-impl-trait.rs',-'tests/rustdoc/hide-unstable-trait.rs',-'tests/rustdoc/inline_cross/add-docs.rs',-'tests/rustdoc/inline_cross/default-trait-method.rs',-'tests/rustdoc/inline_cross/dyn_trait.rs',-'tests/rustdoc/inline_cross/impl_trait.rs',-'tests/rustdoc/inline_cross/issue-24183.rs',-'tests/rustdoc/inline_cross/macros.rs',-'tests/rustdoc/inline_cross/trait-vis.rs',-'tests/rustdoc/inline_cross/use_crate.rs',-'tests/rustdoc/intra-doc-crate/self.rs',-'tests/rustdoc/intra-doc/cross-crate/additional_doc.rs',-'tests/rustdoc/intra-doc/cross-crate/basic.rs',-'tests/rustdoc/intra-doc/cross-crate/crate.rs',-'tests/rustdoc/intra-doc/cross-crate/hidden.rs',-'tests/rustdoc/intra-doc/cross-crate/macro.rs',-'tests/rustdoc/intra-doc/cross-crate/module.rs',-'tests/rustdoc/intra-doc/cross-crate/submodule-inner.rs',-'tests/rustdoc/intra-doc/cross-crate/submodule-outer.rs',-'tests/rustdoc/intra-doc/cross-crate/traits.rs',-'tests/rustdoc/intra-doc/extern-builtin-type-impl.rs',-'tests/rustdoc/intra-doc/extern-crate-only-used-in-link.rs',-'tests/rustdoc/intra-doc/extern-crate.rs',-'tests/rustdoc/intra-doc/extern-inherent-impl.rs',-'tests/rustdoc/intra-doc/extern-reference-link.rs',-'tests/rustdoc/intra-doc/issue-103463.rs',-'tests/rustdoc/intra-doc/issue-104145.rs',-'tests/rustdoc/intra-doc/issue-66159.rs',-'tests/rustdoc/intra-doc/pub-use.rs',-'tests/rustdoc/intra-doc/reexport-additional-docs.rs',-'tests/rustdoc/issue-18199.rs',-'tests/rustdoc/issue-23106.rs',-'tests/rustdoc/issue-23744.rs',-'tests/rustdoc/issue-25944.rs',-'tests/rustdoc/issue-30252.rs',-'tests/rustdoc/issue-38129.rs',-'tests/rustdoc/issue-40936.rs',-'tests/rustdoc/issue-43153.rs',-'tests/rustdoc/issue-46727.rs',-'tests/rustdoc/issue-48377.rs',-'tests/rustdoc/issue-48414.rs',-'tests/rustdoc/issue-53689.rs',-'tests/rustdoc/issue-54478-demo-allocator.rs',-'tests/rustdoc/issue-57180.rs',-'tests/rustdoc/issue-61592.rs',-'tests/rustdoc/issue-73061-cross-crate-opaque-assoc-type.rs',-'tests/rustdoc/issue-75588.rs',-'tests/rustdoc/issue-85454.rs',-'tests/rustdoc/issue-86620.rs',-'tests/rustdoc-json','tests/rustdoc-js-std',-'tests/rustdoc/macro_pub_in_module.rs',-'tests/rustdoc/masked.rs',-'tests/rustdoc/normalize-assoc-item.rs',-'tests/rustdoc/no-stack-overflow-25295.rs',-'tests/rustdoc/primitive-reexport.rs',-'tests/rustdoc/process-termination.rs',-'tests/rustdoc/pub-extern-crate.rs',-'tests/rustdoc/pub-use-extern-macros.rs',-'tests/rustdoc/reexport-check.rs',-'tests/rustdoc/reexport-dep-foreign-fn.rs',-'tests/rustdoc/reexport-doc.rs',-'tests/rustdoc/reexports-priv.rs',-'tests/rustdoc/reexports.rs',-'tests/rustdoc/rustc,-incoherent-impls.rs',-'tests/rustdoc/test_option_check/bar.rs',-'tests/rustdoc/test_option_check/test.rs',-'tests/rustdoc/trait-alias-mention.rs',-'tests/rustdoc/trait-visibility.rs',+'tests/rustdoc-json','tests/rustdoc-ui/cfg-test.rs','tests/rustdoc-ui/check-cfg-test.rs','tests/rustdoc-ui/display-output.rs','tests/rustdoc-ui/doc-comment-multi-line-attr.rs','tests/rustdoc-ui/doc-comment-multi-line-cfg-attr.rs','tests/rustdoc-ui/doc-test-doctest-feature.rs',+'tests/rustdoc-ui/doc-test-rustdoc-feature.rs','tests/rustdoc-ui/doctest-multiline-crate-attribute.rs','tests/rustdoc-ui/doctest-output.rs',-'tests/rustdoc-ui/doc-test-rustdoc-feature.rs','tests/rustdoc-ui/failed-doctest-compile-fail.rs','tests/rustdoc-ui/issue-80992.rs','tests/rustdoc-ui/issue-91134.rs',+'tests/rustdoc-ui/no-run-flag.rs','tests/rustdoc-ui/nocapture-fail.rs','tests/rustdoc-ui/nocapture.rs',-'tests/rustdoc-ui/no-run-flag.rs','tests/rustdoc-ui/run-directory.rs','tests/rustdoc-ui/test-no_std.rs','tests/rustdoc-ui/test-type.rs',-'tests/rustdoc/unit-return.rs',+'tests/ui-fulldeps/','tests/ui/abi/stack-probes-lto.rs','tests/ui/abi/stack-probes.rs','tests/ui/array-slice-vec/subslice-patterns-const-eval-match.rs',@@-233,31+167,10@@classRustSelfTestSystemEmulated(OESelftestTestCase,OEPTestResultTestCase):'tests/ui/debuginfo/debuginfo-emit-llvm-ir-and-split-debuginfo.rs','tests/ui/drop/dynamic-drop.rs','tests/ui/empty_global_asm.rs',-'tests/ui-fulldeps/deriving-encodable-decodable-box.rs',-'tests/ui-fulldeps/deriving-encodable-decodable-cell-refcell.rs',-'tests/ui-fulldeps/deriving-global.rs',-'tests/ui-fulldeps/deriving-hygiene.rs',-'tests/ui-fulldeps/dropck_tarena_sound_drop.rs',-'tests/ui-fulldeps/empty-struct-braces-derive.rs',-'tests/ui-fulldeps/internal-lints/bad_opt_access.rs',-'tests/ui-fulldeps/internal-lints/bad_opt_access.stderr',-'tests/ui-fulldeps/internal-lints/default_hash_types.rs',-'tests/ui-fulldeps/internal-lints/diagnostics.rs',-'tests/ui-fulldeps/internal-lints/lint_pass_impl_without_macro.rs',-'tests/ui-fulldeps/internal-lints/qualified_ty_ty_ctxt.rs',-'tests/ui-fulldeps/internal-lints/query_stability.rs',-'tests/ui-fulldeps/internal-lints/rustc_pass_by_value.rs',-'tests/ui-fulldeps/internal-lints/ty_tykind_usage.rs',-'tests/ui-fulldeps/issue-14021.rs',-'tests/ui-fulldeps/lint-group-denied-lint-allowed.rs',-'tests/ui-fulldeps/lint-group-forbid-always-trumps-cli.rs',-'tests/ui-fulldeps/lint-pass-macros.rs',-'tests/ui-fulldeps/regions-mock-tcx.rs',-'tests/ui-fulldeps/rustc_encodable_hygiene.rs',-'tests/ui-fulldeps/session-diagnostic/enforce_slug_naming.rs','tests/ui/functions-closures/fn-help-with-err.rs','tests/ui/linkage-attr/issue-10755.rs','tests/ui/macros/restricted-shadowing-legacy.rs',+'tests/ui/numbers-arithmetic/u128.rs','tests/ui/process/nofile-limit.rs','tests/ui/process/process-panic-after-fork.rs','tests/ui/process/process-sigpipe.rs',diff--gita/meta/recipes-devtools/rust/rust-source.incb/meta/recipes-devtools/rust/rust-source.incindex83a0dbc15f..e02829e6b3100644---a/meta/recipes-devtools/rust/rust-source.inc+++b/meta/recipes-devtools/rust/rust-source.inc@@-10,6+10,10@@SRC_URI+=
>> ) https://static.rust-lang.org/dist/rustc-$ {RUST_VERSION}-src.tar.xz;n
>>    
>> file://0004-musl-Define-O_LARGEFILE-for-riscv32.patch;patchdir=$ {RUSTSRC}
>> \
>>              file://0005-musl-Define-SOCK_SEQPACKET-in-common-place.patch;patchdir=$
>> {RUSTSRC} \
>>              file://0001-Revert-Map-source-absolute-paths-to-OUT_DIR-as-relat.patch;patchdir=$
>> {RUSTSRC} \
>> +            file://cargo-path.patch;patchdir=$ {RUSTSRC} \
>> +            file://custom-target-cfg.patch;patchdir=$ {RUSTSRC} \
>> +       
>> file://rustc-bootstrap.patch;patchdir=$ {RUSTSRC} \
>> +            file://target-build-value.patch;patchdir=$ {RUSTSRC} \
>>  "
>> 
>> SRC_URI[rust.sha256sum] =
>> "b98c09d968529212fb29eec7d6d3e9bdaa869810679b7fb86a1ca69469d75f5e"
>>  
>> 
> 
> 
> 
> 
> 
> -- 
> # Randy MacLeod
> # Wind River Linux

[-- Attachment #2: Type: text/html, Size: 32126 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [OE-core] [PATCH v2 1/5] rust: Fetch cargo from rust-snapshot dir.
  2024-01-19 15:09 [PATCH v2 1/5] rust: Fetch cargo from rust-snapshot dir Yash.Shinde
                   ` (3 preceding siblings ...)
  2024-01-19 15:09 ` [PATCH v2 5/5] rust: Enable rust oe-selftest Yash.Shinde
@ 2024-01-20  8:42 ` Richard Purdie
       [not found] ` <17AC01A476481111.16230@lists.openembedded.org>
  2024-01-20 17:03 ` Randy MacLeod
  6 siblings, 0 replies; 13+ messages in thread
From: Richard Purdie @ 2024-01-20  8:42 UTC (permalink / raw)
  To: Yash.Shinde, openembedded-core
  Cc: Randy.MacLeod, Umesh.Kallapa, Naveen.Gowda, Sundeep.Kokkonda,
	Shivaprasad.Moodalappa

On Fri, 2024-01-19 at 07:09 -0800, Shinde, Yash via
lists.openembedded.org wrote:
> From: Yash Shinde <Yash.Shinde@windriver.com>
> 
> Fixes: Exception: no cargo executable found at
>        `${B}/rustc-1.74.1-src/build/x86_64-unknown-linux-gnu/stage0/bin/cargo`
> 
> Fix the cargo binary path error on oe-selftest and path set to rust-snapshot dir.
> 
> Patch sent to upstream- https://github.com/rust-lang/rust/pull/120125
> 
> Signed-off-by: Yash Shinde <Yash.Shinde@windriver.com>
> ---
>  .../rust/files/cargo-path.patch               | 37 +++++++++++++++++++
>  1 file changed, 37 insertions(+)
>  create mode 100644 meta/recipes-devtools/rust/files/cargo-path.patch

The series failed on mips in testing:

https://autobuilder.yoctoproject.org/typhoon/#/builders/147/builds/1196/steps/12/logs/stdio

Sadly the error redirection is to a file and even in the failed build,
we do not have that file as far as I can see so it is hard to know what
went wrong.

I'm not sure how much we care about mips+rust so if we did want to skip
the tests there, I'd not be against that.

Cheers,

Richard


^ permalink raw reply	[flat|nested] 13+ messages in thread

[parent not found: <17AC01A476481111.16230@lists.openembedded.org>]

* Re: [OE-core] [PATCH v2 1/5] rust: Fetch cargo from rust-snapshot dir.
       [not found] ` <17AC01A476481111.16230@lists.openembedded.org>
@ 2024-01-20  8:49   ` Richard Purdie
  2024-01-20 10:46     ` Yash Shinde
  0 siblings, 1 reply; 13+ messages in thread
From: Richard Purdie @ 2024-01-20  8:49 UTC (permalink / raw)
  To: Yash.Shinde, openembedded-core
  Cc: Randy.MacLeod, Umesh.Kallapa, Naveen.Gowda, Sundeep.Kokkonda,
	Shivaprasad.Moodalappa

On Sat, 2024-01-20 at 08:42 +0000, Richard Purdie via
lists.openembedded.org wrote:
> On Fri, 2024-01-19 at 07:09 -0800, Shinde, Yash via
> lists.openembedded.org wrote:
> > From: Yash Shinde <Yash.Shinde@windriver.com>
> > 
> > Fixes: Exception: no cargo executable found at
> >        `${B}/rustc-1.74.1-src/build/x86_64-unknown-linux-gnu/stage0/bin/cargo`
> > 
> > Fix the cargo binary path error on oe-selftest and path set to rust-snapshot dir.
> > 
> > Patch sent to upstream- https://github.com/rust-lang/rust/pull/120125
> > 
> > Signed-off-by: Yash Shinde <Yash.Shinde@windriver.com>
> > ---
> >  .../rust/files/cargo-path.patch               | 37 +++++++++++++++++++
> >  1 file changed, 37 insertions(+)
> >  create mode 100644 meta/recipes-devtools/rust/files/cargo-path.patch
> 
> The series failed on mips in testing:
> 
> https://autobuilder.yoctoproject.org/typhoon/#/builders/147/builds/1196/steps/12/logs/stdio
> 
> Sadly the error redirection is to a file and even in the failed build,
> we do not have that file as far as I can see so it is hard to know what
> went wrong.

I was able to find the file:

https://autobuilder.yocto.io/pub/failed-builds-data/summary.txt

(buildbot-venv) [pokybuild@rocky9-ty-1 build-st-1051644]$ cp ./tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/summary.txt /srv/autobuilder/autobuilder.yocto.io/pub/failed-builds-data/

---- [ui] tests/ui/issues/issue-32805.rs stdout ----

error: test run failed!
status: exit status: 101
command: RUST_TEST_THREADS="56" "/home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/build/x86_64-unknown-linux-gnu/stage0-tools-bin/remote-test-client" "run" "0" "/home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-32805/a"
--- stdout -------------------------------
uploaded "/home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-32805/a", waiting for result
------------------------------------------
--- stderr -------------------------------
thread 'main' panicked at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/issues/issue-32805.rs:9:5:
assertion `left == right` failed
  left: "9007199000000000"
 right: "9007200000000000"
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
------------------------------------------


---- [ui] tests/ui/numbers-arithmetic/i128.rs stdout ----

error: test run failed!
status: exit status: 101
command: RUST_TEST_THREADS="56" "/home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/build/x86_64-unknown-linux-gnu/stage0-tools-bin/remote-test-client" "run" "0" "/home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/build/x86_64-unknown-linux-gnu/test/ui/numbers-arithmetic/i128/a"
--- stdout -------------------------------
uploaded "/home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/build/x86_64-unknown-linux-gnu/test/ui/numbers-arithmetic/i128/a", waiting for result
------------------------------------------
--- stderr -------------------------------
thread 'main' panicked at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/numbers-arithmetic/i128.rs:77:5:
assertion `left == right` failed
  left: "-147573952589676412928"
 right: "-147573966419676412928"
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
------------------------------------------


---- [ui] tests/ui/numbers-arithmetic/saturating-float-casts.rs stdout ----

error: test run failed!
status: exit status: 101
command: RUST_TEST_THREADS="56" "/home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/build/x86_64-unknown-linux-gnu/stage0-tools-bin/remote-test-client" "run" "0" "/home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/build/x86_64-unknown-linux-gnu/test/ui/numbers-arithmetic/saturating-float-casts/a"
--- stdout -------------------------------
uploaded "/home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/build/x86_64-unknown-linux-gnu/test/ui/numbers-arithmetic/saturating-float-casts/a", waiting for result
------------------------------------------
--- stderr -------------------------------
thread 'main' panicked at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/numbers-arithmetic/saturating-float-casts-impl.rs:306:5:
assertion `left == right` failed
  left: 9223372034707291136
 right: 9223372036854774784
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
------------------------------------------


---- [ui] tests/ui/runtime/backtrace-debuginfo.rs stdout ----

error: test run failed!
status: exit status: 101
command: RUST_TEST_THREADS="56" "/home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/build/x86_64-unknown-linux-gnu/stage0-tools-bin/remote-test-client" "run" "0" "/home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/build/x86_64-unknown-linux-gnu/test/ui/runtime/backtrace-debuginfo/a"
--- stdout -------------------------------
uploaded "/home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/build/x86_64-unknown-linux-gnu/test/ui/runtime/backtrace-debuginfo/a", waiting for result
---------------------------------------
trace does not match position list
still need to find ["backtrace-debuginfo.rs:184"]

--- stdout
backtrace-debuginfo.rs:120
backtrace-debuginfo.rs:184

--- stderr
test case 0
thread 'main' panicked at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:81:5:
explicit panic
stack backtrace:
   0: 0x77cd3ae0 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h6898032c3197bba5
   1: 0x77d4e0e4 - core::fmt::write::hf6bcb3d48b015242
   2: 0x77c82d54 - std::io::Write::write_fmt::hffe3e31c2861b5df
   3: 0x77cd3800 - std::sys_common::backtrace::print::h491eee5f314a6d3e
   4: 0x77cada60 - std::panicking::default_hook::{{closure}}::h3f9aca89bfc7d815
   5: 0x77cad60c - std::panicking::default_hook::h10484dd96d8a78c1
   6: 0x77caed38 - std::panicking::rust_panic_with_hook::h86181dc20368b5d6
   7: 0x555e4924 - std::panicking::begin_panic::{{closure}}::hd81347ec628d3ce5
                       at /rustc/FAKE_PREFIX/library/std/src/panicking.rs:639:9
   8: 0x555e42dc - std::sys_common::backtrace::__rust_end_short_backtrace::hb942b2283d335406
                       at /rustc/FAKE_PREFIX/library/std/src/sys_common/backtrace.rs:170:18
   9: 0x555e4858 - std::panicking::begin_panic::h80500b64f44d7de8
                       at /rustc/FAKE_PREFIX/library/std/src/panicking.rs:550:12
  10: 0x555f6bf0 - backtrace_debuginfo::inner::h5b01f04da66e8433
                       at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:81:5
  11: 0x555f76e8 - backtrace_debuginfo::outer::hb144f59b805e2ef5
                       at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:120:5
  12: 0x555f90b8 - backtrace_debuginfo::main::h7f1d9bc6ac819adb
                       at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:92:9
  13: 0x555e5724 - core::ops::function::FnOnce::call_once::h16f2dc3c14904d22
                       at /rustc/FAKE_PREFIX/library/core/src/ops/function.rs:250:5
  14: 0x555e4314 - std::sys_common::backtrace::__rust_begin_short_backtrace::hd19d7735b8befc66
  15: 0x555e43ec - std::rt::lang_start::{{closure}}::h151e66a657c26aab
                       at /rustc/FAKE_PREFIX/library/std/src/rt.rs:166:18
  16: 0x77cae4dc - std::panicking::try::do_call::hd0c2b6472aa643bd
  17: 0x77cb0e8c - __rust_try.llvm.18295924575204975277
  18: 0x77cae2c4 - std::panicking::try::do_call::hbdd1fae3cce0762a
  19: 0x77cb0e8c - __rust_try.llvm.18295924575204975277
  20: 0x77c6bcc8 - std::rt::lang_start_internal::hb3baca0999cfc254
  21: 0x555e4390 - std::rt::lang_start::hfc18ff07c79696d1
                       at /rustc/FAKE_PREFIX/library/std/src/rt.rs:165:17
  22: 0x555f9184 - main
  23: 0x779f4fe4 - <unknown>
  24: 0x779f5120 - __libc_start_main
  25: 0x555e2200 - <unknown>
                       at /usr/src/debug/glibc/2.38+git/csu/../sysdeps/mips/start.S:110

---------------------------------------
trace does not match position list
still need to find ["backtrace-debuginfo.rs:184"]

--- stdout
backtrace-debuginfo.rs:120
backtrace-debuginfo.rs:184

--- stderr
test case 1
thread 'main' panicked at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:82:5:
explicit panic
stack backtrace:
   0: 0x77cd3ae0 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h6898032c3197bba5
   1: 0x77d4e0e4 - core::fmt::write::hf6bcb3d48b015242
   2: 0x77c82d54 - std::io::Write::write_fmt::hffe3e31c2861b5df
   3: 0x77cd3800 - std::sys_common::backtrace::print::h491eee5f314a6d3e
   4: 0x77cada60 - std::panicking::default_hook::{{closure}}::h3f9aca89bfc7d815
   5: 0x77cad60c - std::panicking::default_hook::h10484dd96d8a78c1
   6: 0x77caed38 - std::panicking::rust_panic_with_hook::h86181dc20368b5d6
   7: 0x55604924 - std::panicking::begin_panic::{{closure}}::hd81347ec628d3ce5
                       at /rustc/FAKE_PREFIX/library/std/src/panicking.rs:639:9
   8: 0x556042dc - std::sys_common::backtrace::__rust_end_short_backtrace::hb942b2283d335406
                       at /rustc/FAKE_PREFIX/library/std/src/sys_common/backtrace.rs:170:18
   9: 0x55604858 - std::panicking::begin_panic::h80500b64f44d7de8
                       at /rustc/FAKE_PREFIX/library/std/src/panicking.rs:550:12
  10: 0x55616d44 - backtrace_debuginfo::inner::h5b01f04da66e8433
                       at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:82:5
  11: 0x556176e8 - backtrace_debuginfo::outer::hb144f59b805e2ef5
                       at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:120:5
  12: 0x556190b8 - backtrace_debuginfo::main::h7f1d9bc6ac819adb
                       at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:92:9
  13: 0x55605724 - core::ops::function::FnOnce::call_once::h16f2dc3c14904d22
                       at /rustc/FAKE_PREFIX/library/core/src/ops/function.rs:250:5
  14: 0x55604314 - std::sys_common::backtrace::__rust_begin_short_backtrace::hd19d7735b8befc66
  15: 0x556043ec - std::rt::lang_start::{{closure}}::h151e66a657c26aab
                       at /rustc/FAKE_PREFIX/library/std/src/rt.rs:166:18
  16: 0x77cae4dc - std::panicking::try::do_call::hd0c2b6472aa643bd
  17: 0x77cb0e8c - __rust_try.llvm.18295924575204975277
  18: 0x77cae2c4 - std::panicking::try::do_call::hbdd1fae3cce0762a
  19: 0x77cb0e8c - __rust_try.llvm.18295924575204975277
  20: 0x77c6bcc8 - std::rt::lang_start_internal::hb3baca0999cfc254
  21: 0x55604390 - std::rt::lang_start::hfc18ff07c79696d1
                       at /rustc/FAKE_PREFIX/library/std/src/rt.rs:165:17
  22: 0x55619184 - main
  23: 0x779f4fe4 - <unknown>
  24: 0x779f5120 - __libc_start_main
  25: 0x55602200 - <unknown>
                       at /usr/src/debug/glibc/2.38+git/csu/../sysdeps/mips/start.S:110

---------------------------------------
trace does not match position list
still need to find ["backtrace-debuginfo.rs:184"]

--- stdout
backtrace-debuginfo-aux.rs:6
backtrace-debuginfo.rs:83
backtrace-debuginfo.rs:120
backtrace-debuginfo.rs:184

--- stderr
test case 2
thread 'main' panicked at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:84:9:
explicit panic
stack backtrace:
   0: 0x77d23ae0 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h6898032c3197bba5
   1: 0x77d9e0e4 - core::fmt::write::hf6bcb3d48b015242
   2: 0x77cd2d54 - std::io::Write::write_fmt::hffe3e31c2861b5df
   3: 0x77d23800 - std::sys_common::backtrace::print::h491eee5f314a6d3e
   4: 0x77cfda60 - std::panicking::default_hook::{{closure}}::h3f9aca89bfc7d815
   5: 0x77cfd60c - std::panicking::default_hook::h10484dd96d8a78c1
   6: 0x77cfed38 - std::panicking::rust_panic_with_hook::h86181dc20368b5d6
   7: 0x55594924 - std::panicking::begin_panic::{{closure}}::hd81347ec628d3ce5
                       at /rustc/FAKE_PREFIX/library/std/src/panicking.rs:639:9
   8: 0x555942dc - std::sys_common::backtrace::__rust_end_short_backtrace::hb942b2283d335406
                       at /rustc/FAKE_PREFIX/library/std/src/sys_common/backtrace.rs:170:18
   9: 0x55594858 - std::panicking::begin_panic::h80500b64f44d7de8
                       at /rustc/FAKE_PREFIX/library/std/src/panicking.rs:550:12
  10: 0x555a701c - backtrace_debuginfo::inner::{{closure}}::hd7243845f0587caf
                       at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:84:9
  11: 0x555a684c - backtrace_debuginfo::aux::callback::he17da27d625d76ab
                       at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo-aux.rs:6:5
  12: 0x555a6d9c - backtrace_debuginfo::inner::h5b01f04da66e8433
                       at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:83:29
  13: 0x555a76e8 - backtrace_debuginfo::outer::hb144f59b805e2ef5
                       at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:120:5
  14: 0x555a90b8 - backtrace_debuginfo::main::h7f1d9bc6ac819adb
                       at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:92:9
  15: 0x55595724 - core::ops::function::FnOnce::call_once::h16f2dc3c14904d22
                       at /rustc/FAKE_PREFIX/library/core/src/ops/function.rs:250:5
  16: 0x55594314 - std::sys_common::backtrace::__rust_begin_short_backtrace::hd19d7735b8befc66
  17: 0x555943ec - std::rt::lang_start::{{closure}}::h151e66a657c26aab
                       at /rustc/FAKE_PREFIX/library/std/src/rt.rs:166:18
  18: 0x77cfe4dc - std::panicking::try::do_call::hd0c2b6472aa643bd
  19: 0x77d00e8c - __rust_try.llvm.18295924575204975277
  20: 0x77cfe2c4 - std::panicking::try::do_call::hbdd1fae3cce0762a
  21: 0x77d00e8c - __rust_try.llvm.18295924575204975277
  22: 0x77cbbcc8 - std::rt::lang_start_internal::hb3baca0999cfc254
  23: 0x55594390 - std::rt::lang_start::hfc18ff07c79696d1
                       at /rustc/FAKE_PREFIX/library/std/src/rt.rs:165:17
  24: 0x555a9184 - main
  25: 0x77a44fe4 - <unknown>
  26: 0x77a45120 - __libc_start_main
  27: 0x55592200 - <unknown>
                       at /usr/src/debug/glibc/2.38+git/csu/../sysdeps/mips/start.S:110

---------------------------------------
trace does not match position list
still need to find ["backtrace-debuginfo.rs:184", "backtrace-debuginfo.rs:120", "backtrace-debuginfo.rs:86", "backtrace-debuginfo-aux.rs:13"]

--- stdout
backtrace-debuginfo-aux.rs:13
backtrace-debuginfo.rs:86
backtrace-debuginfo.rs:120
backtrace-debuginfo.rs:184

--- stderr
test case 3
thread 'main' panicked at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:87:9:
explicit panic
stack backtrace:
   0: 0x77d33ae0 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h6898032c3197bba5
   1: 0x77dae0e4 - core::fmt::write::hf6bcb3d48b015242
   2: 0x77ce2d54 - std::io::Write::write_fmt::hffe3e31c2861b5df
   3: 0x77d33800 - std::sys_common::backtrace::print::h491eee5f314a6d3e
   4: 0x77d0da60 - std::panicking::default_hook::{{closure}}::h3f9aca89bfc7d815
   5: 0x77d0d60c - std::panicking::default_hook::h10484dd96d8a78c1
   6: 0x77d0ed38 - std::panicking::rust_panic_with_hook::h86181dc20368b5d6
   7: 0x555a4924 - std::panicking::begin_panic::{{closure}}::hd81347ec628d3ce5
                       at /rustc/FAKE_PREFIX/library/std/src/panicking.rs:639:9
   8: 0x555a42dc - std::sys_common::backtrace::__rust_end_short_backtrace::hb942b2283d335406
                       at /rustc/FAKE_PREFIX/library/std/src/sys_common/backtrace.rs:170:18
   9: 0x555a4858 - std::panicking::begin_panic::h80500b64f44d7de8
                       at /rustc/FAKE_PREFIX/library/std/src/panicking.rs:550:12
  10: 0x555b7218 - backtrace_debuginfo::inner::{{closure}}::h3f1727189fdeb2ac
                       at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:87:9
  11: 0x555b6e2c - backtrace_debuginfo::aux::callback_inlined::h06cdd336843b84bf
  12: 0x555b6e2c - backtrace_debuginfo::inner::h5b01f04da66e8433
                       at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:86:29
  13: 0x555b76e8 - backtrace_debuginfo::outer::hb144f59b805e2ef5
                       at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:120:5
  14: 0x555b90b8 - backtrace_debuginfo::main::h7f1d9bc6ac819adb
                       at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:92:9
  15: 0x555a5724 - core::ops::function::FnOnce::call_once::h16f2dc3c14904d22
                       at /rustc/FAKE_PREFIX/library/core/src/ops/function.rs:250:5
  16: 0x555a4314 - std::sys_common::backtrace::__rust_begin_short_backtrace::hd19d7735b8befc66
  17: 0x555a43ec - std::rt::lang_start::{{closure}}::h151e66a657c26aab
                       at /rustc/FAKE_PREFIX/library/std/src/rt.rs:166:18
  18: 0x77d0e4dc - std::panicking::try::do_call::hd0c2b6472aa643bd
  19: 0x77d10e8c - __rust_try.llvm.18295924575204975277
  20: 0x77d0e2c4 - std::panicking::try::do_call::hbdd1fae3cce0762a
  21: 0x77d10e8c - __rust_try.llvm.18295924575204975277
  22: 0x77ccbcc8 - std::rt::lang_start_internal::hb3baca0999cfc254
  23: 0x555a4390 - std::rt::lang_start::hfc18ff07c79696d1
                       at /rustc/FAKE_PREFIX/library/std/src/rt.rs:165:17
  24: 0x555b9184 - main
  25: 0x77a54fe4 - <unknown>
  26: 0x77a55120 - __libc_start_main
  27: 0x555a2200 - <unknown>
                       at /usr/src/debug/glibc/2.38+git/csu/../sysdeps/mips/start.S:110

---------------------------------------
trace does not match position list
still need to find ["backtrace-debuginfo.rs:184"]

--- stdout
backtrace-debuginfo.rs:121
backtrace-debuginfo.rs:184

--- stderr
test case 4
thread 'main' panicked at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:95:5:
explicit panic
stack backtrace:
   0: 0x77d23ae0 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h6898032c3197bba5
   1: 0x77d9e0e4 - core::fmt::write::hf6bcb3d48b015242
   2: 0x77cd2d54 - std::io::Write::write_fmt::hffe3e31c2861b5df
   3: 0x77d23800 - std::sys_common::backtrace::print::h491eee5f314a6d3e
   4: 0x77cfda60 - std::panicking::default_hook::{{closure}}::h3f9aca89bfc7d815
   5: 0x77cfd60c - std::panicking::default_hook::h10484dd96d8a78c1
   6: 0x77cfed38 - std::panicking::rust_panic_with_hook::h86181dc20368b5d6
   7: 0x55594924 - std::panicking::begin_panic::{{closure}}::hd81347ec628d3ce5
                       at /rustc/FAKE_PREFIX/library/std/src/panicking.rs:639:9
   8: 0x555942dc - std::sys_common::backtrace::__rust_end_short_backtrace::hb942b2283d335406
                       at /rustc/FAKE_PREFIX/library/std/src/sys_common/backtrace.rs:170:18
   9: 0x55594858 - std::panicking::begin_panic::h80500b64f44d7de8
                       at /rustc/FAKE_PREFIX/library/std/src/panicking.rs:550:12
  10: 0x555a77f0 - backtrace_debuginfo::inner_inlined::h55411b2de0d92a78
  11: 0x555a77f0 - backtrace_debuginfo::outer::hb144f59b805e2ef5
                       at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:121:5
  12: 0x555a90b8 - backtrace_debuginfo::main::h7f1d9bc6ac819adb
                       at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:92:9
  13: 0x55595724 - core::ops::function::FnOnce::call_once::h16f2dc3c14904d22
                       at /rustc/FAKE_PREFIX/library/core/src/ops/function.rs:250:5
  14: 0x55594314 - std::sys_common::backtrace::__rust_begin_short_backtrace::hd19d7735b8befc66
  15: 0x555943ec - std::rt::lang_start::{{closure}}::h151e66a657c26aab
                       at /rustc/FAKE_PREFIX/library/std/src/rt.rs:166:18
  16: 0x77cfe4dc - std::panicking::try::do_call::hd0c2b6472aa643bd
  17: 0x77d00e8c - __rust_try.llvm.18295924575204975277
  18: 0x77cfe2c4 - std::panicking::try::do_call::hbdd1fae3cce0762a
  19: 0x77d00e8c - __rust_try.llvm.18295924575204975277
  20: 0x77cbbcc8 - std::rt::lang_start_internal::hb3baca0999cfc254
  21: 0x55594390 - std::rt::lang_start::hfc18ff07c79696d1
                       at /rustc/FAKE_PREFIX/library/std/src/rt.rs:165:17
  22: 0x555a9184 - main
  23: 0x77a44fe4 - <unknown>
  24: 0x77a45120 - __libc_start_main
  25: 0x55592200 - <unknown>
                       at /usr/src/debug/glibc/2.38+git/csu/../sysdeps/mips/start.S:110

---------------------------------------
trace does not match position list
still need to find ["backtrace-debuginfo.rs:184"]

--- stdout
backtrace-debuginfo.rs:121
backtrace-debuginfo.rs:184

--- stderr
test case 5
thread 'main' panicked at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:96:5:
explicit panic
stack backtrace:
   0: 0x77d63ae0 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h6898032c3197bba5
   1: 0x77dde0e4 - core::fmt::write::hf6bcb3d48b015242
   2: 0x77d12d54 - std::io::Write::write_fmt::hffe3e31c2861b5df
   3: 0x77d63800 - std::sys_common::backtrace::print::h491eee5f314a6d3e
   4: 0x77d3da60 - std::panicking::default_hook::{{closure}}::h3f9aca89bfc7d815
   5: 0x77d3d60c - std::panicking::default_hook::h10484dd96d8a78c1
   6: 0x77d3ed38 - std::panicking::rust_panic_with_hook::h86181dc20368b5d6
   7: 0x55624924 - std::panicking::begin_panic::{{closure}}::hd81347ec628d3ce5
                       at /rustc/FAKE_PREFIX/library/std/src/panicking.rs:639:9
   8: 0x556242dc - std::sys_common::backtrace::__rust_end_short_backtrace::hb942b2283d335406
                       at /rustc/FAKE_PREFIX/library/std/src/sys_common/backtrace.rs:170:18
   9: 0x55624858 - std::panicking::begin_panic::h80500b64f44d7de8
                       at /rustc/FAKE_PREFIX/library/std/src/panicking.rs:550:12
  10: 0x55637914 - backtrace_debuginfo::inner_inlined::h55411b2de0d92a78
                       at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:1:5
  11: 0x55637914 - backtrace_debuginfo::outer::hb144f59b805e2ef5
                       at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:121:5
  12: 0x556390b8 - backtrace_debuginfo::main::h7f1d9bc6ac819adb
                       at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:92:9
  13: 0x55625724 - core::ops::function::FnOnce::call_once::h16f2dc3c14904d22
                       at /rustc/FAKE_PREFIX/library/core/src/ops/function.rs:250:5
  14: 0x55624314 - std::sys_common::backtrace::__rust_begin_short_backtrace::hd19d7735b8befc66
  15: 0x556243ec - std::rt::lang_start::{{closure}}::h151e66a657c26aab
                       at /rustc/FAKE_PREFIX/library/std/src/rt.rs:166:18
  16: 0x77d3e4dc - std::panicking::try::do_call::hd0c2b6472aa643bd
  17: 0x77d40e8c - __rust_try.llvm.18295924575204975277
  18: 0x77d3e2c4 - std::panicking::try::do_call::hbdd1fae3cce0762a
  19: 0x77d40e8c - __rust_try.llvm.18295924575204975277
  20: 0x77cfbcc8 - std::rt::lang_start_internal::hb3baca0999cfc254
  21: 0x55624390 - std::rt::lang_start::hfc18ff07c79696d1
                       at /rustc/FAKE_PREFIX/library/std/src/rt.rs:165:17
  22: 0x55639184 - main
  23: 0x77a84fe4 - <unknown>
  24: 0x77a85120 - __libc_start_main
  25: 0x55622200 - <unknown>
                       at /usr/src/debug/glibc/2.38+git/csu/../sysdeps/mips/start.S:110

---------------------------------------
trace does not match position list
still need to find ["backtrace-debuginfo.rs:184"]

--- stdout
backtrace-debuginfo.rs:104
backtrace-debuginfo.rs:121
backtrace-debuginfo.rs:184

--- stderr
test case 6
thread 'main' panicked at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:102:9:
explicit panic
stack backtrace:
   0: 0x77cc3ae0 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h6898032c3197bba5
   1: 0x77d3e0e4 - core::fmt::write::hf6bcb3d48b015242
   2: 0x77c72d54 - std::io::Write::write_fmt::hffe3e31c2861b5df
   3: 0x77cc3800 - std::sys_common::backtrace::print::h491eee5f314a6d3e
   4: 0x77c9da60 - std::panicking::default_hook::{{closure}}::h3f9aca89bfc7d815
   5: 0x77c9d60c - std::panicking::default_hook::h10484dd96d8a78c1
   6: 0x77c9ed38 - std::panicking::rust_panic_with_hook::h86181dc20368b5d6
   7: 0x55634924 - std::panicking::begin_panic::{{closure}}::hd81347ec628d3ce5
                       at /rustc/FAKE_PREFIX/library/std/src/panicking.rs:639:9
   8: 0x556342dc - std::sys_common::backtrace::__rust_end_short_backtrace::hb942b2283d335406
                       at /rustc/FAKE_PREFIX/library/std/src/sys_common/backtrace.rs:170:18
   9: 0x55634858 - std::panicking::begin_panic::h80500b64f44d7de8
                       at /rustc/FAKE_PREFIX/library/std/src/panicking.rs:550:12
  10: 0x55647a8c - backtrace_debuginfo::inner_inlined::inner_further_inlined::h4fdfd57c7edbf831
                       at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:7:9
  11: 0x55647a8c - backtrace_debuginfo::inner_inlined::h55411b2de0d92a78
                       at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:104:5
  12: 0x55647a8c - backtrace_debuginfo::outer::hb144f59b805e2ef5
                       at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:121:5
  13: 0x556490b8 - backtrace_debuginfo::main::h7f1d9bc6ac819adb
                       at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:92:9
  14: 0x55635724 - core::ops::function::FnOnce::call_once::h16f2dc3c14904d22
                       at /rustc/FAKE_PREFIX/library/core/src/ops/function.rs:250:5
  15: 0x55634314 - std::sys_common::backtrace::__rust_begin_short_backtrace::hd19d7735b8befc66
  16: 0x556343ec - std::rt::lang_start::{{closure}}::h151e66a657c26aab
                       at /rustc/FAKE_PREFIX/library/std/src/rt.rs:166:18
  17: 0x77c9e4dc - std::panicking::try::do_call::hd0c2b6472aa643bd
  18: 0x77ca0e8c - __rust_try.llvm.18295924575204975277
  19: 0x77c9e2c4 - std::panicking::try::do_call::hbdd1fae3cce0762a
  20: 0x77ca0e8c - __rust_try.llvm.18295924575204975277
  21: 0x77c5bcc8 - std::rt::lang_start_internal::hb3baca0999cfc254
  22: 0x55634390 - std::rt::lang_start::hfc18ff07c79696d1
                       at /rustc/FAKE_PREFIX/library/std/src/rt.rs:165:17
  23: 0x55649184 - main
  24: 0x779e4fe4 - <unknown>
  25: 0x779e5120 - __libc_start_main
  26: 0x55632200 - <unknown>
                       at /usr/src/debug/glibc/2.38+git/csu/../sysdeps/mips/start.S:110

---------------------------------------
trace does not match position list
still need to find ["backtrace-debuginfo.rs:184", "backtrace-debuginfo.rs:121", "backtrace-debuginfo.rs:106"]

--- stdout
backtrace-debuginfo-aux.rs:6
backtrace-debuginfo.rs:106
backtrace-debuginfo.rs:121
backtrace-debuginfo.rs:184

--- stderr
test case 7
thread 'main' panicked at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:107:9:
explicit panic
stack backtrace:
   0: 0x77cd3ae0 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h6898032c3197bba5
   1: 0x77d4e0e4 - core::fmt::write::hf6bcb3d48b015242
   2: 0x77c82d54 - std::io::Write::write_fmt::hffe3e31c2861b5df
   3: 0x77cd3800 - std::sys_common::backtrace::print::h491eee5f314a6d3e
   4: 0x77cada60 - std::panicking::default_hook::{{closure}}::h3f9aca89bfc7d815
   5: 0x77cad60c - std::panicking::default_hook::h10484dd96d8a78c1
   6: 0x77caed38 - std::panicking::rust_panic_with_hook::h86181dc20368b5d6
   7: 0x55634924 - std::panicking::begin_panic::{{closure}}::hd81347ec628d3ce5
                       at /rustc/FAKE_PREFIX/library/std/src/panicking.rs:639:9
   8: 0x556342dc - std::sys_common::backtrace::__rust_end_short_backtrace::hb942b2283d335406
                       at /rustc/FAKE_PREFIX/library/std/src/sys_common/backtrace.rs:170:18
   9: 0x55634858 - std::panicking::begin_panic::h80500b64f44d7de8
                       at /rustc/FAKE_PREFIX/library/std/src/panicking.rs:550:12
  10: 0x55647414 - backtrace_debuginfo::inner_inlined::{{closure}}::hd6497c9cceb9b086
                       at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:107:9
  11: 0x556467c0 - backtrace_debuginfo::aux::callback::h6768a2f4a4c9de81
                       at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo-aux.rs:6:5
  12: 0x55647b44 - backtrace_debuginfo::inner_inlined::h55411b2de0d92a78
                       at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:11:29
  13: 0x55647b44 - backtrace_debuginfo::outer::hb144f59b805e2ef5
                       at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:121:5
  14: 0x556490b8 - backtrace_debuginfo::main::h7f1d9bc6ac819adb
                       at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:92:9
  15: 0x55635724 - core::ops::function::FnOnce::call_once::h16f2dc3c14904d22
                       at /rustc/FAKE_PREFIX/library/core/src/ops/function.rs:250:5
  16: 0x55634314 - std::sys_common::backtrace::__rust_begin_short_backtrace::hd19d7735b8befc66
  17: 0x556343ec - std::rt::lang_start::{{closure}}::h151e66a657c26aab
                       at /rustc/FAKE_PREFIX/library/std/src/rt.rs:166:18
  18: 0x77cae4dc - std::panicking::try::do_call::hd0c2b6472aa643bd
  19: 0x77cb0e8c - __rust_try.llvm.18295924575204975277
  20: 0x77cae2c4 - std::panicking::try::do_call::hbdd1fae3cce0762a
  21: 0x77cb0e8c - __rust_try.llvm.18295924575204975277
  22: 0x77c6bcc8 - std::rt::lang_start_internal::hb3baca0999cfc254
  23: 0x55634390 - std::rt::lang_start::hfc18ff07c79696d1
                       at /rustc/FAKE_PREFIX/library/std/src/rt.rs:165:17
  24: 0x55649184 - main
  25: 0x779f4fe4 - <unknown>
  26: 0x779f5120 - __libc_start_main
  27: 0x55632200 - <unknown>
                       at /usr/src/debug/glibc/2.38+git/csu/../sysdeps/mips/start.S:110

---------------------------------------
trace does not match position list
still need to find ["backtrace-debuginfo.rs:184", "backtrace-debuginfo.rs:121", "backtrace-debuginfo.rs:109", "backtrace-debuginfo-aux.rs:13"]

--- stdout
backtrace-debuginfo-aux.rs:13
backtrace-debuginfo.rs:109
backtrace-debuginfo.rs:121
backtrace-debuginfo.rs:184

--- stderr
test case 8
thread 'main' panicked at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:110:9:
explicit panic
stack backtrace:
   0: 0x77d33ae0 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h6898032c3197bba5
   1: 0x77dae0e4 - core::fmt::write::hf6bcb3d48b015242
   2: 0x77ce2d54 - std::io::Write::write_fmt::hffe3e31c2861b5df
   3: 0x77d33800 - std::sys_common::backtrace::print::h491eee5f314a6d3e
   4: 0x77d0da60 - std::panicking::default_hook::{{closure}}::h3f9aca89bfc7d815
   5: 0x77d0d60c - std::panicking::default_hook::h10484dd96d8a78c1
   6: 0x77d0ed38 - std::panicking::rust_panic_with_hook::h86181dc20368b5d6
   7: 0x55624924 - std::panicking::begin_panic::{{closure}}::hd81347ec628d3ce5
                       at /rustc/FAKE_PREFIX/library/std/src/panicking.rs:639:9
   8: 0x556242dc - std::sys_common::backtrace::__rust_end_short_backtrace::hb942b2283d335406
                       at /rustc/FAKE_PREFIX/library/std/src/sys_common/backtrace.rs:170:18
   9: 0x55624858 - std::panicking::begin_panic::h80500b64f44d7de8
                       at /rustc/FAKE_PREFIX/library/std/src/panicking.rs:550:12
  10: 0x55637610 - backtrace_debuginfo::inner_inlined::{{closure}}::h45563682bb90bb96
                       at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:110:9
  11: 0x55637bd4 - backtrace_debuginfo::aux::callback_inlined::h99af8f3c81a5476e
  12: 0x55637bd4 - backtrace_debuginfo::inner_inlined::h55411b2de0d92a78
                       at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:109:29
  13: 0x55637bd4 - backtrace_debuginfo::outer::hb144f59b805e2ef5
                       at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:121:5
  14: 0x556390b8 - backtrace_debuginfo::main::h7f1d9bc6ac819adb
                       at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:92:9
  15: 0x55625724 - core::ops::function::FnOnce::call_once::h16f2dc3c14904d22
                       at /rustc/FAKE_PREFIX/library/core/src/ops/function.rs:250:5
  16: 0x55624314 - std::sys_common::backtrace::__rust_begin_short_backtrace::hd19d7735b8befc66
  17: 0x556243ec - std::rt::lang_start::{{closure}}::h151e66a657c26aab
                       at /rustc/FAKE_PREFIX/library/std/src/rt.rs:166:18
  18: 0x77d0e4dc - std::panicking::try::do_call::hd0c2b6472aa643bd
  19: 0x77d10e8c - __rust_try.llvm.18295924575204975277
  20: 0x77d0e2c4 - std::panicking::try::do_call::hbdd1fae3cce0762a
  21: 0x77d10e8c - __rust_try.llvm.18295924575204975277
  22: 0x77ccbcc8 - std::rt::lang_start_internal::hb3baca0999cfc254
  23: 0x55624390 - std::rt::lang_start::hfc18ff07c79696d1
                       at /rustc/FAKE_PREFIX/library/std/src/rt.rs:165:17
  24: 0x55639184 - main
  25: 0x77a54fe4 - <unknown>
  26: 0x77a55120 - __libc_start_main
  27: 0x55622200 - <unknown>
                       at /usr/src/debug/glibc/2.38+git/csu/../sysdeps/mips/start.S:110

---------------------------------------
trace does not match position list
still need to find ["backtrace-debuginfo.rs:184"]

--- stdout
backtrace-debuginfo.rs:115
backtrace-debuginfo.rs:121
backtrace-debuginfo.rs:184

--- stderr
test case 9
thread 'main' panicked at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:102:9:
explicit panic
stack backtrace:
   0: 0x77cd3ae0 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h6898032c3197bba5
   1: 0x77d4e0e4 - core::fmt::write::hf6bcb3d48b015242
   2: 0x77c82d54 - std::io::Write::write_fmt::hffe3e31c2861b5df
   3: 0x77cd3800 - std::sys_common::backtrace::print::h491eee5f314a6d3e
   4: 0x77cada60 - std::panicking::default_hook::{{closure}}::h3f9aca89bfc7d815
   5: 0x77cad60c - std::panicking::default_hook::h10484dd96d8a78c1
   6: 0x77caed38 - std::panicking::rust_panic_with_hook::h86181dc20368b5d6
   7: 0x55594924 - std::panicking::begin_panic::{{closure}}::hd81347ec628d3ce5
                       at /rustc/FAKE_PREFIX/library/std/src/panicking.rs:639:9
   8: 0x555942dc - std::sys_common::backtrace::__rust_end_short_backtrace::hb942b2283d335406
                       at /rustc/FAKE_PREFIX/library/std/src/sys_common/backtrace.rs:170:18
   9: 0x55594858 - std::panicking::begin_panic::h80500b64f44d7de8
                       at /rustc/FAKE_PREFIX/library/std/src/panicking.rs:550:12
  10: 0x555a7ce8 - backtrace_debuginfo::inner_inlined::inner_further_inlined::h4fdfd57c7edbf831
  11: 0x555a7ce8 - backtrace_debuginfo::inner_inlined::h55411b2de0d92a78
                       at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:115:5
  12: 0x555a7ce8 - backtrace_debuginfo::outer::hb144f59b805e2ef5
                       at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:121:5
  13: 0x555a90b8 - backtrace_debuginfo::main::h7f1d9bc6ac819adb
                       at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:92:9
  14: 0x55595724 - core::ops::function::FnOnce::call_once::h16f2dc3c14904d22
                       at /rustc/FAKE_PREFIX/library/core/src/ops/function.rs:250:5
  15: 0x55594314 - std::sys_common::backtrace::__rust_begin_short_backtrace::hd19d7735b8befc66
  16: 0x555943ec - std::rt::lang_start::{{closure}}::h151e66a657c26aab
                       at /rustc/FAKE_PREFIX/library/std/src/rt.rs:166:18
  17: 0x77cae4dc - std::panicking::try::do_call::hd0c2b6472aa643bd
  18: 0x77cb0e8c - __rust_try.llvm.18295924575204975277
  19: 0x77cae2c4 - std::panicking::try::do_call::hbdd1fae3cce0762a
  20: 0x77cb0e8c - __rust_try.llvm.18295924575204975277
  21: 0x77c6bcc8 - std::rt::lang_start_internal::hb3baca0999cfc254
  22: 0x55594390 - std::rt::lang_start::hfc18ff07c79696d1
                       at /rustc/FAKE_PREFIX/library/std/src/rt.rs:165:17
  23: 0x555a9184 - main
  24: 0x779f4fe4 - <unknown>
  25: 0x779f5120 - __libc_start_main
  26: 0x55592200 - <unknown>
                       at /usr/src/debug/glibc/2.38+git/csu/../sysdeps/mips/start.S:110
------------------------------------------
--- stderr -------------------------------
thread 'main' panicked at /home/pokybuild/yocto-worker/qemumips-tc/build/build-st-1051644/tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/tests/ui/runtime/backtrace-debuginfo.rs:174:9:
found some errors
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
------------------------------------------



failures:
    [ui] tests/ui/issues/issue-32805.rs
    [ui] tests/ui/numbers-arithmetic/i128.rs
    [ui] tests/ui/numbers-arithmetic/saturating-float-casts.rs
    [ui] tests/ui/runtime/backtrace-debuginfo.rs

test result: FAILED. 15246 passed; 4 failed; 291 ignored; 0 measured; 21 filtered out; finished in 693.24s

Some tests failed in compiletest suite=ui mode=ui host=x86_64-unknown-linux-gnu target=mips-poky-linux-gnu
Testing stage1 compiletest suite=run-pass-valgrind mode=run-pass-valgrind (x86_64-unknown-linux-gnu -> mips-poky-linux-gnu)

Cheers,

Richard


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [OE-core] [PATCH v2 1/5] rust: Fetch cargo from rust-snapshot dir.
  2024-01-20  8:49   ` Richard Purdie
@ 2024-01-20 10:46     ` Yash Shinde
  0 siblings, 0 replies; 13+ messages in thread
From: Yash Shinde @ 2024-01-20 10:46 UTC (permalink / raw)
  To: Richard Purdie, openembedded-core
  Cc: Randy.MacLeod, Umesh.Kallapa, Naveen.Gowda, Sundeep.Kokkonda,
	Shivaprasad.Moodalappa

[-- Attachment #1: Type: text/plain, Size: 3419 bytes --]


On 20-01-2024 14:19, Richard Purdie wrote:
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and know the content is safe.
>
> On Sat, 2024-01-20 at 08:42 +0000, Richard Purdie via
> lists.openembedded.org wrote:
>> On Fri, 2024-01-19 at 07:09 -0800, Shinde, Yash via
>> lists.openembedded.org wrote:
>>> From: Yash Shinde<Yash.Shinde@windriver.com>
>>>
>>> Fixes: Exception: no cargo executable found at
>>>         `${B}/rustc-1.74.1-src/build/x86_64-unknown-linux-gnu/stage0/bin/cargo`
>>>
>>> Fix the cargo binary path error on oe-selftest and path set to rust-snapshot dir.
>>>
>>> Patch sent to upstream-https://github.com/rust-lang/rust/pull/120125
>>>
>>> Signed-off-by: Yash Shinde<Yash.Shinde@windriver.com>
>>> ---
>>>   .../rust/files/cargo-path.patch               | 37 +++++++++++++++++++
>>>   1 file changed, 37 insertions(+)
>>>   create mode 100644 meta/recipes-devtools/rust/files/cargo-path.patch
>> The series failed on mips in testing:
>>
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/147/builds/1196/steps/12/logs/stdio
>>
>> Sadly the error redirection is to a file and even in the failed build,
>> we do not have that file as far as I can see so it is hard to know what
>> went wrong.
> I was able to find the file:
>
> https://autobuilder.yocto.io/pub/failed-builds-data/summary.txt
>
> (buildbot-venv) [pokybuild@rocky9-ty-1 build-st-1051644]$ cp ./tmp/work/mips32r2-poky-linux/rust/1.74.1/rustc-1.74.1-src/summary.txt /srv/autobuilder/autobuilder.yocto.io/pub/failed-builds-data/
>
> ---- [ui] tests/ui/issues/issue-32805.rs stdout ----
>
> .
> .
> .
> .
>
> failures:
>      [ui] tests/ui/issues/issue-32805.rs
>      [ui] tests/ui/numbers-arithmetic/i128.rs
>      [ui] tests/ui/numbers-arithmetic/saturating-float-casts.rs
>      [ui] tests/ui/runtime/backtrace-debuginfo.rs
>
> test result: FAILED. 15246 passed; 4 failed; 291 ignored; 0 measured; 21 filtered out; finished in 693.24s
>
> Some tests failed in compiletest suite=ui mode=ui host=x86_64-unknown-linux-gnu target=mips-poky-linux-gnu
> Testing stage1 compiletest suite=run-pass-valgrind mode=run-pass-valgrind (x86_64-unknown-linux-gnu -> mips-poky-linux-gnu)
>
It is observed that "mips(32 bits)" target is pretty unstable with rust 
tests. Thus, we decided unanimously to skip mips(32 bits) target in the 
initial implementation of the rust oe-selftest. I did check the 
testsuite for the mips target and many more failures were found.

According to the rust doc, the mips target variants are classified into 
tier 3 targets( for which the Rust codebase has support for, but which 
the Rust project does not build or test automatically, so they may or 
may not work. 
<https://doc.rust-lang.org/nightly/rustc/platform-support.html#:~:text=Tier%203%20targets%20are%20those%20which%20the%20Rust%20codebase%20has%20support%20for%2C%20but%20which%20the%20Rust%20project%20does%20not%20build%20or%20test%20automatically%2C%20so%20they%20may%20or%20may%20not%20work.>), 
which might be the reason for failures.

https://doc.rust-lang.org/nightly/rustc/platform-support.html#tier-3:~:text=mips%2Dunknown%2Dlinux%2Dgnu,kernel%204.4%2C%20glibc%202.23)


<https://doc.rust-lang.org/nightly/rustc/platform-support.html#tier-3:~:text=mips%2Dunknown%2Dlinux%2Dgnu,kernel%204.4%2C%20glibc%202.23)>Regards,
Yash

>
> Cheers,
>
> Richard

[-- Attachment #2: Type: text/html, Size: 4797 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v2 1/5] rust: Fetch cargo from rust-snapshot dir.
  2024-01-19 15:09 [PATCH v2 1/5] rust: Fetch cargo from rust-snapshot dir Yash.Shinde
                   ` (5 preceding siblings ...)
       [not found] ` <17AC01A476481111.16230@lists.openembedded.org>
@ 2024-01-20 17:03 ` Randy MacLeod
  2024-01-22 10:58   ` Yash Shinde
  6 siblings, 1 reply; 13+ messages in thread
From: Randy MacLeod @ 2024-01-20 17:03 UTC (permalink / raw)
  To: Yash.Shinde, openembedded-core
  Cc: Umesh.Kallapa, Naveen.Gowda, Sundeep.Kokkonda,
	Shivaprasad.Moodalappa

[-- Attachment #1: Type: text/plain, Size: 3318 bytes --]

On 2024-01-19 10:09 a.m., Yash.Shinde@windriver.com wrote:
> From: Yash Shinde<Yash.Shinde@windriver.com>
>
> Fixes: Exception: no cargo executable found at
>         `${B}/rustc-1.74.1-src/build/x86_64-unknown-linux-gnu/stage0/bin/cargo`
>
> Fix the cargo binary path error on oe-selftest and path set to rust-snapshot dir.
>
> Patch sent to upstream-https://github.com/rust-lang/rust/pull/120125


Good!

It's a bit worrying that the PR pipeline failed a number of tests.
Do you want to revise that and push a new commit there and do a v3 here?

../Randy

>
> Signed-off-by: Yash Shinde<Yash.Shinde@windriver.com>
> ---
>   .../rust/files/cargo-path.patch               | 37 +++++++++++++++++++
>   1 file changed, 37 insertions(+)
>   create mode 100644 meta/recipes-devtools/rust/files/cargo-path.patch
>
> diff --git a/meta/recipes-devtools/rust/files/cargo-path.patch b/meta/recipes-devtools/rust/files/cargo-path.patch
> new file mode 100644
> index 0000000000..547df353d2
> --- /dev/null
> +++ b/meta/recipes-devtools/rust/files/cargo-path.patch
> @@ -0,0 +1,37 @@
> +Fix the cargo binary path error and ensure that it is fetched
> +during rustc bootstrap in rust oe-selftest.
> +
> +======================================================================
> +ERROR: test_cargoflags (bootstrap_test.BuildBootstrap)
> +----------------------------------------------------------------------
> +Traceback (most recent call last):
> +  File "/home/build-st/tmp/work/cortexa57-poky-linux/rust/1.74.1/rustc-1.74.1-src/src/bootstrap/bootstrap_test.py", line 157, in test_cargoflags
> +    args, _ = self.build_args(env={"CARGOFLAGS": "--timings"})
> +  File "/home/build-st/tmp/work/cortexa57-poky-linux/rust/1.74.1/rustc-1.74.1-src/src/bootstrap/bootstrap_test.py", line 154, in build_args
> +    return build.build_bootstrap_cmd(env), env
> +  File "/home/build-st/tmp/work/cortexa57-poky-linux/rust/1.74.1/rustc-1.74.1-src/src/bootstrap/bootstrap.py", line 960, in build_bootstrap_cmd
> +    raise Exception("no cargo executable found at `{}`".format(
> +Exception: no cargo executable found at `/home/build-st/tmp/work/cortexa57-poky-linux/rust/1.74.1/rustc-1.74.1-src/build/x86_64-unknown-linux-gnu/stage0/bin/cargo`
> +
> +Upstream-Status: Submitted [https://github.com/rust-lang/rust/pull/120125]
> +
> +Signed-off-by: Yash Shinde<Yash.Shinde@windriver.com>
> +---
> +diff --git a/src/bootstrap/bootstrap.py b/src/bootstrap/bootstrap.py
> +--- a/src/bootstrap/bootstrap.py
> ++++ b/src/bootstrap/bootstrap.py
> +@@ -954,9 +954,11 @@
> +         if deny_warnings:
> +             env["RUSTFLAGS"] += " -Dwarnings"
> +
> +-        env["PATH"] = os.path.join(self.bin_root(), "bin") + \
> +-            os.pathsep + env["PATH"]
> +-        if not os.path.isfile(self.cargo()):
> ++        cargo_bin_path = os.path.join(self.bin_root(), "bin", "cargo")
> ++        if not os.path.isfile(cargo_bin_path):
> ++            cargo_bin_path = os.getenv("RUST_TARGET_PATH") + "rust-snapshot/bin/cargo"
> ++            env["PATH"] = os.path.dirname(cargo_bin_path) + os.pathsep + env["PATH"]
> ++        else:
> +             raise Exception("no cargo executable found at `{}`".format(
> +                 self.cargo()))
> +         args = [self.cargo(), "build", "--manifest-path",


-- 
# Randy MacLeod
# Wind River Linux

[-- Attachment #2: Type: text/html, Size: 4574 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v2 1/5] rust: Fetch cargo from rust-snapshot dir.
  2024-01-20 17:03 ` Randy MacLeod
@ 2024-01-22 10:58   ` Yash Shinde
  0 siblings, 0 replies; 13+ messages in thread
From: Yash Shinde @ 2024-01-22 10:58 UTC (permalink / raw)
  To: Randy MacLeod, openembedded-core
  Cc: Umesh.Kallapa, Naveen.Gowda, Sundeep.Kokkonda,
	Shivaprasad.Moodalappa


On 20-01-2024 22:33, Randy MacLeod wrote:
> On 2024-01-19 10:09 a.m., Yash.Shinde@windriver.com wrote:
>> From: Yash Shinde<Yash.Shinde@windriver.com>
>>
>> Fixes: Exception: no cargo executable found at
>>         `${B}/rustc-1.74.1-src/build/x86_64-unknown-linux-gnu/stage0/bin/cargo`
>>
>> Fix the cargo binary path error on oe-selftest and path set to rust-snapshot dir.
>>
>> Patch sent to upstream-https://github.com/rust-lang/rust/pull/120125
>
>
> Good!
>
> It's a bit worrying that the PR pipeline failed a number of tests.
> Do you want to revise that and push a new commit there and do a v3 here?
>
I will look into the failure in the PR but for now we need this patch 
for rust oe-selftest in Yocto.

Regards,
Yash
>
> ../Randy
>
>> Signed-off-by: Yash Shinde<Yash.Shinde@windriver.com>
>> ---
>>   .../rust/files/cargo-path.patch               | 37 +++++++++++++++++++
>>   1 file changed, 37 insertions(+)
>>   create mode 100644 meta/recipes-devtools/rust/files/cargo-path.patch
>>
>> diff --git a/meta/recipes-devtools/rust/files/cargo-path.patch b/meta/recipes-devtools/rust/files/cargo-path.patch
>> new file mode 100644
>> index 0000000000..547df353d2
>> --- /dev/null
>> +++ b/meta/recipes-devtools/rust/files/cargo-path.patch
>> @@ -0,0 +1,37 @@
>> +Fix the cargo binary path error and ensure that it is fetched
>> +during rustc bootstrap in rust oe-selftest.
>> +
>> +======================================================================
>> +ERROR: test_cargoflags (bootstrap_test.BuildBootstrap)
>> +----------------------------------------------------------------------
>> +Traceback (most recent call last):
>> +  File "/home/build-st/tmp/work/cortexa57-poky-linux/rust/1.74.1/rustc-1.74.1-src/src/bootstrap/bootstrap_test.py", line 157, in test_cargoflags
>> +    args, _ = self.build_args(env={"CARGOFLAGS": "--timings"})
>> +  File "/home/build-st/tmp/work/cortexa57-poky-linux/rust/1.74.1/rustc-1.74.1-src/src/bootstrap/bootstrap_test.py", line 154, in build_args
>> +    return build.build_bootstrap_cmd(env), env
>> +  File "/home/build-st/tmp/work/cortexa57-poky-linux/rust/1.74.1/rustc-1.74.1-src/src/bootstrap/bootstrap.py", line 960, in build_bootstrap_cmd
>> +    raise Exception("no cargo executable found at `{}`".format(
>> +Exception: no cargo executable found at `/home/build-st/tmp/work/cortexa57-poky-linux/rust/1.74.1/rustc-1.74.1-src/build/x86_64-unknown-linux-gnu/stage0/bin/cargo`
>> +
>> +Upstream-Status: Submitted [https://github.com/rust-lang/rust/pull/120125]
>> +
>> +Signed-off-by: Yash Shinde<Yash.Shinde@windriver.com>
>> +---
>> +diff --git a/src/bootstrap/bootstrap.py b/src/bootstrap/bootstrap.py
>> +--- a/src/bootstrap/bootstrap.py
>> ++++ b/src/bootstrap/bootstrap.py
>> +@@ -954,9 +954,11 @@
>> +         if deny_warnings:
>> +             env["RUSTFLAGS"] += " -Dwarnings"
>> +
>> +-        env["PATH"] = os.path.join(self.bin_root(), "bin") + \
>> +-            os.pathsep + env["PATH"]
>> +-        if not os.path.isfile(self.cargo()):
>> ++        cargo_bin_path = os.path.join(self.bin_root(), "bin", "cargo")
>> ++        if not os.path.isfile(cargo_bin_path):
>> ++            cargo_bin_path = os.getenv("RUST_TARGET_PATH") + "rust-snapshot/bin/cargo"
>> ++            env["PATH"] = os.path.dirname(cargo_bin_path) + os.pathsep + env["PATH"]
>> ++        else:
>> +             raise Exception("no cargo executable found at `{}`".format(
>> +                 self.cargo()))
>> +         args = [self.cargo(), "build", "--manifest-path",
>
>
> -- 
> # Randy MacLeod
> # Wind River Linux


^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2024-01-22 11:01 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-19 15:09 [PATCH v2 1/5] rust: Fetch cargo from rust-snapshot dir Yash.Shinde
2024-01-19 15:09 ` [PATCH v2 2/5] rust: detect user-specified custom targets in compiletest Yash.Shinde
2024-01-19 15:09 ` [PATCH v2 3/5] rust: Enable RUSTC_BOOTSTRAP to use nightly features during rust oe-selftest Yash.Shinde
2024-01-19 15:09 ` [PATCH v2 4/5] rust: Fix assertion failure error on oe-selftest Yash.Shinde
2024-01-19 15:09 ` [PATCH v2 5/5] rust: Enable rust oe-selftest Yash.Shinde
2024-01-20 17:01   ` Randy MacLeod
2024-01-22 10:59     ` Yash Shinde
2024-01-22 11:01       ` Shinde, Yash
2024-01-20  8:42 ` [OE-core] [PATCH v2 1/5] rust: Fetch cargo from rust-snapshot dir Richard Purdie
     [not found] ` <17AC01A476481111.16230@lists.openembedded.org>
2024-01-20  8:49   ` Richard Purdie
2024-01-20 10:46     ` Yash Shinde
2024-01-20 17:03 ` Randy MacLeod
2024-01-22 10:58   ` Yash Shinde

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox