From: Jacob Kroon <jacob.kroon@gmail.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: Richard Purdie <richard.purdie@linuxfoundation.org>,
Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>,
Alexander Kanavin <alex.kanavin@gmail.com>
Subject: Re: [OE-core] [hardknott][PATCH] mklibs: remove recipes and class
Date: Mon, 15 Nov 2021 08:04:18 +0100 [thread overview]
Message-ID: <0873075c-6a8d-e986-9f16-be3eb81b8cc9@gmail.com> (raw)
In-Reply-To: <CAMKF1som8UK6MYYj7RAPs0ai9JZL6kY8GDam-d_67xGEPOnkpQ@mail.gmail.com>
On 11/15/21 01:59, Khem Raj wrote:
> On Sun, Nov 14, 2021 at 11:47 AM Jacob Kroon <jacob.kroon@gmail.com> wrote:
>>
>> On 11/14/21 20:36, Richard Purdie wrote:
>>> On Sun, 2021-11-14 at 07:50 +0100, Jacob Kroon wrote:
>>>> From: Alexander Kanavin <alex.kanavin@gmail.com>
>>>>
>>>> This is not enabled or tested by default, and has never been
>>>> ported to python 3 upstream[1], which means it doesn't work at all
>>>> with plain poky. If you need it, please put it in a separate layer
>>>> and/or modernize to work with py3.
>>>>
>>>> https://salsa.debian.org/installer-team/mklibs/-/blob/master/src/mklibs
>>>>
>>>> Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
>>>> Signed-off-by: Jacob Kroon <jacob.kroon@gmail.com>
>>>> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>>>> (cherry picked from commit 908df863b419d1cad7317153101fc827e7e3a354)
>>>
>>> What issue is it causing in hardknott? Normally we don't backport invasive
>>> changes like that...
>>>
>>
>> The problem is that mklibs-native doesn't build with gcc 11, and
>> "image-mklibs" was in USER_CLASSES by default in hardknott.
>>
>> I sent a patch to fix mklibs build here:
>>
>> https://lists.openembedded.org/g/openembedded-core/message/151982
>
> This fix is correct and it is trivial. We can apply it
>
>>
>> but after some discussions we just decided to drop mklibs support
>> entirely with the proposed patch.
>
> Was there any other reason ?
>
To have it successfully build (with mklibs actually enabled by putting
your image in MKLIBS_OPTIMIZED_IMAGES) would require additional fixes,
including updating mklibs to python3 I believe.
/Jacob
next prev parent reply other threads:[~2021-11-15 7:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-14 6:50 [hardknott][PATCH] mklibs: remove recipes and class Jacob Kroon
2021-11-14 19:36 ` Richard Purdie
2021-11-14 19:47 ` Jacob Kroon
2021-11-14 19:51 ` Richard Purdie
2021-11-14 19:58 ` Jacob Kroon
2021-11-15 0:59 ` [OE-core] " Khem Raj
2021-11-15 7:04 ` Jacob Kroon [this message]
[not found] <1695D4F0B9337557.29235@lists.openembedded.org>
2021-07-28 2:57 ` Changqing Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0873075c-6a8d-e986-9f16-be3eb81b8cc9@gmail.com \
--to=jacob.kroon@gmail.com \
--cc=alex.kanavin@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=raj.khem@gmail.com \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox