Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Jacob Kroon <jacob.kroon@gmail.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
	openembedded-core@lists.openembedded.org
Cc: Alexander Kanavin <alex.kanavin@gmail.com>
Subject: Re: [hardknott][PATCH] mklibs: remove recipes and class
Date: Sun, 14 Nov 2021 20:58:31 +0100	[thread overview]
Message-ID: <ada55396-37c7-5c35-433a-71c98b319c14@gmail.com> (raw)
In-Reply-To: <24dd6bb7c3d4bb755281b3697ed18c7116a5d101.camel@linuxfoundation.org>

On 11/14/21 20:51, Richard Purdie wrote:
> On Sun, 2021-11-14 at 20:47 +0100, Jacob Kroon wrote:
>> On 11/14/21 20:36, Richard Purdie wrote:
>>> On Sun, 2021-11-14 at 07:50 +0100, Jacob Kroon wrote:
>>>> From: Alexander Kanavin <alex.kanavin@gmail.com>
>>>>
>>>> This is not enabled or tested by default, and has never been
>>>> ported to python 3 upstream[1], which means it doesn't work at all
>>>> with plain poky. If you need it, please put it in a separate layer
>>>> and/or modernize to work with py3.
>>>>
>>>> https://salsa.debian.org/installer-team/mklibs/-/blob/master/src/mklibs
>>>>
>>>> Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
>>>> Signed-off-by: Jacob Kroon <jacob.kroon@gmail.com>
>>>> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>>>> (cherry picked from commit 908df863b419d1cad7317153101fc827e7e3a354)
>>>
>>> What issue is it causing in hardknott? Normally we don't backport invasive
>>> changes like that...
>>>
>>
>> The problem is that mklibs-native doesn't build with gcc 11, and
>> "image-mklibs" was in USER_CLASSES by default in hardknott.
>>
>> I sent a patch to fix mklibs build here:
>>
>> https://lists.openembedded.org/g/openembedded-core/message/151982
>>
>> but after some discussions we just decided to drop mklibs support
>> entirely with the proposed patch.
> 
> ok, that is something we should fix. My worry is that the backport as is will
> need everyone to update their local.conf since the class will no longer be there
> and it will throw errors if people try and include it. This isn't what people
> expect from a point release.
> 
> Could we just remove it from local.conf in hardknott? That should solve the
> issue but reduce risk to anyone who has hardknott already working fine with an
> older gcc.
> 

Yeah I'm ok with that, I'm even ok with leaving it as it is :-)

Or perhaps we should forward-port

ef8b7946b4793db653ef7dd716e1d3f919a84725

in dunfell branch to hardknott, which also should take care of it.

/Jacob


  reply	other threads:[~2021-11-14 19:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-14  6:50 [hardknott][PATCH] mklibs: remove recipes and class Jacob Kroon
2021-11-14 19:36 ` Richard Purdie
2021-11-14 19:47   ` Jacob Kroon
2021-11-14 19:51     ` Richard Purdie
2021-11-14 19:58       ` Jacob Kroon [this message]
2021-11-15  0:59     ` [OE-core] " Khem Raj
2021-11-15  7:04       ` Jacob Kroon
  -- strict thread matches above, loose matches on Subject: below --
2021-07-28  2:54 Changqing Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ada55396-37c7-5c35-433a-71c98b319c14@gmail.com \
    --to=jacob.kroon@gmail.com \
    --cc=alex.kanavin@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox