Openembedded Core Discussions
 help / color / mirror / Atom feed
* [pyro][PATCH] autogen-native: Set POSIX_SHELL to /bin/sh
@ 2017-06-19 11:48 Gabriel Ionescu
  2017-06-19 14:19 ` Burton, Ross
  0 siblings, 1 reply; 4+ messages in thread
From: Gabriel Ionescu @ 2017-06-19 11:48 UTC (permalink / raw)
  To: openembedded-core

Setting POSIX_SHELL to "/usr/bin/env sh" fails when tested in
libopts.m4 with test -x "$POSIX_SHELL", because test -x needs
a file as an argument (e.g. test -x FILE).

Due to the above failure, the build system will use a shell available
in tmp/hosttools, which can generate shebang lines longer than 128.

This patch sets the POSIX_SHELL variable to "/bin/sh".

Signed-off-by: Gabriel Ionescu <gabriel.ionescu@enea.com>
---
 meta/recipes-devtools/autogen/autogen-native_5.18.12.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/autogen/autogen-native_5.18.12.bb b/meta/recipes-devtools/autogen/autogen-native_5.18.12.bb
index 853477c..9be03fc 100644
--- a/meta/recipes-devtools/autogen/autogen-native_5.18.12.bb
+++ b/meta/recipes-devtools/autogen/autogen-native_5.18.12.bb
@@ -31,7 +31,7 @@ inherit autotools texinfo native pkgconfig
 export GUILE_LOAD_PATH = "${STAGING_DATADIR_NATIVE}/guile/2.0"
 export GUILE_LOAD_COMPILED_PATH = "${STAGING_LIBDIR_NATIVE}/guile/2.0/ccache"

-export POSIX_SHELL = "/usr/bin/env sh"
+export POSIX_SHELL = "/bin/sh"

 do_install_append () {
 	create_wrapper ${D}/${bindir}/autogen \
--
2.7.4



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [pyro][PATCH] autogen-native: Set POSIX_SHELL to /bin/sh
  2017-06-19 11:48 [pyro][PATCH] autogen-native: Set POSIX_SHELL to /bin/sh Gabriel Ionescu
@ 2017-06-19 14:19 ` Burton, Ross
  2017-06-19 14:21   ` Alexander Kanavin
  0 siblings, 1 reply; 4+ messages in thread
From: Burton, Ross @ 2017-06-19 14:19 UTC (permalink / raw)
  To: Gabriel Ionescu; +Cc: OE-core

[-- Attachment #1: Type: text/plain, Size: 1589 bytes --]

Why pyro and not master?

Ross

On 19 June 2017 at 12:48, Gabriel Ionescu <gabriel.ionescu@enea.com> wrote:

> Setting POSIX_SHELL to "/usr/bin/env sh" fails when tested in
> libopts.m4 with test -x "$POSIX_SHELL", because test -x needs
> a file as an argument (e.g. test -x FILE).
>
> Due to the above failure, the build system will use a shell available
> in tmp/hosttools, which can generate shebang lines longer than 128.
>
> This patch sets the POSIX_SHELL variable to "/bin/sh".
>
> Signed-off-by: Gabriel Ionescu <gabriel.ionescu@enea.com>
> ---
>  meta/recipes-devtools/autogen/autogen-native_5.18.12.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/autogen/autogen-native_5.18.12.bb
> b/meta/recipes-devtools/autogen/autogen-native_5.18.12.bb
> index 853477c..9be03fc 100644
> --- a/meta/recipes-devtools/autogen/autogen-native_5.18.12.bb
> +++ b/meta/recipes-devtools/autogen/autogen-native_5.18.12.bb
> @@ -31,7 +31,7 @@ inherit autotools texinfo native pkgconfig
>  export GUILE_LOAD_PATH = "${STAGING_DATADIR_NATIVE}/guile/2.0"
>  export GUILE_LOAD_COMPILED_PATH = "${STAGING_LIBDIR_NATIVE}/
> guile/2.0/ccache"
>
> -export POSIX_SHELL = "/usr/bin/env sh"
> +export POSIX_SHELL = "/bin/sh"
>
>  do_install_append () {
>         create_wrapper ${D}/${bindir}/autogen \
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 2810 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [pyro][PATCH] autogen-native: Set POSIX_SHELL to /bin/sh
  2017-06-19 14:19 ` Burton, Ross
@ 2017-06-19 14:21   ` Alexander Kanavin
  2017-06-19 14:28     ` Burton, Ross
  0 siblings, 1 reply; 4+ messages in thread
From: Alexander Kanavin @ 2017-06-19 14:21 UTC (permalink / raw)
  To: Burton, Ross, Gabriel Ionescu; +Cc: OE-core

On 06/19/2017 05:19 PM, Burton, Ross wrote:
> Why pyro and not master?

I sent a patch to remove autogen from master the other day :)

Alex



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [pyro][PATCH] autogen-native: Set POSIX_SHELL to /bin/sh
  2017-06-19 14:21   ` Alexander Kanavin
@ 2017-06-19 14:28     ` Burton, Ross
  0 siblings, 0 replies; 4+ messages in thread
From: Burton, Ross @ 2017-06-19 14:28 UTC (permalink / raw)
  To: Alexander Kanavin; +Cc: OE-core

[-- Attachment #1: Type: text/plain, Size: 200 bytes --]

On 19 June 2017 at 15:21, Alexander Kanavin <
alexander.kanavin@linux.intel.com> wrote:

> I sent a patch to remove autogen from master the other day :)
>

Yeah that's a good reason ;)

Ross

[-- Attachment #2: Type: text/html, Size: 622 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-06-19 14:28 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-19 11:48 [pyro][PATCH] autogen-native: Set POSIX_SHELL to /bin/sh Gabriel Ionescu
2017-06-19 14:19 ` Burton, Ross
2017-06-19 14:21   ` Alexander Kanavin
2017-06-19 14:28     ` Burton, Ross

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox