From: Kang Kai <Kai.Kang@windriver.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] webkitgtk: fix compile error for arm64
Date: Tue, 14 May 2019 11:41:01 +0800 [thread overview]
Message-ID: <0dad34dc-9c84-0320-e03c-db58a4943482@windriver.com> (raw)
In-Reply-To: <CAMKF1spxtnvC4VvwbecRijr=_H7pKDzFzQ3vj7PnBytUAByGRA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2618 bytes --]
On 2019/5/13 下午11:43, Khem Raj wrote:
> Can you test this on say rpi3 in 64bit mode and see all is ok ?
It is ok to build 64-bit rpi3 from layer
git://git.yoctoproject.org/meta-raspberrypi
with configurations:
MACHINE = "raspberrypi3-64"
LICENSE_FLAGS_WHITELIST_append = " commercial"
Regards,
Kai
>
> On Mon, May 13, 2019 at 2:53 AM <kai.kang@windriver.com
> <mailto:kai.kang@windriver.com>> wrote:
>
> From: Kai Kang <kai.kang@windriver.com
> <mailto:kai.kang@windriver.com>>
>
> It removes function JSC::AssemblerBuffer::data() for ARM64 in commit
> https://trac.webkit.org/changeset/236589/webkit. But the function is
> still required by Cortex A53 and fails to compile for arm64:
>
> |
> .../tmp/work/aarch64-poky-linux/webkitgtk/2.24.1-r0/webkitgtk-2.24.1/Source/JavaScriptCore/assembler/ARM64Assembler.h:3769:100:
> error: 'class JSC::AssemblerBuffer' has no member named 'data'
> | if
> (UNLIKELY((*reinterpret_cast_ptr<int32_t*>(reinterpret_cast_ptr<char*>(m_buffer.data())
> + m_buffer.codeSize() - sizeof(int32_t)) & 0x0a000000) == 0x08000000))
>
> Not set WTF_CPU_ARM64_CORTEXA53 for arm64 to fix the failure.
>
> Signed-off-by: Kai Kang <kai.kang@windriver.com
> <mailto:kai.kang@windriver.com>>
> ---
> meta/recipes-sato/webkit/webkitgtk_2.24.1.bb
> <http://webkitgtk_2.24.1.bb> | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/meta/recipes-sato/webkit/webkitgtk_2.24.1.bb
> <http://webkitgtk_2.24.1.bb>
> b/meta/recipes-sato/webkit/webkitgtk_2.24.1.bb
> <http://webkitgtk_2.24.1.bb>
> index 771a893a6b..a57a3c058c 100644
> --- a/meta/recipes-sato/webkit/webkitgtk_2.24.1.bb
> <http://webkitgtk_2.24.1.bb>
> +++ b/meta/recipes-sato/webkit/webkitgtk_2.24.1.bb
> <http://webkitgtk_2.24.1.bb>
> @@ -98,8 +98,6 @@ EXTRA_OECMAKE_append_aarch64 = " -DUSE_LD_GOLD=OFF "
> EXTRA_OECMAKE_append_mipsarch = " -DUSE_LD_GOLD=OFF "
> EXTRA_OECMAKE_append_powerpc = " -DUSE_LD_GOLD=OFF "
>
> -EXTRA_OECMAKE_append_aarch64 = " -DWTF_CPU_ARM64_CORTEXA53=ON"
> -
> # JIT not supported on MIPS either
> EXTRA_OECMAKE_append_mipsarch = " -DENABLE_JIT=OFF "
>
> --
> 2.20.0
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> <mailto:Openembedded-core@lists.openembedded.org>
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
--
Kai Kang
[-- Attachment #2: Type: text/html, Size: 5490 bytes --]
prev parent reply other threads:[~2019-05-14 3:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-13 9:52 [PATCH 0/1] Rebased - webkitgtk: fix compile error for arm64 kai.kang
2019-05-13 9:52 ` [PATCH 1/1] " kai.kang
2019-05-13 15:43 ` Khem Raj
2019-05-14 3:41 ` Kang Kai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0dad34dc-9c84-0320-e03c-db58a4943482@windriver.com \
--to=kai.kang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox