Re: [PATCH] patch for bug #12814

Re: [PATCH] patch for bug #12814

[Burton, Ross]

Please rewrite the commit message to follow the guidelines in
https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#New_Development.
The bug  reference is correct but should be at the end before your
SOB.  Something like:

python: fix contents of python-xmlrpc package

Add missing files etc etc.

[ YOCTO #1234 ]

Signed-off-by: Foo Bar <foo@bar>

Also the patch needs rebasing onto master, the manifest was
reformatted since your patch was created.

Thanks,
Ross
On Mon, 12 Nov 2018 at 06:59, Mikhail Vanyulin <mvanyulin@dev.rtsoft.ru> wrote:
>
> Adds a missing file to python-xmlrpc package.
>
> --
> Best regards, / С уважением,
> Mikhail       / Михаил
>
>

Re: [PATCH] patch for bug #12814

[Mikhail Vanyulin]

[-- Attachment #1: Type: text/plain, Size: 1153 bytes --]

Resending email as "This mailinglist requires people to subscribe before 
posting. "

Best regards, / С уважением,
Mikhail       / Михаил

On 11/13/2018 04:38 PM, Mikhail Vanyulin wrote:
> Should be ok now.
>
> Best regards, / С уважением,
> Mikhail       / Михаил
>
> On 11/12/2018 01:29 PM, Burton, Ross wrote:
>> Please rewrite the commit message to follow the guidelines in
>> https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#New_Development. 
>>
>> The bug  reference is correct but should be at the end before your
>> SOB.  Something like:
>>
>> python: fix contents of python-xmlrpc package
>>
>> Add missing files etc etc.
>>
>> [ YOCTO #1234 ]
>>
>> Signed-off-by: Foo Bar <foo@bar>
>>
>> Also the patch needs rebasing onto master, the manifest was
>> reformatted since your patch was created.
>>
>> Thanks,
>> Ross
>> On Mon, 12 Nov 2018 at 06:59, Mikhail Vanyulin 
>> <mvanyulin@dev.rtsoft.ru> wrote:
>>> Adds a missing file to python-xmlrpc package.
>>>
>>> -- 
>>> Best regards, / С уважением,
>>> Mikhail       / Михаил
>>>
>>>
>


[-- Attachment #2: 0001-python-fix-contents-of-python-xmlrpc-package.patch --]
[-- Type: text/x-patch, Size: 1164 bytes --]

From 2b840184cb4dd99913baa96ef6040c08605e71cc Mon Sep 17 00:00:00 2001
From: mvanyulin <mvanyulin@dev.rtsoft.ru>
Date: Tue, 13 Nov 2018 17:27:16 +0400
Subject: [PATCH] python: fix contents of python-xmlrpc package

Add a missed xmlrpclib.py to python-xmlrpc package.

[ YOCTO #12814 ] -- https://bugzilla.yoctoproject.org/show_bug.cgi?id=12814

Signed-off-by: Mikhail Vanyulin <mvanyulin@dev.rtsoft.ru>
---
 meta/recipes-devtools/python/python/python2-manifest.json | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/python/python/python2-manifest.json b/meta/recipes-devtools/python/python/python2-manifest.json
index 260fa6f..95e639c 100644
--- a/meta/recipes-devtools/python/python/python2-manifest.json
+++ b/meta/recipes-devtools/python/python/python2-manifest.json
@@ -1031,7 +1031,8 @@
         ], 
         "files": [
             "${libdir}/python2.7/DocXMLRPCServer.py", 
-            "${libdir}/python2.7/SimpleXMLRPCServer.py"
+            "${libdir}/python2.7/SimpleXMLRPCServer.py", 
+            "${libdir}/python2.7/xmlrpclib.py"
         ]
     }, 
     "zlib": {
-- 
1.9.1