From: Phil Blundell <pb@pbcl.net>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] image-prelink: remove hardcoded reference to /usr/sbin
Date: Tue, 17 May 2011 13:09:24 +0100 [thread overview]
Message-ID: <1305634164.2429.193.camel@phil-desktop> (raw)
In-Reply-To: <1305633770.3424.229.camel@rex>
On Tue, 2011-05-17 at 13:02 +0100, Richard Purdie wrote:
> On Tue, 2011-05-17 at 12:51 +0100, Phil Blundell wrote:
> > ---
> > meta/classes/image-prelink.bbclass | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/meta/classes/image-prelink.bbclass b/meta/classes/image-prelink.bbclass
> > index ee0951c..cefd983 100644
> > --- a/meta/classes/image-prelink.bbclass
> > +++ b/meta/classes/image-prelink.bbclass
> > @@ -21,7 +21,7 @@ prelink_image () {
> > fi
> >
> > # prelink!
> > - ${STAGING_DIR_NATIVE}/usr/sbin/prelink --root ${IMAGE_ROOTFS} -amR
> > + ${STAGING_DIR_NATIVE}${sbindir}/prelink --root ${IMAGE_ROOTFS} -amR
> >
> > # Remove the prelink.conf if we had to add it.
> > if [ "$dummy_prelink_conf" == "true" ]; then
>
> I suspect this should be ${sbindir_native} there?
Ah yes, I guess it should. I'll verify that that works and send a new
patch later.
On a similar subject, image-prelink also seems to assume that
${sysconfdir} == ${sysconfdir_native} == "/etc". That isn't actually
causing me a problem at the moment, because the assumption does happen
to hold for my configuration, but I guess it could do with fixing at
some point.
p.
next prev parent reply other threads:[~2011-05-17 12:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 11:51 [PATCH] image-prelink: remove hardcoded reference to /usr/sbin Phil Blundell
2011-05-17 12:02 ` Richard Purdie
2011-05-17 12:09 ` Phil Blundell [this message]
2011-05-17 14:17 ` [PATCH v2] image-prelink: remove hardcoded path assumptions Phil Blundell
2011-05-17 14:35 ` Richard Purdie
2011-05-17 14:45 ` Mark Hatle
2011-05-17 14:47 ` Phil Blundell
2011-05-17 15:17 ` Richard Purdie
2011-05-17 15:52 ` [PATCH v3] image-prelink: remove hardcoded path assumptions, don't generate cache file Phil Blundell
2011-05-17 16:07 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305634164.2429.193.camel@phil-desktop \
--to=pb@pbcl.net \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox