From: Mark Hatle <mark.hatle@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v2] image-prelink: remove hardcoded path assumptions
Date: Tue, 17 May 2011 09:45:37 -0500 [thread overview]
Message-ID: <4DD28A11.6080003@windriver.com> (raw)
In-Reply-To: <1305642925.3424.251.camel@rex>
On 5/17/11 9:35 AM, Richard Purdie wrote:
> On Tue, 2011-05-17 at 15:17 +0100, Phil Blundell wrote:
>> Signed-off-by: Phil Blundell <philb@gnu.org>
>> ---
>> meta/classes/image-prelink.bbclass | 13 +++++--------
>> 1 files changed, 5 insertions(+), 8 deletions(-)
>>
>> diff --git a/meta/classes/image-prelink.bbclass b/meta/classes/image-prelink.bbclass
>> index ee0951c..350c29d 100644
>> --- a/meta/classes/image-prelink.bbclass
>> +++ b/meta/classes/image-prelink.bbclass
...
>> # prelink!
>> - ${STAGING_DIR_NATIVE}/usr/sbin/prelink --root ${IMAGE_ROOTFS} -amR
>> + ${STAGING_DIR_NATIVE}${sbindir_native}/prelink --root ${IMAGE_ROOTFS} -amR -N -c ${sysconfdir}/prelink.conf
...
>>
>> - # Cleanup temporary file, it's not needed...
>> - rm -f ${IMAGE_ROOTFS}/etc/prelink.cache
>> -
>
> The patch description and what it does don't quite match (the rm is
> removed and options are added to prelink).
I agree the commit message needs some more description. Just as an FYI. The -N
option causes the prelinker to not generate/save the cache file. While the -c
tells it to read a specific .conf file.
So the actual code changes are good, the description is the only thing that
needs to be improved, so someone not familiar with the prelinker can understand
the change.
--Mark
> Cheers,
>
> Richard
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
next prev parent reply other threads:[~2011-05-17 14:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 11:51 [PATCH] image-prelink: remove hardcoded reference to /usr/sbin Phil Blundell
2011-05-17 12:02 ` Richard Purdie
2011-05-17 12:09 ` Phil Blundell
2011-05-17 14:17 ` [PATCH v2] image-prelink: remove hardcoded path assumptions Phil Blundell
2011-05-17 14:35 ` Richard Purdie
2011-05-17 14:45 ` Mark Hatle [this message]
2011-05-17 14:47 ` Phil Blundell
2011-05-17 15:17 ` Richard Purdie
2011-05-17 15:52 ` [PATCH v3] image-prelink: remove hardcoded path assumptions, don't generate cache file Phil Blundell
2011-05-17 16:07 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD28A11.6080003@windriver.com \
--to=mark.hatle@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox