Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [pull-oe-uboot 1/2] u-boot: remove UBOOT_MACHINE and COMPATIBLE_MACHINES
Date: Thu, 26 May 2011 15:37:59 +0100	[thread overview]
Message-ID: <1306420679.27470.186.camel@rex> (raw)
In-Reply-To: <1306407015.2525.311.camel@phil-desktop>

On Thu, 2011-05-26 at 11:50 +0100, Phil Blundell wrote:
> On Wed, 2011-05-25 at 22:02 -0700, Darren Hart wrote:
> > COMPATIBLE_MACHINES is not easily extended due to
> > its regex syntax: "(machine_a|machine_b)", making it difficult to extend the
> > u-boot recipe in bbappend files without resorting to machine specific overrides.
> 
> Not that I have an objection to your patch, but I think this remark
> about COMPATIBLE_MACHINE is wrong.  AFAIK, you can disregard the
> parenthesis and just splice extra alternates on the end, viz:
> 
> COMPATIBLE_MACHINE_append = "|mymachine"
>
> so there oughtn't to be any reason, in general, for .bbappends to have a
> hard time extending that field.

u-boot in OE-Core would need something like COMPATIBLE_MACHINE = ""
which makes this harder.

Its usually seem to work out easier to just do:

COMPATIBLE_MACHINE_mymachine = "mymachine"

which avoids several potential issues.

Cheers,

Richard




  reply	other threads:[~2011-05-26 14:41 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-26  5:01 [PATCH 0/2] u-boot updates to make it more bbappend friendly Darren Hart
2011-05-26  5:02 ` [pull-oe-uboot 1/2] u-boot: remove UBOOT_MACHINE and COMPATIBLE_MACHINES Darren Hart
2011-05-26  7:47   ` Jason Kridner
2011-05-26 13:50     ` Darren Hart
2011-05-26 14:08       ` Chris Larson
2011-05-26 10:50   ` Phil Blundell
2011-05-26 14:37     ` Richard Purdie [this message]
2011-05-26 16:18       ` Phil Blundell
2011-05-26 17:46         ` Darren Hart
2011-05-27 14:04           ` Phil Blundell
2011-05-27 15:06             ` Darren Hart
2011-05-27 15:11               ` Phil Blundell
2011-05-26  5:02 ` [pull-oe-uboot 2/2] u-boot: rename u-boot_git.bb to u-boot_${PV}.bb Darren Hart
2011-05-26  7:58   ` Jason Kridner
2011-05-26 13:52     ` Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1306420679.27470.186.camel@rex \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox