From: Darren Hart <dvhart@linux.intel.com>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [pull-oe-uboot 1/2] u-boot: remove UBOOT_MACHINE and COMPATIBLE_MACHINES
Date: Thu, 26 May 2011 10:46:46 -0700 [thread overview]
Message-ID: <4DDE9206.7020007@linux.intel.com> (raw)
In-Reply-To: <1306426688.2525.377.camel@phil-desktop>
On 05/26/2011 09:18 AM, Phil Blundell wrote:
> On Thu, 2011-05-26 at 15:37 +0100, Richard Purdie wrote:
>> u-boot in OE-Core would need something like COMPATIBLE_MACHINE = ""
>> which makes this harder.
>
> Yes, true. I don't think that's a major problem, though, you just need
> a regex that won't match anything. Something like:
>
> COMPATIBLE_MACHINE = "(?!^)"
>
> would probably do what you want, though it does have the admitted
> downside of looking rather like line noise.
>
> If this is going to be a common problem then it might be worth hacking
> base.bbclass about a bit to provide a more convenient way to do it. The
> UBOOT_MACHINE thing is fine as a solution for u-boot since that variable
> needs to exist anyway, but I wouldn't have been keen on introducing it
> just to control the recipe acceptability.
>
>> Its usually seem to work out easier to just do:
>>
>> COMPATIBLE_MACHINE_mymachine = "mymachine"
>>
>> which avoids several potential issues.
>
> Yeah, that would work fine too: you could even save a bit of typing by
> just using "" as the rvalue since an empty C_M will (somewhat
> counterintuitively) permit everything.
Really?... <looks into base.bbclass and data_smart.py> Huh, you are
correct. I wouldn't have expected that.
> I got the impression from
> Darren's original phraseology of "resorting to machine-specific
> overrides" that he didn't like it much, though.
Right, it just starts to look rather ugly in the recipe, especially for
BSPs supporting more than just a couple of machines. I also think that
having to use machine overrides is an indicator that the mechanism is
not working for the purpose it was designed for.
--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
next prev parent reply other threads:[~2011-05-26 17:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 5:01 [PATCH 0/2] u-boot updates to make it more bbappend friendly Darren Hart
2011-05-26 5:02 ` [pull-oe-uboot 1/2] u-boot: remove UBOOT_MACHINE and COMPATIBLE_MACHINES Darren Hart
2011-05-26 7:47 ` Jason Kridner
2011-05-26 13:50 ` Darren Hart
2011-05-26 14:08 ` Chris Larson
2011-05-26 10:50 ` Phil Blundell
2011-05-26 14:37 ` Richard Purdie
2011-05-26 16:18 ` Phil Blundell
2011-05-26 17:46 ` Darren Hart [this message]
2011-05-27 14:04 ` Phil Blundell
2011-05-27 15:06 ` Darren Hart
2011-05-27 15:11 ` Phil Blundell
2011-05-26 5:02 ` [pull-oe-uboot 2/2] u-boot: rename u-boot_git.bb to u-boot_${PV}.bb Darren Hart
2011-05-26 7:58 ` Jason Kridner
2011-05-26 13:52 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDE9206.7020007@linux.intel.com \
--to=dvhart@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox