Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 0/1] Remove exported KERNEL_SOURCE
Date: Thu, 07 Jul 2011 11:12:42 +0100	[thread overview]
Message-ID: <1310033562.20015.813.camel@rex> (raw)
In-Reply-To: <201107060841.29809.anders@chargestorm.se>

On Wed, 2011-07-06 at 08:41 +0200, Anders Darander wrote:
> * Anders Darander Anders Darander <anders@chargestorm.se> [07/05/11 04:52 PM]:
> > Remove KERNEL-SOURCE as an exported variable.
> > When building an external module the
> > STAGING_KERNEL_DIR variable can justbas well be used in
> > the module recipe.
> 
> There is an alternative solution, which is to instead of removing the line
>  export KERNEL_SOURCE = "${@base_read_file('${STAGING_KERNEL_DIR}/kernel-
> source')}"
> replace it with something like:
> export KERNEL_SOURCE = "${STAGING_KERNEL_DIR}"
> 
> The only benefit from that solution is to prevent breaking of recipes when 
> moving from oe.dev to oe-core. However, I prefer the original solution as we 
> otherwise would have more redundant variables.

Since the directory in question doesn't exist, we can likely remove this
as anyone using it should have complained by now...

We can add it back with the corrected version if anyone does turn out to
need it.

Cheers,

Richard






      reply	other threads:[~2011-07-07 10:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-05 14:52 [PATCH 0/1] Remove exported KERNEL_SOURCE Anders Darander
2011-07-05 14:55 ` [PATCH 1/1] module-base: remove KERNEL-SOURCE Anders Darander
2011-07-07 10:11   ` Richard Purdie
2011-07-06  6:41 ` [PATCH 0/1] Remove exported KERNEL_SOURCE Anders Darander
2011-07-07 10:12   ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1310033562.20015.813.camel@rex \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox