[PATCH 0/1] Remove exported KERNEL_SOURCE

[PATCH 0/1] Remove exported KERNEL_SOURCE

[Anders Darander]

Remove KERNEL-SOURCE as an exported variable. 
When building an external module the 
STAGING_KERNEL_DIR variable can justbas well be used in
the module recipe.

The following changes since commit 2b3bf5350861f62435e2fdf1c56c8a02f4b1b4ac:

  xauth: upgrade from 1.05 to 1.06 (2011-07-04 12:45:01 +0100)

are available in the git repository at:
  git://github.com/darander/oe-core kernel-source
  https://github.com/darander/oe-core/tree/kernel-source

Anders Darander (1):
  module-base: remove KERNEL-SOURCE

 meta/classes/module-base.bbclass |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

-- 
1.7.4.1

[PATCH 1/1] module-base: remove KERNEL-SOURCE

[Anders Darander]

kernel-source do not exist in STAGING_KERNEL_DIR any longer.
Remove the exported KERNEL_SOURCE as the STAGING_KERNEL_DIR can
be used in module recipes directly.

Signed-off-by: Anders Darander <anders@chargestorm.se>
---
 meta/classes/module-base.bbclass |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/meta/classes/module-base.bbclass b/meta/classes/module-base.bbclass
index a7cf233..1a39cc1 100644
--- a/meta/classes/module-base.bbclass
+++ b/meta/classes/module-base.bbclass
@@ -6,7 +6,6 @@ export OS = "${TARGET_OS}"
 export CROSS_COMPILE = "${TARGET_PREFIX}"
 
 export KERNEL_VERSION = "${@base_read_file('${STAGING_KERNEL_DIR}/kernel-abiversion')}"
-export KERNEL_SOURCE = "${@base_read_file('${STAGING_KERNEL_DIR}/kernel-source')}"
 KERNEL_OBJECT_SUFFIX = ".ko"
 KERNEL_CCSUFFIX = "${@base_read_file('${STAGING_KERNEL_DIR}/kernel-ccsuffix')}"
 KERNEL_LDSUFFIX = "${@base_read_file('${STAGING_KERNEL_DIR}/kernel-ldsuffix')}"
-- 
1.7.4.1

Re: [PATCH 0/1] Remove exported KERNEL_SOURCE

[Anders Darander]

* Anders Darander Anders Darander <anders@chargestorm.se> [07/05/11 04:52 PM]:
> Remove KERNEL-SOURCE as an exported variable.
> When building an external module the
> STAGING_KERNEL_DIR variable can justbas well be used in
> the module recipe.

There is an alternative solution, which is to instead of removing the line
 export KERNEL_SOURCE = "${@base_read_file('${STAGING_KERNEL_DIR}/kernel-
source')}"
replace it with something like:
export KERNEL_SOURCE = "${STAGING_KERNEL_DIR}"

The only benefit from that solution is to prevent breaking of recipes when 
moving from oe.dev to oe-core. However, I prefer the original solution as we 
otherwise would have more redundant variables.

Regards,
Anders

Re: [PATCH 1/1] module-base: remove KERNEL-SOURCE

[Richard Purdie]

On Tue, 2011-07-05 at 16:55 +0200, Anders Darander wrote:
> kernel-source do not exist in STAGING_KERNEL_DIR any longer.
> Remove the exported KERNEL_SOURCE as the STAGING_KERNEL_DIR can
> be used in module recipes directly.
> 
> Signed-off-by: Anders Darander <anders@chargestorm.se>
> ---
>  meta/classes/module-base.bbclass |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/classes/module-base.bbclass b/meta/classes/module-base.bbclass
> index a7cf233..1a39cc1 100644
> --- a/meta/classes/module-base.bbclass
> +++ b/meta/classes/module-base.bbclass
> @@ -6,7 +6,6 @@ export OS = "${TARGET_OS}"
>  export CROSS_COMPILE = "${TARGET_PREFIX}"
>  
>  export KERNEL_VERSION = "${@base_read_file('${STAGING_KERNEL_DIR}/kernel-abiversion')}"
> -export KERNEL_SOURCE = "${@base_read_file('${STAGING_KERNEL_DIR}/kernel-source')}"
>  KERNEL_OBJECT_SUFFIX = ".ko"
>  KERNEL_CCSUFFIX = "${@base_read_file('${STAGING_KERNEL_DIR}/kernel-ccsuffix')}"
>  KERNEL_LDSUFFIX = "${@base_read_file('${STAGING_KERNEL_DIR}/kernel-ldsuffix')}"

Merged to master, thanks.

Richard

Re: [PATCH 0/1] Remove exported KERNEL_SOURCE

[Richard Purdie]

On Wed, 2011-07-06 at 08:41 +0200, Anders Darander wrote:
> * Anders Darander Anders Darander <anders@chargestorm.se> [07/05/11 04:52 PM]:
> > Remove KERNEL-SOURCE as an exported variable.
> > When building an external module the
> > STAGING_KERNEL_DIR variable can justbas well be used in
> > the module recipe.
> 
> There is an alternative solution, which is to instead of removing the line
>  export KERNEL_SOURCE = "${@base_read_file('${STAGING_KERNEL_DIR}/kernel-
> source')}"
> replace it with something like:
> export KERNEL_SOURCE = "${STAGING_KERNEL_DIR}"
> 
> The only benefit from that solution is to prevent breaking of recipes when 
> moving from oe.dev to oe-core. However, I prefer the original solution as we 
> otherwise would have more redundant variables.

Since the directory in question doesn't exist, we can likely remove this
as anyone using it should have complained by now...

We can add it back with the corrected version if anyone does turn out to
need it.

Cheers,

Richard