Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/8] rootfs_rpm: Add 50Meg to image size for zypper
Date: Fri, 08 Jul 2011 00:38:02 +0100	[thread overview]
Message-ID: <1310081883.20015.862.camel@rex> (raw)
In-Reply-To: <c55e57619344a0ddff4444e1a4403c9516089e5b.1310081443.git.sgw@linux.intel.com>

On Thu, 2011-07-07 at 16:31 -0700, Saul Wold wrote:
> [YOCTO #1171]
> 
> Add /var space for zypper due to its space usage for db maintence

This hasn't been tested for opkg/deb and is missing something like:

ZYPPER_VAR_DB_SPACE ??= 0

I'd suggest we just change this to append " + 51200" to
IMAGE_ROOTFS_EXTRA_SPACE. I'd also like this only to happen when we're
actually installing zypper so the minimal images are unaffected...

Cheers,

Richard





> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
>  meta/classes/image_types.bbclass |    2 +-
>  meta/classes/rootfs_rpm.bbclass  |    5 +++++
>  2 files changed, 6 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass
> index 8c86227..505342d 100644
> --- a/meta/classes/image_types.bbclass
> +++ b/meta/classes/image_types.bbclass
> @@ -13,7 +13,7 @@ def get_imagecmds(d):
>  
>  runimagecmd () {
>  	# Image generation code for image type ${type}
> -	ROOTFS_SIZE=`du -ks ${IMAGE_ROOTFS}|awk '{size = $1 * ${IMAGE_OVERHEAD_FACTOR} + ${IMAGE_ROOTFS_EXTRA_SPACE}; OFMT = "%.0f" ; print (size > ${IMAGE_ROOTFS_SIZE} ? size : ${IMAGE_ROOTFS_SIZE}) }'`
> +	ROOTFS_SIZE=`du -ks ${IMAGE_ROOTFS}|awk '{size = $1 * ${IMAGE_OVERHEAD_FACTOR} + ${IMAGE_ROOTFS_EXTRA_SPACE} + ${ZYPPER_VAR_DB_SPACE}; OFMT = "%.0f" ; print (size > ${IMAGE_ROOTFS_SIZE} ? size : ${IMAGE_ROOTFS_SIZE}) }'`
>  	${cmd}
>  	cd ${DEPLOY_DIR_IMAGE}/
>  	rm -f ${DEPLOY_DIR_IMAGE}/${IMAGE_LINK_NAME}.${type}
> diff --git a/meta/classes/rootfs_rpm.bbclass b/meta/classes/rootfs_rpm.bbclass
> index 3a11858..67c547f 100644
> --- a/meta/classes/rootfs_rpm.bbclass
> +++ b/meta/classes/rootfs_rpm.bbclass
> @@ -3,6 +3,10 @@
>  #
>  
>  ROOTFS_PKGMANAGE = "rpm zypper"
> +
> +# Add 50Meg of extra space for zypper database space
> +ZYPPER_VAR_DB_SPACE = "51200"
> +
>  # Postinstalls on device are handled within this class at present
>  ROOTFS_PKGMANAGE_BOOTSTRAP = ""
>  
> @@ -101,6 +105,7 @@ EOF
>  	export IPKG_OFFLINE_ROOT=${IMAGE_ROOTFS}
>  	export OPKG_OFFLINE_ROOT=${IMAGE_ROOTFS}
>  
> +
>  	${ROOTFS_POSTINSTALL_COMMAND}
>  
>  	mkdir -p ${IMAGE_ROOTFS}/etc/rpm-postinsts/





  reply	other threads:[~2011-07-07 23:42 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-07 23:31 [PATCH 0/8] Bug Fixes for M2 Rc2 Saul Wold
2011-07-07 23:31 ` [PATCH 1/8] rootfs_rpm: Add 50Meg to image size for zypper Saul Wold
2011-07-07 23:38   ` Richard Purdie [this message]
2011-07-08  5:42     ` Saul Wold
2011-07-08 14:52       ` Richard Purdie
2011-07-07 23:31 ` [PATCH 2/8] image.bbclass: add LINGUAS_INSTALL to depends list Saul Wold
2011-07-07 23:31 ` [PATCH 3/8] gnome-doc-utils: Add RDEPENDS on bash Saul Wold
2011-07-07 23:31 ` [PATCH 4/8] quilt: " Saul Wold
2011-07-07 23:31 ` [PATCH 5/8] console-tools: " Saul Wold
2011-07-07 23:31 ` [PATCH 6/8] usbutils: " Saul Wold
2011-07-08  7:28   ` Koen Kooi
2011-07-08 15:42     ` Richard Purdie
2011-07-07 23:31 ` [PATCH 7/8] eglibc: " Saul Wold
2011-07-08  0:59   ` Khem Raj
2011-07-08  1:15     ` Saul Wold
2011-07-08  5:27       ` Khem Raj
2011-07-12 13:38         ` Phil Blundell
2011-07-08  6:53   ` Frans Meulenbroeks
2011-07-08  7:01     ` Koen Kooi
2011-07-08  7:23       ` Frans Meulenbroeks
2011-07-07 23:31 ` [PATCH 8/8] libx11: enable xcb support Saul Wold
2011-07-08 13:57   ` Phil Blundell
2011-07-18 22:55   ` Martin Jansa
2011-07-08  6:49 ` [PATCH 0/8] Bug Fixes for M2 Rc2 Frans Meulenbroeks
2011-07-08 15:41 ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1310081883.20015.862.camel@rex \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox