Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Koen Kooi <koen@dominion.thruhere.net>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v2] arch-armv7a.inc: fix armv7a-vfp-neon -> armv7a compat case
Date: Mon, 01 Aug 2011 16:49:48 +0100	[thread overview]
Message-ID: <1312213788.2344.504.camel@rex> (raw)
In-Reply-To: <50CF8F6D-804A-4401-8EA3-5F19581E78D2@dominion.thruhere.net>

On Mon, 2011-08-01 at 16:00 +0200, Koen Kooi wrote:
> Op 1 aug. 2011, om 15:47 heeft Richard Purdie het volgende geschreven:
> 
> > On Mon, 2011-08-01 at 15:41 +0200, Koen Kooi wrote:
> >> Without this 'armv7a' is used as TUNE_ARCH but does *not* end up in PACKAGE_EXTRA_ARCHS:
> >> 
> >> arch all 1
> >> arch any 6
> >> arch noarch 11
> >> arch arm 16
> >> arch armv4 21
> >> arch armv4t 26
> >> arch armv5 31
> >> arch armv5t 36
> >> arch armv5-vfp 41
> >> arch armv5t-vfp 46
> >> arch armv5e 51
> >> arch armv5te 56
> >> arch armv5e-vfp 61
> >> arch armv5te-vfp 66
> >> arch armv6-vfp 71
> >> arch armv6t-vfp 76
> >> arch armv7-vfp 81
> >> arch armv7t2-vfp 86
> >> arch armv7a-vfp 91
> >> arch armv7at2-vfp 96
> >> arch armv7a-vfp-neon 101
> >> arch armv7at2-vfp-neon 106
> >> arch beagleboard 111
> >> 
> >> Which leads to a failing do_rootfs
> >> 
> >> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> >> ---
> >> meta/conf/machine/include/arm/arch-armv7a.inc |    4 ++--
> >> 1 files changed, 2 insertions(+), 2 deletions(-)
> >> 
> >> diff --git a/meta/conf/machine/include/arm/arch-armv7a.inc b/meta/conf/machine/include/arm/arch-armv7a.inc
> >> index ce9cee5..704f86b 100644
> >> --- a/meta/conf/machine/include/arm/arch-armv7a.inc
> >> +++ b/meta/conf/machine/include/arm/arch-armv7a.inc
> >> @@ -14,9 +14,9 @@ TUNE_FEATURES_tune-armv7a ?= "armv7a vfp"
> >> TUNE_FEATURES_tune-armv7at ?= "armv7a vfp thumb"
> >> TUNE_FEATURES_tune-armv7a-neon ?= "armv7a vfp neon"
> >> TUNE_FEATURES_tune-armv7at-neon ?= "armv7a vfp neon thumb"
> >> -PACKAGE_EXTRA_ARCHS_tune-armv7a = "${PACKAGE_EXTRA_ARCHS_tune-armv7} armv7a-vfp"
> >> +PACKAGE_EXTRA_ARCHS_tune-armv7a = "${PACKAGE_EXTRA_ARCHS_tune-armv7} armv7a armv7a-vfp"
> >> PACKAGE_EXTRA_ARCHS_tune-armv7a-neon = "${PACKAGE_EXTRA_ARCHS_tune-armv7a} armv7a-vfp-neon"
> >> -PACKAGE_EXTRA_ARCHS_tune-armv7at = "${PACKAGE_EXTRA_ARCHS_tune-armv7t} armv7a-vfp armv7at2-vfp"
> >> +PACKAGE_EXTRA_ARCHS_tune-armv7at = "${PACKAGE_EXTRA_ARCHS_tune-armv7t} armv7a armv7a-vfp armv7at2-vfp"
> >> PACKAGE_EXTRA_ARCHS_tune-armv7at-neon = "${PACKAGE_EXTRA_ARCHS_tune-armv7at} armv7a-vfp-neon armv7at2-vfp-neon"
> > 
> > I didn't spell it out but you still need the b versions too for the
> > equivalent lines ;-)
> 
> Actually, no :) There only is a little endian compat mapping in
> base.bbclass, so it only makes sense to fix that one. There are no BE
> v7as in classic OE or in any layer google.com knows about, so let's
> leave that out.

Ok, merged to master, thanks.

Richard





  reply	other threads:[~2011-08-01 15:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-01 13:41 [PATCH v2] arch-armv7a.inc: fix armv7a-vfp-neon -> armv7a compat case Koen Kooi
2011-08-01 13:47 ` Richard Purdie
2011-08-01 14:00   ` Koen Kooi
2011-08-01 15:49     ` Richard Purdie [this message]
2011-08-01 16:00 ` Phil Blundell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1312213788.2344.504.camel@rex \
    --to=richard.purdie@linuxfoundation.org \
    --cc=koen@dominion.thruhere.net \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox