* [PATCH v2] arch-armv7a.inc: fix armv7a-vfp-neon -> armv7a compat case
@ 2011-08-01 13:41 Koen Kooi
2011-08-01 13:47 ` Richard Purdie
2011-08-01 16:00 ` Phil Blundell
0 siblings, 2 replies; 5+ messages in thread
From: Koen Kooi @ 2011-08-01 13:41 UTC (permalink / raw)
To: openembedded-core; +Cc: Koen Kooi
Without this 'armv7a' is used as TUNE_ARCH but does *not* end up in PACKAGE_EXTRA_ARCHS:
arch all 1
arch any 6
arch noarch 11
arch arm 16
arch armv4 21
arch armv4t 26
arch armv5 31
arch armv5t 36
arch armv5-vfp 41
arch armv5t-vfp 46
arch armv5e 51
arch armv5te 56
arch armv5e-vfp 61
arch armv5te-vfp 66
arch armv6-vfp 71
arch armv6t-vfp 76
arch armv7-vfp 81
arch armv7t2-vfp 86
arch armv7a-vfp 91
arch armv7at2-vfp 96
arch armv7a-vfp-neon 101
arch armv7at2-vfp-neon 106
arch beagleboard 111
Which leads to a failing do_rootfs
Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
---
meta/conf/machine/include/arm/arch-armv7a.inc | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/meta/conf/machine/include/arm/arch-armv7a.inc b/meta/conf/machine/include/arm/arch-armv7a.inc
index ce9cee5..704f86b 100644
--- a/meta/conf/machine/include/arm/arch-armv7a.inc
+++ b/meta/conf/machine/include/arm/arch-armv7a.inc
@@ -14,9 +14,9 @@ TUNE_FEATURES_tune-armv7a ?= "armv7a vfp"
TUNE_FEATURES_tune-armv7at ?= "armv7a vfp thumb"
TUNE_FEATURES_tune-armv7a-neon ?= "armv7a vfp neon"
TUNE_FEATURES_tune-armv7at-neon ?= "armv7a vfp neon thumb"
-PACKAGE_EXTRA_ARCHS_tune-armv7a = "${PACKAGE_EXTRA_ARCHS_tune-armv7} armv7a-vfp"
+PACKAGE_EXTRA_ARCHS_tune-armv7a = "${PACKAGE_EXTRA_ARCHS_tune-armv7} armv7a armv7a-vfp"
PACKAGE_EXTRA_ARCHS_tune-armv7a-neon = "${PACKAGE_EXTRA_ARCHS_tune-armv7a} armv7a-vfp-neon"
-PACKAGE_EXTRA_ARCHS_tune-armv7at = "${PACKAGE_EXTRA_ARCHS_tune-armv7t} armv7a-vfp armv7at2-vfp"
+PACKAGE_EXTRA_ARCHS_tune-armv7at = "${PACKAGE_EXTRA_ARCHS_tune-armv7t} armv7a armv7a-vfp armv7at2-vfp"
PACKAGE_EXTRA_ARCHS_tune-armv7at-neon = "${PACKAGE_EXTRA_ARCHS_tune-armv7at} armv7a-vfp-neon armv7at2-vfp-neon"
# VFP Tunes
--
1.6.6.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] arch-armv7a.inc: fix armv7a-vfp-neon -> armv7a compat case
2011-08-01 13:41 [PATCH v2] arch-armv7a.inc: fix armv7a-vfp-neon -> armv7a compat case Koen Kooi
@ 2011-08-01 13:47 ` Richard Purdie
2011-08-01 14:00 ` Koen Kooi
2011-08-01 16:00 ` Phil Blundell
1 sibling, 1 reply; 5+ messages in thread
From: Richard Purdie @ 2011-08-01 13:47 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer; +Cc: Koen Kooi
On Mon, 2011-08-01 at 15:41 +0200, Koen Kooi wrote:
> Without this 'armv7a' is used as TUNE_ARCH but does *not* end up in PACKAGE_EXTRA_ARCHS:
>
> arch all 1
> arch any 6
> arch noarch 11
> arch arm 16
> arch armv4 21
> arch armv4t 26
> arch armv5 31
> arch armv5t 36
> arch armv5-vfp 41
> arch armv5t-vfp 46
> arch armv5e 51
> arch armv5te 56
> arch armv5e-vfp 61
> arch armv5te-vfp 66
> arch armv6-vfp 71
> arch armv6t-vfp 76
> arch armv7-vfp 81
> arch armv7t2-vfp 86
> arch armv7a-vfp 91
> arch armv7at2-vfp 96
> arch armv7a-vfp-neon 101
> arch armv7at2-vfp-neon 106
> arch beagleboard 111
>
> Which leads to a failing do_rootfs
>
> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> ---
> meta/conf/machine/include/arm/arch-armv7a.inc | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/conf/machine/include/arm/arch-armv7a.inc b/meta/conf/machine/include/arm/arch-armv7a.inc
> index ce9cee5..704f86b 100644
> --- a/meta/conf/machine/include/arm/arch-armv7a.inc
> +++ b/meta/conf/machine/include/arm/arch-armv7a.inc
> @@ -14,9 +14,9 @@ TUNE_FEATURES_tune-armv7a ?= "armv7a vfp"
> TUNE_FEATURES_tune-armv7at ?= "armv7a vfp thumb"
> TUNE_FEATURES_tune-armv7a-neon ?= "armv7a vfp neon"
> TUNE_FEATURES_tune-armv7at-neon ?= "armv7a vfp neon thumb"
> -PACKAGE_EXTRA_ARCHS_tune-armv7a = "${PACKAGE_EXTRA_ARCHS_tune-armv7} armv7a-vfp"
> +PACKAGE_EXTRA_ARCHS_tune-armv7a = "${PACKAGE_EXTRA_ARCHS_tune-armv7} armv7a armv7a-vfp"
> PACKAGE_EXTRA_ARCHS_tune-armv7a-neon = "${PACKAGE_EXTRA_ARCHS_tune-armv7a} armv7a-vfp-neon"
> -PACKAGE_EXTRA_ARCHS_tune-armv7at = "${PACKAGE_EXTRA_ARCHS_tune-armv7t} armv7a-vfp armv7at2-vfp"
> +PACKAGE_EXTRA_ARCHS_tune-armv7at = "${PACKAGE_EXTRA_ARCHS_tune-armv7t} armv7a armv7a-vfp armv7at2-vfp"
> PACKAGE_EXTRA_ARCHS_tune-armv7at-neon = "${PACKAGE_EXTRA_ARCHS_tune-armv7at} armv7a-vfp-neon armv7at2-vfp-neon"
I didn't spell it out but you still need the b versions too for the
equivalent lines ;-)
Cheers,
Richard
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] arch-armv7a.inc: fix armv7a-vfp-neon -> armv7a compat case
2011-08-01 13:47 ` Richard Purdie
@ 2011-08-01 14:00 ` Koen Kooi
2011-08-01 15:49 ` Richard Purdie
0 siblings, 1 reply; 5+ messages in thread
From: Koen Kooi @ 2011-08-01 14:00 UTC (permalink / raw)
To: Richard Purdie; +Cc: Patches and discussions about the oe-core layer
Op 1 aug. 2011, om 15:47 heeft Richard Purdie het volgende geschreven:
> On Mon, 2011-08-01 at 15:41 +0200, Koen Kooi wrote:
>> Without this 'armv7a' is used as TUNE_ARCH but does *not* end up in PACKAGE_EXTRA_ARCHS:
>>
>> arch all 1
>> arch any 6
>> arch noarch 11
>> arch arm 16
>> arch armv4 21
>> arch armv4t 26
>> arch armv5 31
>> arch armv5t 36
>> arch armv5-vfp 41
>> arch armv5t-vfp 46
>> arch armv5e 51
>> arch armv5te 56
>> arch armv5e-vfp 61
>> arch armv5te-vfp 66
>> arch armv6-vfp 71
>> arch armv6t-vfp 76
>> arch armv7-vfp 81
>> arch armv7t2-vfp 86
>> arch armv7a-vfp 91
>> arch armv7at2-vfp 96
>> arch armv7a-vfp-neon 101
>> arch armv7at2-vfp-neon 106
>> arch beagleboard 111
>>
>> Which leads to a failing do_rootfs
>>
>> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
>> ---
>> meta/conf/machine/include/arm/arch-armv7a.inc | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/conf/machine/include/arm/arch-armv7a.inc b/meta/conf/machine/include/arm/arch-armv7a.inc
>> index ce9cee5..704f86b 100644
>> --- a/meta/conf/machine/include/arm/arch-armv7a.inc
>> +++ b/meta/conf/machine/include/arm/arch-armv7a.inc
>> @@ -14,9 +14,9 @@ TUNE_FEATURES_tune-armv7a ?= "armv7a vfp"
>> TUNE_FEATURES_tune-armv7at ?= "armv7a vfp thumb"
>> TUNE_FEATURES_tune-armv7a-neon ?= "armv7a vfp neon"
>> TUNE_FEATURES_tune-armv7at-neon ?= "armv7a vfp neon thumb"
>> -PACKAGE_EXTRA_ARCHS_tune-armv7a = "${PACKAGE_EXTRA_ARCHS_tune-armv7} armv7a-vfp"
>> +PACKAGE_EXTRA_ARCHS_tune-armv7a = "${PACKAGE_EXTRA_ARCHS_tune-armv7} armv7a armv7a-vfp"
>> PACKAGE_EXTRA_ARCHS_tune-armv7a-neon = "${PACKAGE_EXTRA_ARCHS_tune-armv7a} armv7a-vfp-neon"
>> -PACKAGE_EXTRA_ARCHS_tune-armv7at = "${PACKAGE_EXTRA_ARCHS_tune-armv7t} armv7a-vfp armv7at2-vfp"
>> +PACKAGE_EXTRA_ARCHS_tune-armv7at = "${PACKAGE_EXTRA_ARCHS_tune-armv7t} armv7a armv7a-vfp armv7at2-vfp"
>> PACKAGE_EXTRA_ARCHS_tune-armv7at-neon = "${PACKAGE_EXTRA_ARCHS_tune-armv7at} armv7a-vfp-neon armv7at2-vfp-neon"
>
> I didn't spell it out but you still need the b versions too for the
> equivalent lines ;-)
Actually, no :) There only is a little endian compat mapping in base.bbclass, so it only makes sense to fix that one. There are no BE v7as in classic OE or in any layer google.com knows about, so let's leave that out.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] arch-armv7a.inc: fix armv7a-vfp-neon -> armv7a compat case
2011-08-01 14:00 ` Koen Kooi
@ 2011-08-01 15:49 ` Richard Purdie
0 siblings, 0 replies; 5+ messages in thread
From: Richard Purdie @ 2011-08-01 15:49 UTC (permalink / raw)
To: Koen Kooi; +Cc: Patches and discussions about the oe-core layer
On Mon, 2011-08-01 at 16:00 +0200, Koen Kooi wrote:
> Op 1 aug. 2011, om 15:47 heeft Richard Purdie het volgende geschreven:
>
> > On Mon, 2011-08-01 at 15:41 +0200, Koen Kooi wrote:
> >> Without this 'armv7a' is used as TUNE_ARCH but does *not* end up in PACKAGE_EXTRA_ARCHS:
> >>
> >> arch all 1
> >> arch any 6
> >> arch noarch 11
> >> arch arm 16
> >> arch armv4 21
> >> arch armv4t 26
> >> arch armv5 31
> >> arch armv5t 36
> >> arch armv5-vfp 41
> >> arch armv5t-vfp 46
> >> arch armv5e 51
> >> arch armv5te 56
> >> arch armv5e-vfp 61
> >> arch armv5te-vfp 66
> >> arch armv6-vfp 71
> >> arch armv6t-vfp 76
> >> arch armv7-vfp 81
> >> arch armv7t2-vfp 86
> >> arch armv7a-vfp 91
> >> arch armv7at2-vfp 96
> >> arch armv7a-vfp-neon 101
> >> arch armv7at2-vfp-neon 106
> >> arch beagleboard 111
> >>
> >> Which leads to a failing do_rootfs
> >>
> >> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> >> ---
> >> meta/conf/machine/include/arm/arch-armv7a.inc | 4 ++--
> >> 1 files changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/meta/conf/machine/include/arm/arch-armv7a.inc b/meta/conf/machine/include/arm/arch-armv7a.inc
> >> index ce9cee5..704f86b 100644
> >> --- a/meta/conf/machine/include/arm/arch-armv7a.inc
> >> +++ b/meta/conf/machine/include/arm/arch-armv7a.inc
> >> @@ -14,9 +14,9 @@ TUNE_FEATURES_tune-armv7a ?= "armv7a vfp"
> >> TUNE_FEATURES_tune-armv7at ?= "armv7a vfp thumb"
> >> TUNE_FEATURES_tune-armv7a-neon ?= "armv7a vfp neon"
> >> TUNE_FEATURES_tune-armv7at-neon ?= "armv7a vfp neon thumb"
> >> -PACKAGE_EXTRA_ARCHS_tune-armv7a = "${PACKAGE_EXTRA_ARCHS_tune-armv7} armv7a-vfp"
> >> +PACKAGE_EXTRA_ARCHS_tune-armv7a = "${PACKAGE_EXTRA_ARCHS_tune-armv7} armv7a armv7a-vfp"
> >> PACKAGE_EXTRA_ARCHS_tune-armv7a-neon = "${PACKAGE_EXTRA_ARCHS_tune-armv7a} armv7a-vfp-neon"
> >> -PACKAGE_EXTRA_ARCHS_tune-armv7at = "${PACKAGE_EXTRA_ARCHS_tune-armv7t} armv7a-vfp armv7at2-vfp"
> >> +PACKAGE_EXTRA_ARCHS_tune-armv7at = "${PACKAGE_EXTRA_ARCHS_tune-armv7t} armv7a armv7a-vfp armv7at2-vfp"
> >> PACKAGE_EXTRA_ARCHS_tune-armv7at-neon = "${PACKAGE_EXTRA_ARCHS_tune-armv7at} armv7a-vfp-neon armv7at2-vfp-neon"
> >
> > I didn't spell it out but you still need the b versions too for the
> > equivalent lines ;-)
>
> Actually, no :) There only is a little endian compat mapping in
> base.bbclass, so it only makes sense to fix that one. There are no BE
> v7as in classic OE or in any layer google.com knows about, so let's
> leave that out.
Ok, merged to master, thanks.
Richard
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arch-armv7a.inc: fix armv7a-vfp-neon -> armv7a compat case
2011-08-01 13:41 [PATCH v2] arch-armv7a.inc: fix armv7a-vfp-neon -> armv7a compat case Koen Kooi
2011-08-01 13:47 ` Richard Purdie
@ 2011-08-01 16:00 ` Phil Blundell
1 sibling, 0 replies; 5+ messages in thread
From: Phil Blundell @ 2011-08-01 16:00 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer; +Cc: Koen Kooi
On Mon, 2011-08-01 at 15:41 +0200, Koen Kooi wrote:
> diff --git a/meta/conf/machine/include/arm/arch-armv7a.inc b/meta/conf/machine/include/arm/arch-armv7a.inc
> index ce9cee5..704f86b 100644
> --- a/meta/conf/machine/include/arm/arch-armv7a.inc
> +++ b/meta/conf/machine/include/arm/arch-armv7a.inc
> @@ -14,9 +14,9 @@ TUNE_FEATURES_tune-armv7a ?= "armv7a vfp"
> TUNE_FEATURES_tune-armv7at ?= "armv7a vfp thumb"
> TUNE_FEATURES_tune-armv7a-neon ?= "armv7a vfp neon"
> TUNE_FEATURES_tune-armv7at-neon ?= "armv7a vfp neon thumb"
> -PACKAGE_EXTRA_ARCHS_tune-armv7a = "${PACKAGE_EXTRA_ARCHS_tune-armv7} armv7a-vfp"
> +PACKAGE_EXTRA_ARCHS_tune-armv7a = "${PACKAGE_EXTRA_ARCHS_tune-armv7} armv7a armv7a-vfp"
> PACKAGE_EXTRA_ARCHS_tune-armv7a-neon = "${PACKAGE_EXTRA_ARCHS_tune-armv7a} armv7a-vfp-neon"
> -PACKAGE_EXTRA_ARCHS_tune-armv7at = "${PACKAGE_EXTRA_ARCHS_tune-armv7t} armv7a-vfp armv7at2-vfp"
> +PACKAGE_EXTRA_ARCHS_tune-armv7at = "${PACKAGE_EXTRA_ARCHS_tune-armv7t} armv7a armv7a-vfp armv7at2-vfp"
> PACKAGE_EXTRA_ARCHS_tune-armv7at-neon = "${PACKAGE_EXTRA_ARCHS_tune-armv7at} armv7a-vfp-neon armv7at2-vfp-neon"
Shouldn't this be getting handled in pkgarch_mapping() at the point
where the renaming happens? In this particular case it seems harmless
(if a bit fragile) to name both possibilities in PACKAGE_EXTRA_ARCHS_...
but I'm not certain that this will always be safe in general.
p.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-08-01 16:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-01 13:41 [PATCH v2] arch-armv7a.inc: fix armv7a-vfp-neon -> armv7a compat case Koen Kooi
2011-08-01 13:47 ` Richard Purdie
2011-08-01 14:00 ` Koen Kooi
2011-08-01 15:49 ` Richard Purdie
2011-08-01 16:00 ` Phil Blundell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox