Re: [PATCH] scripts/oe-buildenv-internal: Add SOCKS5_{USER, PASSWD} to BB_ENV_EXTRAWHITE

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Wed, 2011-08-03 at 14:41 -0500, Kumar Gala wrote:
> On Aug 3, 2011, at 12:30 PM, Saul Wold wrote:
> 
> > On 08/03/2011 10:00 AM, Kumar Gala wrote:
> >> 
> >> On Jul 28, 2011, at 8:10 AM, Kumar Gala wrote:
> >> 
> >>> If a SOCKS5 gateway is needed for a proxy access like git it might also
> >>> require authentication to the proxy via a password and username.  Adding
> >>> SOCKS5_USER&  SOCKS5_PASSWD to BB_ENV_EXTRAWHITE allow for automation
> >>> of the authentication request to occur when something like a git fetch
> >>> is going through the proxy.
> >>> 
> >>> Signed-off-by: Kumar Gala<galak@kernel.crashing.org>
> >>> ---
> >>> * Fixes issue with a git fetch request failing to get pass a firewall
> >>> 
> >>> scripts/oe-buildenv-internal |    2 +-
> >>> 1 files changed, 1 insertions(+), 1 deletions(-)
> >>> 
> >>> diff --git a/scripts/oe-buildenv-internal b/scripts/oe-buildenv-internal
> >>> index c13fc40..b223292 100755
> >>> --- a/scripts/oe-buildenv-internal
> >>> +++ b/scripts/oe-buildenv-internal
> >>> @@ -55,4 +55,4 @@ unset BITBAKEDIR
> >>> export BUILDDIR
> >>> export PATH
> >>> 
> >>> -export BB_ENV_EXTRAWHITE="MACHINE DISTRO TCMODE TCLIBC http_proxy ftp_proxy https_proxy all_proxy ALL_PROXY no_proxy SSH_AGENT_PID SSH_AUTH_SOCK BB_SRCREV_POLICY SDKMACHINE BB_NUMBER_THREADS PARALLEL_MAKE GIT_PROXY_COMMAND"
> >>> +export BB_ENV_EXTRAWHITE="MACHINE DISTRO TCMODE TCLIBC http_proxy ftp_proxy https_proxy all_proxy ALL_PROXY no_proxy SSH_AGENT_PID SSH_AUTH_SOCK BB_SRCREV_POLICY SDKMACHINE BB_NUMBER_THREADS PARALLEL_MAKE GIT_PROXY_COMMAND SOCKS5_PASSWD SOCSK5_USER"
> >>> --
> >>> 1.7.3.4
> >> 
> >> Ping on this patch
> >> 
> > Kumar,
> > 
> > I think you were asked to modify this patch so that the additinal
> SOCKS5_* do not get into sstate, Paul Eggleton provided the
> BB_HASHSPACE_WHITELIST info.
> > 
> > Please update this patch
> > 
> > Thanks
> > 	Sau!
> 
> From the thread it sounded as if that was NOT needed.  As nothing
> refers to SOCKS5_* we didn't need to add it.  Much like how it doesn't
> have SSH_AGENT_PID or SSH_AUTH_SOCK in it.

It would be good is someone could confirm it but its in the environment
so it likely is needed.

Cheers,

Richard