From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 09/10] x86 tune inc files: add x32 abi tune parameters
Date: Fri, 05 Aug 2011 17:04:18 +0100 [thread overview]
Message-ID: <1312560258.14274.125.camel@rex> (raw)
In-Reply-To: <2c351319afd13acfca1283104172729925cfb696.1312469790.git.nitin.a.kamble@intel.com>
On Thu, 2011-08-04 at 08:01 -0700, nitin.a.kamble@intel.com wrote:
> From: Nitin A Kamble <nitin.a.kamble@intel.com>
>
> Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> ---
> meta/conf/machine/include/ia32/arch-ia32.inc | 23 ++++++++++++++++++++---
> meta/conf/machine/include/tune-core2.inc | 4 ++++
> meta/conf/machine/include/tune-x86_64.inc | 2 +-
> 3 files changed, 25 insertions(+), 4 deletions(-)
>
> diff --git a/meta/conf/machine/include/ia32/arch-ia32.inc b/meta/conf/machine/include/ia32/arch-ia32.inc
> index 2709440..fb527da 100644
> --- a/meta/conf/machine/include/ia32/arch-ia32.inc
> +++ b/meta/conf/machine/include/ia32/arch-ia32.inc
> @@ -6,17 +6,29 @@ DEFAULTTUNE ?= "x86"
> TARGET_FPU ?= ""
> X86ARCH32 ?= "i586"
> X86ARCH64 ?= "x86_64"
> +X86ARCHX32 ?= "x86_64"
>
> # ELF32 ABI
> TUNEVALID[m32] = "IA32 ELF32 standard ABI"
> -TUNECONFLICTS[m32] = "m64"
> +TUNECONFLICTS[m32] = "m64 mx32"
> TUNE_ARCH .= "${@bb.utils.contains("TUNE_FEATURES", "m32", "${X86ARCH32}", "" ,d)}"
> +ABIEXTENSION .= "${@bb.utils.contains("TUNE_FEATURES", "m32", "32", "" ,d)}"
Please drop the above line. There is no need to change that.
> TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "m32", "-m32", "", d)}"
>
> +# x32 ABI
> +TUNEVALID[mx32] = "IA32e (x86_64) ELF32 standard ABI"
> +TUNECONFLICTS[mx32] = "m64 m32"
> +TUNE_ARCH .= "${@bb.utils.contains("TUNE_FEATURES", "mx32", "${X86ARCHX32}", "" ,d)}"
> +ABIEXTENSION .= "${@bb.utils.contains("TUNE_FEATURES", "mx32", "x32", "" ,d)}"
> +TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "mx32", "-mx32", "", d)}"
> +TUNE_LDARGS += "${@bb.utils.contains("TUNE_FEATURES", "mx32", "-m elf32_x86_64", "", d)}"
> +TUNE_ASARGS += "${@bb.utils.contains("TUNE_FEATURES", "mx32", "-x32", "", d)}"
> +
These are fine.
> # ELF64 ABI
> TUNEVALID[m64] = "IA32e (x86_64) ELF64 standard ABI"
> -TUNECONFLICT[m64] = "m32"
> +TUNECONFLICT[m64] = "m32 mx32"
> TUNE_ARCH .= "${@bb.utils.contains("TUNE_FEATURES", "m64", "${X86ARCH64}", "" ,d)}"
> +ABIEXTENSION .= "${@bb.utils.contains("TUNE_FEATURES", "m64", "64", "" ,d)}"
Again, please drop the above line.
> TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "m64", "-m64", "", d)}"
>
> TUNE_PKGARCH ?= "${@bb.utils.contains("TUNE_FEATURES", "m32", "x86", "x86_64", d)}"
> @@ -30,4 +42,9 @@ PACKAGE_EXTRA_ARCHS_tune-x86 = "x86"
> AVAILTUNES += "x86-64"
> TUNE_FEATURES_tune-x86-64 ?= "m64"
> BASE_LIB_tune-x86-64 ?= "lib64"
> -PACKAGE_EXTRA_ARCHS_tune-x86-64 = "x86_64"
> +PACKAGE_EXTRA_ARCHS_tune-x86-64 = "x86-64"
That is likely wrong, please drop this piece.
> +
> +AVAILTUNES += "x86-64-x32"
> +TUNE_FEATURES_tune-x86-64-x32 ?= "mx32"
> +BASE_LIB_tune-x86-64-x32 ?= "lib"
> +PACKAGE_EXTRA_ARCHS_tune-x86-64-x32 = "x86-64-x32"
And this is wrong too.
You really want:
TUNE_PKGARCH .= "${@bb.utils.contains("TUNE_FEATURES", "mx32", "-x32", "", d)}"
PACKAGE_EXTRA_ARCHS_tune-x86-64-x32 = "x86_64-x32"
> diff --git a/meta/conf/machine/include/tune-core2.inc b/meta/conf/machine/include/tune-core2.inc
> index 25c2226..8a4de3e 100644
> --- a/meta/conf/machine/include/tune-core2.inc
> +++ b/meta/conf/machine/include/tune-core2.inc
> @@ -18,3 +18,7 @@ TUNE_FEATURES_tune-core2-64 ?= "${TUNE_FEATURES_tune-x86-64} core2"
> BASE_LIB_tune-core2-64 ?= "lib64"
> PACKAGE_EXTRA_ARCHS_tune-core2-64 = "${PACKAGE_EXTRA_ARCHS_tune-x86-64} core2-64"
>
> +AVAILTUNES += "core2-x32"
> +TUNE_FEATURES_tune-core2-x32 ?= "${TUNE_FEATURES_tune-x86-64-x32} core2"
> +BASE_LIB_tune-core2-x32 ?= "lib"
> +PACKAGE_EXTRA_ARCHS_tune-core2-x32 = "${PACKAGE_EXTRA_ARCHS_tune-x86-64-x32} core2-x32"
PACKAGE_EXTRA_ARCHS_tune-core2-x32 = "${PACKAGE_EXTRA_ARCHS_tune-x86-64-x32} core2-64-x32"
Cheers,
Richard
next prev parent reply other threads:[~2011-08-05 16:09 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-04 15:01 [PATCH 00/10] Commits to enable x32 infrastructure nitin.a.kamble
2011-08-04 15:01 ` [PATCH 01/10] kern-tools: extend arbitrary repository support nitin.a.kamble
2011-08-05 4:09 ` Bruce Ashfield
2011-08-04 15:01 ` [PATCH 02/10] linux-yocto: process the existing branch for configuration nitin.a.kamble
2011-08-05 4:11 ` Bruce Ashfield
2011-08-04 15:01 ` [PATCH 03/10] linux-yocto: pass KMACHINE to updateme, not MACHINE nitin.a.kamble
2011-08-05 4:10 ` Bruce Ashfield
2011-08-04 15:01 ` [PATCH 04/10] glibc: bring back the needed support for glibc recipes nitin.a.kamble
2011-08-04 21:50 ` Phil Blundell
2011-08-04 22:04 ` Kamble, Nitin A
2011-08-04 22:10 ` Phil Blundell
2011-08-04 22:47 ` Kamble, Nitin A
2011-08-04 22:49 ` Tom Rini
2011-08-04 22:57 ` Kamble, Nitin A
2011-08-05 15:49 ` Richard Purdie
2011-08-04 23:33 ` Khem Raj
2011-08-04 22:48 ` Tom Rini
2011-08-04 22:58 ` Kamble, Nitin A
2011-08-04 23:39 ` Khem Raj
2011-08-04 23:18 ` Khem Raj
2011-08-05 1:09 ` Kamble, Nitin A
2011-08-05 15:52 ` Richard Purdie
2011-08-04 15:01 ` [PATCH 05/10] toolchain-scripts & other classes: add TARGET_LD_ARCH & TARGET_AS_ARCH vars nitin.a.kamble
2011-08-05 16:09 ` Richard Purdie
2011-08-04 15:01 ` [PATCH 06/10] kernel, module-base.bbclass: fix KERNEL_LD & KERNEL_AR vars nitin.a.kamble
2011-08-04 21:50 ` Phil Blundell
2011-08-04 22:03 ` Kamble, Nitin A
2011-08-05 7:52 ` Phil Blundell
2011-08-05 15:41 ` Kamble, Nitin A
2011-08-05 16:16 ` Richard Purdie
2011-08-04 15:01 ` [PATCH 07/10] siteinfo.bbclass: add entries for new x86_64 ABI targets nitin.a.kamble
2011-08-04 22:51 ` Tom Rini
2011-08-04 22:54 ` Kamble, Nitin A
2011-08-04 15:01 ` [PATCH 08/10] insane.bbclass: add entries for linux-gnu<ABI> nitin.a.kamble
2011-08-05 16:06 ` Richard Purdie
2011-08-05 16:56 ` Kamble, Nitin A
2011-08-04 15:01 ` [PATCH 09/10] x86 tune inc files: add x32 abi tune parameters nitin.a.kamble
2011-08-04 21:57 ` Phil Blundell
2011-08-04 22:18 ` Kamble, Nitin A
2011-08-04 22:29 ` Kamble, Nitin A
2011-08-05 7:50 ` Phil Blundell
2011-08-05 15:37 ` Kamble, Nitin A
2011-08-05 15:41 ` Phil Blundell
2011-08-05 15:44 ` Richard Purdie
2011-08-05 15:49 ` Phil Blundell
2011-08-05 16:04 ` Richard Purdie [this message]
2011-08-05 18:07 ` Kamble, Nitin A
2011-08-05 21:23 ` Saul Wold
2011-08-05 23:25 ` Kamble, Nitin A
2011-08-04 15:01 ` [PATCH 10/10] local.conf.sample: make BBMASK assignment weak nitin.a.kamble
2011-08-04 22:52 ` Tom Rini
2011-08-04 22:54 ` Kamble, Nitin A
2011-08-05 16:07 ` Richard Purdie
2011-08-05 16:20 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312560258.14274.125.camel@rex \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox