Re: [PATCH 10/10] local.conf.sample: make BBMASK assignment weak

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Thu, 2011-08-04 at 15:54 -0700, Kamble, Nitin A wrote:
> 
> > -----Original Message-----
> > From: openembedded-core-bounces@lists.openembedded.org
> > [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
> > Tom Rini
> > Sent: Thursday, August 04, 2011 3:53 PM
> > To: Patches and discussions about the oe-core layer
> > Subject: Re: [OE-core] [PATCH 10/10] local.conf.sample: make BBMASK
> > assignment weak
> > 
> > On Thu, Aug 4, 2011 at 8:01 AM,  <nitin.a.kamble@intel.com> wrote:
> > > From: Nitin A Kamble <nitin.a.kamble@intel.com>
> > >
> > > So that it can be overridden by layers if needed.
> > >
> > > Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> > > ---
> > >  meta-yocto/conf/local.conf.sample |    2 +-
> > >  1 files changed, 1 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/meta-yocto/conf/local.conf.sample b/meta-
> > yocto/conf/local.conf.sample
> > > index 3e71b0a..4acec37 100644
> > > --- a/meta-yocto/conf/local.conf.sample
> > > +++ b/meta-yocto/conf/local.conf.sample
> > > @@ -39,7 +39,7 @@ DISTRO ?= "poky"
> > >
> > >  # BBMASK is a regular expression that can be used to tell BitBake to
> > ignore
> > >  # certain recipes.
> > > -BBMASK = ""
> > > +BBMASK ?= ""
> > >
> > >  # EXTRA_IMAGE_FEATURES allows extra packages to be added to the
> > generated images
> > >  # (Some of these are automatically added to certain image types)
> > 
> > In oe.dev we just dropped this from local.conf iirc since a real
> > assignmnet was overriding a useful setting we provided.  IMHO, we
> > should do the same here (or at least comment it out).
> 
> I agree. We should comment it out.

I agree too.

Cheers,

Richard