Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] gtk-icon-cache bbclass: only add runtime dependencies on hicolor-icon-theme when installing icons
Date: Fri, 05 Aug 2011 17:27:34 +0100	[thread overview]
Message-ID: <1312561654.14274.136.camel@rex> (raw)
In-Reply-To: <58CFE121-CAEA-4ADD-AC97-6A03DDBA56C3@dominion.thruhere.net>

On Fri, 2011-08-05 at 07:55 +0200, Koen Kooi wrote:
> Op 5 aug. 2011, om 07:51 heeft Chris Larson het volgende geschreven:
> 
> > On Thu, Aug 4, 2011 at 10:48 PM, Koen Kooi <koen@dominion.thruhere.net> wrote:
> >> 
> >> Op 5 aug. 2011, om 07:32 heeft Saul Wold het volgende geschreven:
> >> 
> >>> On 08/04/2011 10:28 PM, Koen Kooi wrote:
> >>>> 
> >>>> Op 5 aug. 2011, om 04:23 heeft Saul Wold het volgende geschreven:
> >>>> 
> >>>>> On 08/01/2011 04:08 AM, Koen Kooi wrote:
> >>>>>> Tested with gnome-icon-theme and libsoup recipes on angstrom.
> >>>>>> 
> > 
> > Can someone explain why this patch added the dependency to the global
> > RDEPENDS, rather than the RDEPENDS_<pkg> for the pkg in question?
> 
> Ah, I assumed it was local to 'pkg' when iterating over packages.
> 
> So should it be:
> 
> rdepends = bb.data.getVar('RDEPENDS_%s' % pkg, d, 1)
> 
> [..]
> 
> bb.data.setVar('RDEPENDS_%s' % pkg, rdepends, d)
> 
> ?

Yes, it should.

Cheers,

Richard




  parent reply	other threads:[~2011-08-05 16:32 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-01 11:08 [PATCH] gtk-icon-cache bbclass: only add runtime dependencies on hicolor-icon-theme when installing icons Koen Kooi
2011-08-04 14:47 ` Saul Wold
2011-08-05  2:23 ` Saul Wold
2011-08-05  5:28   ` Koen Kooi
2011-08-05  5:32     ` Saul Wold
2011-08-05  5:48       ` Koen Kooi
2011-08-05  5:51         ` Chris Larson
2011-08-05  5:55           ` Koen Kooi
2011-08-05  7:00             ` Chris Larson
2011-08-05  7:16               ` Koen Kooi
2011-08-05 16:27             ` Richard Purdie [this message]
2011-08-05 17:34               ` Koen Kooi
2011-08-05  6:44         ` Koen Kooi
2011-08-05  6:51           ` Koen Kooi
2011-08-05 12:42             ` Kumar Gala
2011-08-05 13:19               ` Richard Purdie
2011-08-05 14:16                 ` Koen Kooi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1312561654.14274.136.camel@rex \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox