From: Saul Wold <sgw@linux.intel.com>
To: Koen Kooi <koen@dominion.thruhere.net>
Cc: Koen Kooi <koen@openembedded.org>,
Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] gtk-icon-cache bbclass: only add runtime dependencies on hicolor-icon-theme when installing icons
Date: Thu, 04 Aug 2011 22:32:50 -0700 [thread overview]
Message-ID: <4E3B8082.5010909@linux.intel.com> (raw)
In-Reply-To: <ADE3B9A3-1B0B-4ECA-A472-D241AA542051@dominion.thruhere.net>
On 08/04/2011 10:28 PM, Koen Kooi wrote:
>
> Op 5 aug. 2011, om 04:23 heeft Saul Wold het volgende geschreven:
>
>> On 08/01/2011 04:08 AM, Koen Kooi wrote:
>>> Tested with gnome-icon-theme and libsoup recipes on angstrom.
>>>
>> But you did not test it against anything in oe-core, it has broken the build for connman-gnome and oprofileui, which use this bbclass.
>>
>> The oe-core gnome-icon-theme does not include this class.
>>
>> Please correct this.
>>
>> Processing task-base-extended...
>> | error: Failed dependencies:
>> | hicolor-icon-theme is needed by tasks-0.19-r0.armv5te
>> | hicolor-icon-theme is needed by connman-gnome-0.5-r6.armv5te
>> | hicolor-icon-theme is needed by oprofileui-server-0.0+git1+0c3c32fa754c1d0b70e65767ea7048914f776396-r4.armv5te
>
> So you found broken metadata. If tasks, connman-gnome and oprofileui-server need hicolor-icon-theme, they should list it in their RDEPENDS_${PN}. That is a seperate issue than what I fixed in the bbclass
Koen, the gtk-icon-cache.bbclass did contain that RDEPENDS, which you
removed, if you are going to modify bbclasses, you need to ensure that
the recipes using them still work correctly. Your fix broke others,
please take the time to test against oe-core also.
(and yes we have all made changes that break other distros, there's no
way test all, but this broke oe-core).
I look forward to a fix.
Thanks
Sau!
next prev parent reply other threads:[~2011-08-05 5:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-01 11:08 [PATCH] gtk-icon-cache bbclass: only add runtime dependencies on hicolor-icon-theme when installing icons Koen Kooi
2011-08-04 14:47 ` Saul Wold
2011-08-05 2:23 ` Saul Wold
2011-08-05 5:28 ` Koen Kooi
2011-08-05 5:32 ` Saul Wold [this message]
2011-08-05 5:48 ` Koen Kooi
2011-08-05 5:51 ` Chris Larson
2011-08-05 5:55 ` Koen Kooi
2011-08-05 7:00 ` Chris Larson
2011-08-05 7:16 ` Koen Kooi
2011-08-05 16:27 ` Richard Purdie
2011-08-05 17:34 ` Koen Kooi
2011-08-05 6:44 ` Koen Kooi
2011-08-05 6:51 ` Koen Kooi
2011-08-05 12:42 ` Kumar Gala
2011-08-05 13:19 ` Richard Purdie
2011-08-05 14:16 ` Koen Kooi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E3B8082.5010909@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=koen@dominion.thruhere.net \
--cc=koen@openembedded.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox