Re: [PATCH] tune-ppce5500: Add a tune file for PowerPC e5500 core

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Mon, 2011-08-08 at 09:39 -0500, Kumar Gala wrote:
> On Aug 5, 2011, at 3:11 PM, Kumar Gala wrote:
> 
> > Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> > ---
> > meta/conf/machine/include/tune-ppce5500.inc |   14 ++++++++++++++
> > 1 files changed, 14 insertions(+), 0 deletions(-)
> > create mode 100644 meta/conf/machine/include/tune-ppce5500.inc
> > 
> > diff --git a/meta/conf/machine/include/tune-ppce5500.inc b/meta/conf/machine/include/tune-ppce5500.inc
> > new file mode 100644
> > index 0000000..8e6403d
> > --- /dev/null
> > +++ b/meta/conf/machine/include/tune-ppce5500.inc
> > @@ -0,0 +1,14 @@
> > +DEFAULTTUNE ?= "ppce5500"
> > +
> > +require conf/machine/include/powerpc/arch-powerpc64.inc
> > +
> > +TUNEVALID[ppce5500] = "Enable ppce5500 specific processor optimizations"
> > +TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "ppce5500", "-mcpu=e5500", "", d)}"
> > +TUNE_PKGARCH = "${@bb.utils.contains("TUNE_FEATURES", "ppce5500", "ppce5500", "${PPCPKGARCH}", d)}"
> > +
> > +AVAILTUNES += "ppce5500"
> > +TUNE_FEATURES_tune-ppce5500 = "m64 ppce5500"
> > +PACKAGE_EXTRA_ARCHS_tune-ppce5500 = "powerpc64 ppce5500"
> > +
> > +# glibc configure options to get e5500 specific library (for sqrt)
> > +GLIBC_EXTRA_OECONF += "--with-cpu=e5500"
> > -- 
> > 1.7.3.4
> 
> If I want to have a version of this for 32-bit only (or default) and one for 64-bit, how would it be best to handle that?

I was wondering about this. You really need to make it conditional on
something, e.g.

GLIBC_EXTRA_OECONF += "${@bb.utils.contains("TUNE_FEATURES", "m32", ""--with-cpu=e5500", "", d)}"

however, if you do this you need to ensure that TUNE_PKGARCH is not
powerpc but something e5500 specific at this point since you are
enabling e5500 specific optimisations.

Cheers,

Richard