Re: [PATCH] tune-ppce5500: Add a tune file for PowerPC e5500 core

[Khem Raj <raj.khem@gmail.com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/05/2011 01:11 PM, Kumar Gala wrote:
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org> --- 
> meta/conf/machine/include/tune-ppce5500.inc |   14 ++++++++++++++ 1
> files changed, 14 insertions(+), 0 deletions(-) create mode 100644
> meta/conf/machine/include/tune-ppce5500.inc
> 
> diff --git a/meta/conf/machine/include/tune-ppce5500.inc
> b/meta/conf/machine/include/tune-ppce5500.inc new file mode 100644 
> index 0000000..8e6403d --- /dev/null +++
> b/meta/conf/machine/include/tune-ppce5500.inc @@ -0,0 +1,14 @@ 
> +DEFAULTTUNE ?= "ppce5500" + +require
> conf/machine/include/powerpc/arch-powerpc64.inc + 
> +TUNEVALID[ppce5500] = "Enable ppce5500 specific processor
> optimizations"

just a nit may be it should read "Enable ppce5500 processor specific
optimizations"

> +TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "ppce5500",
> "-mcpu=e5500", "", d)}" +TUNE_PKGARCH =
> "${@bb.utils.contains("TUNE_FEATURES", "ppce5500", "ppce5500",
> "${PPCPKGARCH}", d)}" + +AVAILTUNES += "ppce5500" 
> +TUNE_FEATURES_tune-ppce5500 = "m64 ppce5500" 
> +PACKAGE_EXTRA_ARCHS_tune-ppce5500 = "powerpc64 ppce5500" + +# glibc
> configure options to get e5500 specific library (for sqrt) 
> +GLIBC_EXTRA_OECONF += "--with-cpu=e5500"

hmm so this essentially makes eglibc specific to this processor. Does it
build eglibc inside work/ppce5500-oe-linux-gnuspe dir ? or something
generic e.g. powerpc64-oe-linux-gnuspe dir ? In case its former then all
is well but latter case may not be ok since we may not be able to share
eglibc binaries with similar implementations of ppc64 in this case

I am more worried about proliferation into other architectures e.g. arm
which has multiple armv7 implementations e.g.
- -- 
- -Khem
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk48XecACgkQuwUzVZGdMxRMtwCfVFeKRwn9xv8pksvWDi2r9VAG
ntUAnjudbnXU2uiM1nINLU/rmtlIb4dT
=re3u
-----END PGP SIGNATURE-----