Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] gcc: use ${base_lib} to match gcc default configuration
Date: Thu, 11 Aug 2011 19:41:16 +0100	[thread overview]
Message-ID: <1313088076.14274.461.camel@rex> (raw)
In-Reply-To: <1313076641.14274.431.camel@rex>

On Thu, 2011-08-11 at 16:30 +0100, Richard Purdie wrote:
> On Thu, 2011-08-11 at 01:47 -0500, Kumar Gala wrote:
> > revert this is not acceptable as that will break ppc64 builds.
> > 
> > I think you need to look at 64bithack.patch and if we really should be using it for multilib builds.
> 
> This just sounds like gcc totally ignores the the library directory
> we're using and that is plain wrong :(.
> 
> I'd much prefer gcc didn't make assumptions in this case and did what
> were were configuring it to do. That is why there is that 64bit hack
> there and I think gcc should be honouring however we configure the
> library directories, not doing what it thinks is best...

I did more digging and this really just highlights why we have that
64bit "hack" patch in the first place.

GCC has internal multilib 'magic' which assumes certain library layout
in the 64 bit case. The implication is if you build 64 bit, you cannot
have baselib != "lib64". Whilst I can understand this on desktop system,
I'd suggest our build system has a better idea what its doing than most
and can cope without hardcoding things.

This is why the default builds in the gcc config are set to "." by that
patch, that respects whatever base_libdir is set to. I'd suggest we do
this for x86, pcc and mips 64 bit and revert the origin baselib patch,
but this time better improve the patch documentation about why this is
necessary.

Cheers,

Richard




  reply	other threads:[~2011-08-11 18:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-04 18:54 [PATCH] gcc: use ${base_lib} to match gcc default configuration Kumar Gala
2011-08-05 16:53 ` Kumar Gala
2011-08-05 16:56   ` Saul Wold
2011-08-11  6:36 ` Yu Ke
2011-08-11  6:47   ` Kumar Gala
2011-08-11  7:45     ` Yu Ke
2011-08-11 14:54       ` Khem Raj
2011-08-11 15:30     ` Richard Purdie
2011-08-11 18:41       ` Richard Purdie [this message]
2011-08-11 18:55         ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1313088076.14274.461.camel@rex \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox