Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Yu Ke <ke.yu@intel.com>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] gcc: use ${base_lib} to match gcc default configuration
Date: Thu, 11 Aug 2011 15:45:01 +0800	[thread overview]
Message-ID: <4E43887D.6000908@intel.com> (raw)
In-Reply-To: <1D98D492-1D74-49DE-A884-C919AFF30BDD@kernel.crashing.org>

Ok, CC Richard to see if it is OK to not use 64bithack.patch

Regards
Ke

on 2011-8-11 14:47, Kumar Gala wrote:
> revert this is not acceptable as that will break ppc64 builds.
>
> I think you need to look at 64bithack.patch and if we really should be using it for multilib builds.
>
> - k
>
> On Aug 11, 2011, at 1:36 AM, Yu Ke wrote:
>
>> Hi Kumar,
>>
>> I just found this patch breaks the qemux86-64 lib64 multilib build.
>>
>> the error log is as below:
>>
>> | mv: cannot stat `/home/kyu3/sdb/multilib2/tmp/work/x86_64-pokymllib64-linux/lib64-gcc-cross-intermediate-4.6.1+svnr175454-r4/image/home/kyu3/sdb/multilib2/tmp/sysroots/x86_64-linux/usr/x86_64-pokymllib64-linux/lib64/*': No such file or directory
>> NOTE: package lib64-gcc-cross-intermediate-4.6.1+svnr175454-r4: task do_install: Failed
>> ERROR: Task 1557 (virtual:multilib:lib64:/home/kyu3/src/poky/meta/recipes-devtools/gcc/gcc-cross-intermediate_4.6.bb, do_install) failed with exit code
>>
>> the error is caused by command in gcc-cross-intermediate.inc: do_install(): "mv ${D}${exec_prefix}/${TARGET_SYS}/${baselib}/* ${D}${target_base_libdir}/"
>>
>> and the reason is that: ${baselib} is lib64 in multilib case, while the files to be moved is still in ${D}${exec_prefix}/${TARGET_SYS}/lib/*, so mv will fail.
>>
>> The fix may be either reverting this commit, or putting the file to ${baselib} instead of lib. I'd like to get your input before going further.
>>
>> Regards
>> Ke
>>
>> on 2011-8-5 2:54, Kumar Gala wrote:
>>> Rather than tweaking MULTILIB_DIRNAMES&   MULTILIB_OSDIRNAMES like is
>>> done for x86-64 via 64bithack.patch.  We can just go with gcc defaults
>>> and utilize ${base_lib} for where to find gcc libs.
>>>
>>> Signed-off-by: Kumar Gala<galak@kernel.crashing.org>
>>> ---
>>>   .../gcc/gcc-cross-intermediate.inc                 |    2 +-
>>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/meta/recipes-devtools/gcc/gcc-cross-intermediate.inc b/meta/recipes-devtools/gcc/gcc-cross-intermediate.inc
>>> index df5958a..7b1bb38 100644
>>> --- a/meta/recipes-devtools/gcc/gcc-cross-intermediate.inc
>>> +++ b/meta/recipes-devtools/gcc/gcc-cross-intermediate.inc
>>> @@ -34,7 +34,7 @@ do_compile () {
>>>   do_install () {
>>>   	oe_runmake 'DESTDIR=${D}' install
>>>   	install -d ${D}${target_base_libdir}/
>>> -	mv ${D}${exec_prefix}/${TARGET_SYS}/lib/* ${D}${target_base_libdir}/
>>> +	mv ${D}${exec_prefix}/${TARGET_SYS}/${baselib}/* ${D}${target_base_libdir}/
>>>
>>>   	# We don't really need this (here shares/ contains man/, info/, locale/).
>>>   	rm -rf ${D}${datadir}/
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>




  reply	other threads:[~2011-08-11  7:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-04 18:54 [PATCH] gcc: use ${base_lib} to match gcc default configuration Kumar Gala
2011-08-05 16:53 ` Kumar Gala
2011-08-05 16:56   ` Saul Wold
2011-08-11  6:36 ` Yu Ke
2011-08-11  6:47   ` Kumar Gala
2011-08-11  7:45     ` Yu Ke [this message]
2011-08-11 14:54       ` Khem Raj
2011-08-11 15:30     ` Richard Purdie
2011-08-11 18:41       ` Richard Purdie
2011-08-11 18:55         ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E43887D.6000908@intel.com \
    --to=ke.yu@intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox