[PATCH 0/1] The Skeleton initscript doesn't work on minimal image

[PATCH 0/1] The Skeleton initscript doesn't work on minimal image

[Robert Yang]

Testing:
1) Edit meta/recipes-core/images/core-image-minimal.bb, add "service" to
   the IMAGE_INSTALL

2) Edit build/conf/local.conf, add "/path/to/poky/meta-skeleton" to the
   BBLAYERS.

3) $ bitbake core-image-minimal(or sato)

3) start qemu, and run "/etc/init.d/skeleton start(or status stop ..)",
   it works well

// Robert

The following changes since commit 30381645eefe4e3222fd3ce45823f143ce2fa82c:

  rt-tests: use an explicit commit ID (2011-08-12 21:07:02 +0100)

are available in the git repository at:
  git://git.pokylinux.org/poky-contrib robert/initscripts
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/initscripts

Robert Yang (1):
  The Skeleton initscript doesn't work on minimal image

 .../initscripts/initscripts-1.0/functions          |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

[PATCH 1/1] The Skeleton initscript doesn't work on minimal image

[Robert Yang]

Fixes bug [YOCTO #1165]

The /etc/init.d/skeleton doesn't work on minimal image, this is
because of the pidofproc doesn't return "$?" correctly, so store
$? in the variable status would fix it.

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 .../initscripts/initscripts-1.0/functions          |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-core/initscripts/initscripts-1.0/functions b/meta/recipes-core/initscripts/initscripts-1.0/functions
index c1eac3e..dd7da2b 100644
--- a/meta/recipes-core/initscripts/initscripts-1.0/functions
+++ b/meta/recipes-core/initscripts/initscripts-1.0/functions
@@ -18,7 +18,8 @@ pidofproc () {
 
 	# pidof output null when no program is running, so no "2>/dev/null".
 	pid=`pidof $1`
-	case $? in
+	status=$?
+	case $status in
 	0)
 		echo $pid
 		return 0
@@ -28,7 +29,7 @@ pidofproc () {
 		exit 127
 		;;
 	*)
-		return $?
+		return $status
 		;;
 	esac
 }
-- 
1.7.1

Re: [PATCH 0/1] The Skeleton initscript doesn't work on minimal image

[Richard Purdie]

On Mon, 2011-08-15 at 18:18 +0800, Robert Yang wrote:
> Testing:
> 1) Edit meta/recipes-core/images/core-image-minimal.bb, add "service" to
>    the IMAGE_INSTALL
> 
> 2) Edit build/conf/local.conf, add "/path/to/poky/meta-skeleton" to the
>    BBLAYERS.
> 
> 3) $ bitbake core-image-minimal(or sato)
> 
> 3) start qemu, and run "/etc/init.d/skeleton start(or status stop ..)",
>    it works well
> 
> // Robert
> 
> The following changes since commit 30381645eefe4e3222fd3ce45823f143ce2fa82c:
> 
>   rt-tests: use an explicit commit ID (2011-08-12 21:07:02 +0100)
> 
> are available in the git repository at:
>   git://git.pokylinux.org/poky-contrib robert/initscripts
>   http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/initscripts
> 
> Robert Yang (1):
>   The Skeleton initscript doesn't work on minimal image

Merged to master, thanks.

Richard