Re: [PATCH 1/1] gcc-cross-intermediate: revise the 64bithack.patch for multilib case

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Mon, 2011-08-15 at 22:24 +0800, Yu Ke wrote:
> On 2011/8/15 21:16, Richard Purdie wrote:
> > On Mon, 2011-08-15 at 20:48 +0800, Yu Ke wrote:
> >> On 2011/8/15 1:31, Koen Kooi wrote:
> >>>
> >>> Op 14 aug. 2011, om 15:32 heeft Yu Ke het volgende geschreven:
> >>>
> >>>> current gcc-cross-intermediate has build failure in qemux86-64 lib64
> >>>> multilib case. the reason is that it still use lib instead of lib64
> >>>> while do_install use the libdir i.e. lib64
> >>>>
> >>>> so this patch fix this issue by making gcc honour the libdir.
> >>>>
> >>>> CC: Kumar Gala<galak@kernel.crashing.org>
> >>>> CC: Richard Purdie<richard.purdie@linuxfoundation.org>
> >>>>
> >>>> Signed-off-by: Yu Ke<ke.yu@intel.com>
> >>>> ---
> >>>> meta/recipes-devtools/gcc/gcc-4.6.inc             |    2 +-
> >>>> meta/recipes-devtools/gcc/gcc-4.6/64bithack.patch |   16 +++++++++-------
> >>>
> >>> wouldn't gcc 4.5 need a similar change?
> >>
> >> yes, gcc 4.5 should also has this change. I will sent out another patch
> >> for this.
> >
> > Please take a look at:
> >
> > http://git.yoctoproject.org/cgit.cgi/poky-contrib/commit/?h=rpurdie/ml4&id=4de8e0e9c286ff64f1b7fd2e695fe2d62fdadfbd
> 
> Thanks. it is more comprehensive. just a small issue, the parentheses 
> looks mismatching in
> 
> ++MULTILIB_OSDIRNAMES = ../$(shell basename $(base_libdir) ../$(shell 
> basename $(base_libdir)

Right, I've just noticed my test build was failing and that is likely
why :)

> > I've updated the patch header and ensured that whichever compiler
> > options are used, the compiler works as expected and also applied this
> > to mips and pcc.
> >
> > Could you also please open a bug about target gcc multilib as mentioned
> > in the patch header (targeted at post 1.1).
> 
> done. http://bugzilla.yoctoproject.org/show_bug.cgi?id=1369

Great, thanks.

Cheers,

Richard