Re: [PATCH 1/1] gcc-cross-intermediate: revise the 64bithack.patch for multilib case

From: Yu Ke <ke@linux.intel.com>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Cc: Koen Kooi <koen@dominion.thruhere.net>
Subject: Re: [PATCH 1/1] gcc-cross-intermediate: revise the 64bithack.patch for multilib case
Date: Mon, 15 Aug 2011 22:24:17 +0800	[thread overview]
Message-ID: <4E492C11.5040800@linux.intel.com> (raw)
In-Reply-To: <1313414185.14274.576.camel@rex>

On 2011/8/15 21:16, Richard Purdie wrote:
> On Mon, 2011-08-15 at 20:48 +0800, Yu Ke wrote:
>> On 2011/8/15 1:31, Koen Kooi wrote:
>>>
>>> Op 14 aug. 2011, om 15:32 heeft Yu Ke het volgende geschreven:
>>>
>>>> current gcc-cross-intermediate has build failure in qemux86-64 lib64
>>>> multilib case. the reason is that it still use lib instead of lib64
>>>> while do_install use the libdir i.e. lib64
>>>>
>>>> so this patch fix this issue by making gcc honour the libdir.
>>>>
>>>> CC: Kumar Gala<galak@kernel.crashing.org>
>>>> CC: Richard Purdie<richard.purdie@linuxfoundation.org>
>>>>
>>>> Signed-off-by: Yu Ke<ke.yu@intel.com>
>>>> ---
>>>> meta/recipes-devtools/gcc/gcc-4.6.inc             |    2 +-
>>>> meta/recipes-devtools/gcc/gcc-4.6/64bithack.patch |   16 +++++++++-------
>>>
>>> wouldn't gcc 4.5 need a similar change?
>>
>> yes, gcc 4.5 should also has this change. I will sent out another patch
>> for this.
>
> Please take a look at:
>
> http://git.yoctoproject.org/cgit.cgi/poky-contrib/commit/?h=rpurdie/ml4&id=4de8e0e9c286ff64f1b7fd2e695fe2d62fdadfbd

Thanks. it is more comprehensive. just a small issue, the parentheses 
looks mismatching in

++MULTILIB_OSDIRNAMES = ../$(shell basename $(base_libdir) ../$(shell 
basename $(base_libdir)

>
> I've updated the patch header and ensured that whichever compiler
> options are used, the compiler works as expected and also applied this
> to mips and pcc.
>
> Could you also please open a bug about target gcc multilib as mentioned
> in the patch header (targeted at post 1.1).

done. http://bugzilla.yoctoproject.org/show_bug.cgi?id=1369

>
>> just curious question, what is gcc 4.5 for, since gcc 4.6 is already there?
>
> Some people are still using gcc 4.5 for various reasons. It is getting
> to the point we should probably move that to meta-oe though?
>
> Cheers,
>
> Richard
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>