Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] terminal: fix issue with unset exportable env vars
@ 2011-08-24 20:00 Chris Larson
  2011-08-25  1:31 ` Richard Purdie
  0 siblings, 1 reply; 2+ messages in thread
From: Chris Larson @ 2011-08-24 20:00 UTC (permalink / raw)
  To: openembedded-core; +Cc: Chris Larson

From: Chris Larson <chris_larson@mentor.com>

This should resolve the devshell issue people are seeing.

Signed-off-by: Chris Larson <chris_larson@mentor.com>
---
 meta/classes/terminal.bbclass |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/meta/classes/terminal.bbclass b/meta/classes/terminal.bbclass
index 4123046..f29aeb0 100644
--- a/meta/classes/terminal.bbclass
+++ b/meta/classes/terminal.bbclass
@@ -30,7 +30,9 @@ def oe_terminal(command, title, d):
 
     env = dict(os.environ)
     for export in oe.data.typed_value('OE_TERMINAL_EXPORTS', d):
-        env[export] = d.getVar(export, True)
+        value = d.getVar(export, True)
+        if value is not None:
+            env[export] = str(value)
 
     try:
         oe.terminal.spawn_preferred(command, title, env)
-- 
1.7.4.1




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] terminal: fix issue with unset exportable env vars
  2011-08-24 20:00 [PATCH] terminal: fix issue with unset exportable env vars Chris Larson
@ 2011-08-25  1:31 ` Richard Purdie
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Purdie @ 2011-08-25  1:31 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer; +Cc: Chris Larson

On Wed, 2011-08-24 at 13:00 -0700, Chris Larson wrote:
> From: Chris Larson <chris_larson@mentor.com>
> 
> This should resolve the devshell issue people are seeing.
> 
> Signed-off-by: Chris Larson <chris_larson@mentor.com>
> ---
>  meta/classes/terminal.bbclass |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)

Merged to master, thanks.

Richard




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-08-25  1:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-24 20:00 [PATCH] terminal: fix issue with unset exportable env vars Chris Larson
2011-08-25  1:31 ` Richard Purdie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox