Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Joshua Lock <josh@linux.intel.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] useradd.bbclass: remove hardcoded reference to /usr/bin
Date: Thu, 01 Sep 2011 08:57:50 -0700	[thread overview]
Message-ID: <1314892671.3449.0.camel@scimitar> (raw)
In-Reply-To: <1314889432.19905.189.camel@phil-desktop>

On Thu, 2011-09-01 at 16:03 +0100, Phil Blundell wrote:
> Otherwise the class doesn't work if ${bindir} is set to a different value;
> likewise for /var vs ${localstatedir}.
> 
> Signed-off-by: Phil Blundell <philb@gnu.org>

Good find!

Signed-off-by: Joshua Lock <josh@linux.intel.com>
> ---
>  meta/classes/useradd.bbclass |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/classes/useradd.bbclass b/meta/classes/useradd.bbclass
> index ba8d8dc..5f5b68d 100644
> --- a/meta/classes/useradd.bbclass
> +++ b/meta/classes/useradd.bbclass
> @@ -74,8 +74,8 @@ fi
>  }
>  
>  useradd_sysroot () {
> -	export PSEUDO="${STAGING_DIR_NATIVE}/usr/bin/pseudo"
> -	export PSEUDO_LOCALSTATEDIR="${STAGING_DIR_TARGET}/var/pseudo"
> +	export PSEUDO="${STAGING_DIR_NATIVE}${bindir}/pseudo"
> +	export PSEUDO_LOCALSTATEDIR="${STAGING_DIR_TARGET}${localstatedir}/pseudo"
>  
>  	# Explicitly set $D since it isn't set to anything
>  	# before do_install

-- 
Joshua Lock
        Yocto Project "Johannes factotum"
        Intel Open Source Technology Centre




  reply	other threads:[~2011-09-01 16:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-01 15:03 [PATCH] useradd.bbclass: remove hardcoded reference to /usr/bin Phil Blundell
2011-09-01 15:57 ` Joshua Lock [this message]
2011-09-02 17:27 ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1314892671.3449.0.camel@scimitar \
    --to=josh@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox