Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] useradd.bbclass: remove hardcoded reference to /usr/bin
@ 2011-09-01 15:03 Phil Blundell
  2011-09-01 15:57 ` Joshua Lock
  2011-09-02 17:27 ` Richard Purdie
  0 siblings, 2 replies; 3+ messages in thread
From: Phil Blundell @ 2011-09-01 15:03 UTC (permalink / raw)
  To: oe-core

Otherwise the class doesn't work if ${bindir} is set to a different value;
likewise for /var vs ${localstatedir}.

Signed-off-by: Phil Blundell <philb@gnu.org>
---
 meta/classes/useradd.bbclass |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/classes/useradd.bbclass b/meta/classes/useradd.bbclass
index ba8d8dc..5f5b68d 100644
--- a/meta/classes/useradd.bbclass
+++ b/meta/classes/useradd.bbclass
@@ -74,8 +74,8 @@ fi
 }
 
 useradd_sysroot () {
-	export PSEUDO="${STAGING_DIR_NATIVE}/usr/bin/pseudo"
-	export PSEUDO_LOCALSTATEDIR="${STAGING_DIR_TARGET}/var/pseudo"
+	export PSEUDO="${STAGING_DIR_NATIVE}${bindir}/pseudo"
+	export PSEUDO_LOCALSTATEDIR="${STAGING_DIR_TARGET}${localstatedir}/pseudo"
 
 	# Explicitly set $D since it isn't set to anything
 	# before do_install
-- 
1.7.4.1






^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] useradd.bbclass: remove hardcoded reference to /usr/bin
  2011-09-01 15:03 [PATCH] useradd.bbclass: remove hardcoded reference to /usr/bin Phil Blundell
@ 2011-09-01 15:57 ` Joshua Lock
  2011-09-02 17:27 ` Richard Purdie
  1 sibling, 0 replies; 3+ messages in thread
From: Joshua Lock @ 2011-09-01 15:57 UTC (permalink / raw)
  To: openembedded-core

On Thu, 2011-09-01 at 16:03 +0100, Phil Blundell wrote:
> Otherwise the class doesn't work if ${bindir} is set to a different value;
> likewise for /var vs ${localstatedir}.
> 
> Signed-off-by: Phil Blundell <philb@gnu.org>

Good find!

Signed-off-by: Joshua Lock <josh@linux.intel.com>
> ---
>  meta/classes/useradd.bbclass |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/classes/useradd.bbclass b/meta/classes/useradd.bbclass
> index ba8d8dc..5f5b68d 100644
> --- a/meta/classes/useradd.bbclass
> +++ b/meta/classes/useradd.bbclass
> @@ -74,8 +74,8 @@ fi
>  }
>  
>  useradd_sysroot () {
> -	export PSEUDO="${STAGING_DIR_NATIVE}/usr/bin/pseudo"
> -	export PSEUDO_LOCALSTATEDIR="${STAGING_DIR_TARGET}/var/pseudo"
> +	export PSEUDO="${STAGING_DIR_NATIVE}${bindir}/pseudo"
> +	export PSEUDO_LOCALSTATEDIR="${STAGING_DIR_TARGET}${localstatedir}/pseudo"
>  
>  	# Explicitly set $D since it isn't set to anything
>  	# before do_install

-- 
Joshua Lock
        Yocto Project "Johannes factotum"
        Intel Open Source Technology Centre




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] useradd.bbclass: remove hardcoded reference to /usr/bin
  2011-09-01 15:03 [PATCH] useradd.bbclass: remove hardcoded reference to /usr/bin Phil Blundell
  2011-09-01 15:57 ` Joshua Lock
@ 2011-09-02 17:27 ` Richard Purdie
  1 sibling, 0 replies; 3+ messages in thread
From: Richard Purdie @ 2011-09-02 17:27 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer

On Thu, 2011-09-01 at 16:03 +0100, Phil Blundell wrote:
> Otherwise the class doesn't work if ${bindir} is set to a different value;
> likewise for /var vs ${localstatedir}.
> 
> Signed-off-by: Phil Blundell <philb@gnu.org>
> ---
>  meta/classes/useradd.bbclass |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Merged to master, thanks.

Richard




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-09-02 17:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-01 15:03 [PATCH] useradd.bbclass: remove hardcoded reference to /usr/bin Phil Blundell
2011-09-01 15:57 ` Joshua Lock
2011-09-02 17:27 ` Richard Purdie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox