From: Joshua Lock <josh@linux.intel.com>
To: openembedded-core@lists.openembedded.org
Subject: [RFC] Suggestion of minor change to patch submission policy re: long descriptions in commit headers
Date: Tue, 13 Sep 2011 17:46:38 -0700 [thread overview]
Message-ID: <1315961204.2252.32.camel@scimitar> (raw)
Our patch submission policy[1]
"Optionally, you may include pointers to defects this change corrects.
Unless the defect format is specified by the component you are
modifying, it is suggested that you use a full URL to specify the
reference to the defect information. Generally these pointers will
precede any long description, but as an optional item it may be after
the long description."
I've been guilty of always having the defect id after the description,
and have never included the defect URL (though my reading suggests this
is not required for Yocto defects I still believe this will make the
defect id's more useful for fellow OE-Core developers).
Whilst I intend to rectify the latter I'd like to propose we change the
former such that the defect information is at the end of the commit
message.
I believe this is more suitable for the project because the defect
information and its relevance should be summarised in the long
description, and therefore the defect id and link to the defect tracker
are supplemental information for interested readers.
IMHO this supplementary nature should lead us to request submitters
provide defect information after the long description.
Thoughts?
Regards,
Joshua
1.
http://openembedded.org/index.php?title=Commit_Patch_Message_Guidelines#New_Development
--
Joshua Lock
Yocto Project "Johannes factotum"
Intel Open Source Technology Centre
next reply other threads:[~2011-09-14 0:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-14 0:46 Joshua Lock [this message]
2011-09-14 0:58 ` [RFC] Suggestion of minor change to patch submission policy re: long descriptions in commit headers Mark Hatle
2011-09-14 6:54 ` Saul Wold
2011-09-14 9:30 ` Phil Blundell
2011-09-16 17:03 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1315961204.2252.32.camel@scimitar \
--to=josh@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox