From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [RFC] Suggestion of minor change to patch submission policy re: long descriptions in commit headers
Date: Fri, 16 Sep 2011 18:03:32 +0100 [thread overview]
Message-ID: <1316192620.20858.50.camel@ted> (raw)
In-Reply-To: <1315992658.2519.137.camel@phil-desktop>
On Wed, 2011-09-14 at 10:30 +0100, Phil Blundell wrote:
> On Tue, 2011-09-13 at 17:46 -0700, Joshua Lock wrote:
> > Whilst I intend to rectify the latter I'd like to propose we change the
> > former such that the defect information is at the end of the commit
> > message.
> >
> > I believe this is more suitable for the project because the defect
> > information and its relevance should be summarised in the long
> > description, and therefore the defect id and link to the defect tracker
> > are supplemental information for interested readers.
> >
> > IMHO this supplementary nature should lead us to request submitters
> > provide defect information after the long description.
>
> Agreed, I think this would be something of an improvement (and indeed,
> from a look at the git log it appears that some submitters are already
> doing this). Although it isn't a very big deal, I do find it slightly
> irritating to have the first line of the long checkin message be
> something that is essentially noise.
In case it wasn't clear, I'm also in favour of moving this to the bottom
of long description rather than the top.
I think including this information is fine since it does give people
some idea where to look for more information although equally the commit
messages should give suitable information in their own right and this
isn't a replacement for that.
Cheers,
Richard
prev parent reply other threads:[~2011-09-16 17:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-14 0:46 [RFC] Suggestion of minor change to patch submission policy re: long descriptions in commit headers Joshua Lock
2011-09-14 0:58 ` Mark Hatle
2011-09-14 6:54 ` Saul Wold
2011-09-14 9:30 ` Phil Blundell
2011-09-16 17:03 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316192620.20858.50.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox