From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Saul Wold <sgw@linux.intel.com>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] insane: Promote most warnings into QA errors by default
Date: Tue, 27 Sep 2011 11:02:24 +0100 [thread overview]
Message-ID: <1317117752.26109.142.camel@ted> (raw)
In-Reply-To: <4E8105D1.70409@linux.intel.com>
On Mon, 2011-09-26 at 16:08 -0700, Saul Wold wrote:
> On 09/26/2011 02:51 PM, Richard Purdie wrote:
> > On Mon, 2011-09-26 at 21:24 +0100, Richard Purdie wrote:
> >> We agreed a while back that we'd start ERRORing on QA issues, not just
> >> WARNING about them. This patch changes the default QA levels to error
> >> on everything except ldflag and useless rpath issues.
> >>
> >> It also stops giving out QA warnings about desktop files since it
> >> adds noise to the build and until someone plans to seriously tackle
> >> that problem, its pointless.
> >>
> >> We can promote the ldflag and rpath warnings too, when the issues
> >> in OE-Core are resolved (they're mostly there now, jsut a few more
> >> to go).
> >>
> >> Signed-off-by: Richard Purdie<richard.purdie@linuxfoundation.org>
> >> ---
> >> diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
> >> index addb9ac..62935c3 100644
> >> --- a/meta/classes/insane.bbclass
> >> +++ b/meta/classes/insane.bbclass
> >> @@ -99,9 +99,9 @@ def package_qa_get_machine_dict():
> >> }
> >>
> >>
> >> -WARN_QA ?= "dev-so rpaths debug-deps dev-deps debug-files arch la2 pkgconfig desktop la ldflags perms useless-rpaths"
> >> -ERROR_QA ?= ""
> >> -#ERROR_QA ?= "rpaths debug-deps dev-deps debug-files arch pkgconfig perms"
> >> +# Currently not being used by default "desktop"
> >> +WARN_QA ?= "ldflags useless-rpaths"
> >> +ERROR_QA ?= "dev-so rpaths debug-deps dev-deps debug-files arch la2 pkgconfig la perms"
> >>
> >
> > Further testing shows we may not be ready to move rpath to ERROR_QA
> > quite yet but the rest of the proposal still stands...
> >
> How bad is the breakage in a world build?
>
> I will probably attempt this later or tomorrow.
I tested world on qemux86 and qemuarm and fixed all the issues the above
change would error on ignoring rpath/ldflags/desktop. The list of issues
I posted earlier was against world for the other pieces, again ignoring
desktop.
So we shouldn't be too bad, otherwise I wouldn't be proposing this :)
Cheers,
Richard
prev parent reply other threads:[~2011-09-27 10:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-26 20:24 [PATCH] insane: Promote most warnings into QA errors by default Richard Purdie
2011-09-26 21:51 ` Richard Purdie
2011-09-26 23:08 ` Saul Wold
2011-09-27 10:02 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317117752.26109.142.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=sgw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox