Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] insane: Promote most warnings into QA errors by default
Date: Mon, 26 Sep 2011 16:08:01 -0700	[thread overview]
Message-ID: <4E8105D1.70409@linux.intel.com> (raw)
In-Reply-To: <1317073889.26109.97.camel@ted>

On 09/26/2011 02:51 PM, Richard Purdie wrote:
> On Mon, 2011-09-26 at 21:24 +0100, Richard Purdie wrote:
>> We agreed a while back that we'd start ERRORing on QA issues, not just
>> WARNING about them. This patch changes the default QA levels to error
>> on everything except ldflag and useless rpath issues.
>>
>> It also stops giving out QA warnings about desktop files since it
>> adds noise to the build and until someone plans to seriously tackle
>> that problem, its pointless.
>>
>> We can promote the ldflag and rpath warnings too, when the issues
>> in OE-Core are resolved (they're mostly there now, jsut a few more
>> to go).
>>
>> Signed-off-by: Richard Purdie<richard.purdie@linuxfoundation.org>
>> ---
>> diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
>> index addb9ac..62935c3 100644
>> --- a/meta/classes/insane.bbclass
>> +++ b/meta/classes/insane.bbclass
>> @@ -99,9 +99,9 @@ def package_qa_get_machine_dict():
>>          }
>>
>>
>> -WARN_QA ?= "dev-so rpaths debug-deps dev-deps debug-files arch la2 pkgconfig desktop la ldflags perms useless-rpaths"
>> -ERROR_QA ?= ""
>> -#ERROR_QA ?= "rpaths debug-deps dev-deps debug-files arch pkgconfig perms"
>> +# Currently not being used by default "desktop"
>> +WARN_QA ?= "ldflags useless-rpaths"
>> +ERROR_QA ?= "dev-so rpaths debug-deps dev-deps debug-files arch la2 pkgconfig la perms"
>>
>
> Further testing shows we may not be ready to move rpath to ERROR_QA
> quite yet but the rest of the proposal still stands...
>
How bad is the breakage in a world build?

I will probably attempt this later or tomorrow.

Sau!
> Cheers,
>
> Richard
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>



  reply	other threads:[~2011-09-26 23:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-26 20:24 [PATCH] insane: Promote most warnings into QA errors by default Richard Purdie
2011-09-26 21:51 ` Richard Purdie
2011-09-26 23:08   ` Saul Wold [this message]
2011-09-27 10:02     ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E8105D1.70409@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox