Re: sstate_clean() overzealous?

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Mon, 2011-10-03 at 17:47 +0100, Phil Blundell wrote:
> The sstate_clean() function in sstate.bbclass is doing (inter alia):
> 
>     stfile = d.getVar("STAMP", True) + ".do_" + ss['task']
>     [...]
>     oe.path.remove(stfile + ".*")
>     oe.path.remove(stfile + "_setscene" + ".*")
> 
> which means that, for tasks which set the stamp-extra-info flag to
> ${MACHINE}, it ends up blowing away the stamps for all machines rather
> than just the current one.  The net effect of this seems to be that
> there is no way to have the setscene stamps populated for more than one
> MACHINE at any time, and hence all those tasks get rerun every time you
> change MACHINE even if nothing else has been altered.
> 
> Is this behaviour deliberate? 

No, its not intended to be wiping out all the different machines.

>  It is certainly a little bit annoying but
> I don't understand the internals of sstate well enough to judge what
> exactly that glob is trying to accomplish.

The trouble is we now support a variety of different stamp file formats
depending on what settings you have enabled (and metadata you're using).

Clean can be called from two sources, do_clean, or just before a sstate
controlled task is about to be run. In either case we want to clear out
any previous "state" including any stamp files that might have
represented this task since we're about to invalidate anything they did.
This means wiping out "normal" stamps and any setscene variants of those
stamps. We also want to remove any stamps representing other hashes for
this task since there is no version installed.

If the BasicHash signature generator code is enabled this adds hashes to
the stamp files. This turns the stamps into the form:

<stampfile>.<hash>
or in the case of machine specific tasks:
<stampfile>.<hash>.<machine>

I think we need to teach this clean function about stamp-extra-info and
instead of stfile + ".*", remove stfile + ".*." + stamp-extra-info if
stamp-extra-info is set. That would likely fix the problem you're
seeing.

Cheers,

Richard