From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: sstate_clean() overzealous?
Date: Tue, 04 Oct 2011 16:42:26 +0100 [thread overview]
Message-ID: <1317742955.14671.62.camel@ted> (raw)
In-Reply-To: <1317740599.13337.43.camel@phil-desktop>
On Tue, 2011-10-04 at 16:03 +0100, Phil Blundell wrote:
> On Tue, 2011-10-04 at 11:54 +0100, Richard Purdie wrote:
> > I think we need to teach this clean function about stamp-extra-info and
> > instead of stfile + ".*", remove stfile + ".*." + stamp-extra-info if
> > stamp-extra-info is set. That would likely fix the problem you're
> > seeing.
>
> Okay, thanks. I applied this change locally:
>
> diff --git a/meta/classes/sstate.bbclass b/meta/classes/sstate.bbclass
> index 91f209a..7f38800 100644
> --- a/meta/classes/sstate.bbclass
> +++ b/meta/classes/sstate.bbclass
> @@ -258,10 +258,15 @@ def sstate_clean(ss, d):
> bb.utils.unlockfile(lock)
>
> stfile = d.getVar("STAMP", True) + ".do_" + ss['task']
> + extrainf = d.getVarFlag("do_" + ss['task'], 'stamp-extra-info')
> oe.path.remove(stfile)
> oe.path.remove(stfile + "_setscene")
> - oe.path.remove(stfile + ".*")
> - oe.path.remove(stfile + "_setscene" + ".*")
> + if extrainf:
> + oe.path.remove(stfile + ".*." + extrainf)
> + oe.path.remove(stfile + "_setscene" + ".*." + extrainf)
Thinking further about this it may need to be ".*" instead of ".*.". I
suspect with the above it wouldn't be wiping out some of the stamps it
should be with OE-Core and the Basic siggen code. BasicHash would work
though.
Cheers,
Richard
prev parent reply other threads:[~2011-10-04 15:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-03 16:47 sstate_clean() overzealous? Phil Blundell
2011-10-03 21:11 ` McClintock Matthew-B29882
2011-10-03 21:18 ` Khem Raj
2011-10-03 21:22 ` McClintock Matthew-B29882
2011-10-03 21:24 ` Saul Wold
2011-10-03 21:30 ` McClintock Matthew-B29882
2011-10-03 22:08 ` McClintock Matthew-B29882
2011-10-04 22:19 ` Richard Purdie
2011-10-04 10:54 ` Richard Purdie
2011-10-04 15:03 ` Phil Blundell
2011-10-04 15:42 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317742955.14671.62.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox