Re: [yocto] [PATCH 7/7] Add proper deps for nfs-utils, util-linux, and strace

Re: [yocto] [PATCH 7/7] Add proper deps for nfs-utils, util-linux, and strace

[Martin Jansa]

On Thu, Sep 29, 2011 at 7:52 AM, Matthew McClintock <msm@freescale.com> wrote:
> These packages need these deps for the RPM generation stage:

This was already applied, but I'll reply here and please send next
patch adressing those comments.

Today I've noticed that perl and libperl are pulled to my images only
because of util-linux and strace I belive I don't need them, see
inline comments

>  error: Failed dependencies:
> |       /usr/bin/python is needed by nfs-utils-1.2.3-r2.ppce5500
> |       /usr/bin/perl is needed by util-linux-2.19.1-r4.ppce5500
> |       /usr/bin/perl is needed by strace-4.5.20-r2.ppce5500
>
> Signed-off-by: Matthew McClintock <msm@freescale.com>
> ---
>  .../nfs-utils/nfs-utils_1.2.3.bb                   |    2 +-
>  meta/recipes-core/util-linux/util-linux.inc        |    2 +-
>  meta/recipes-devtools/strace/strace_4.5.20.bb      |    2 ++
>  3 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb b/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb
> index 08468fe..e8b0490 100644
> --- a/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb
> +++ b/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb
> @@ -9,7 +9,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
>
>  # util-linux for libblkid
>  DEPENDS = "libcap libnfsidmap libevent util-linux tcp-wrappers"
> -RDEPENDS_${PN} = "portmap"
> +RDEPENDS_${PN} = "portmap python"

python is needed only for
./usr/sbin/mountstats:#!/usr/bin/env python
./usr/sbin/nfsiostat:#!/usr/bin/python
could you please move them to separate packages and keep python
runtime dependency only there?

>  RRECOMMENDS_${PN} = "kernel-module-nfsd"
>
>  PR = "r2"
> diff --git a/meta/recipes-core/util-linux/util-linux.inc b/meta/recipes-core/util-linux/util-linux.inc
> index 1f242b7..afce673 100644
> --- a/meta/recipes-core/util-linux/util-linux.inc
> +++ b/meta/recipes-core/util-linux/util-linux.inc
> @@ -55,7 +55,7 @@ FILES_util-linux-libuuid-dev = "${libdir}/libuuid.so ${libdir}/libuuid.a ${libdi
>  FILES_util-linux-lscpu = "${bindir}/lscpu"
>
>  RRECOMMENDS_${PN} = "util-linux-fdisk util-linux-cfdisk util-linux-sfdisk util-linux-mount util-linux-readprofile "
> -RDEPENDS_${PN} = "util-linux-umount util-linux-swaponoff util-linux-losetup"
> +RDEPENDS_${PN} = "util-linux-umount util-linux-swaponoff util-linux-losetup perl"

perl is needed only for
/usr/bin/chkdupexe
could you please move chkdupexe to separate package and add perl only
to RDEPENDS_${PN}-chkdupexe?

>  RRECOMMENDS_${PN}_virtclass-native = ""
>  RDEPENDS_${PN}_virtclass-native = ""
> diff --git a/meta/recipes-devtools/strace/strace_4.5.20.bb b/meta/recipes-devtools/strace/strace_4.5.20.bb
> index 391669f..b3d2aa5 100644
> --- a/meta/recipes-devtools/strace/strace_4.5.20.bb
> +++ b/meta/recipes-devtools/strace/strace_4.5.20.bb
> @@ -5,6 +5,8 @@ LICENSE = "BSD"
>  LIC_FILES_CHKSUM = "file://COPYRIGHT;md5=4535377ede62550fdeaf39f595fd550a"
>  PR = "r2"
>
> +RDEPENDS = "perl"

This should be RDEPENDS_${PN}
and much better would be to split
strace-graph to separate package and add perl only to
RDEPENDS_${PN}-graph

> +
>  SRC_URI = "${SOURCEFORGE_MIRROR}/strace/strace-${PV}.tar.bz2 \
>            file://sigmask.patch \
>           "
> --
> 1.7.6.1

And also you need to bump PR when you're changing RDEPENDs (otherwise
issues are shown much later when it's rebuild because of some other
changes).

Regards,

[PATCH] nfs-utils: separate nfs-utils-client and nfs-utils-stats

[Martin Jansa]

* move python runtime dependency only to nfs-utils-stats

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 .../nfs-utils/nfs-utils_1.2.3.bb                   |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb b/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb
index e8b0490..d047940 100644
--- a/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb
+++ b/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb
@@ -9,10 +9,10 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
 
 # util-linux for libblkid
 DEPENDS = "libcap libnfsidmap libevent util-linux tcp-wrappers"
-RDEPENDS_${PN} = "portmap python"
+RDEPENDS_${PN} = "portmap"
 RRECOMMENDS_${PN} = "kernel-module-nfsd"
 
-PR = "r2"
+PR = "r3"
 
 SRC_URI = "${SOURCEFORGE_MIRROR}/nfs/nfs-utils-${PV}.tar.bz2 \
            file://nfs-utils-1.0.6-uclibc.patch \
@@ -45,6 +45,11 @@ EXTRA_OECONF = "--with-statduser=nobody \
 
 INHIBIT_AUTO_STAGE = "1"
 
+PACKAGES =+ "${PN}-client ${PN}-stats"
+FILES_${PN}-client = "${base_sbindir}/*mount.nfs*"
+FILES_${PN}-stats = "${sbindir}/mountstats ${sbindir}/nfsiostat"
+RDEPENDS_${PN}-stats = "python"
+
 do_install_append () {
 	install -d ${D}${sysconfdir}/init.d
 	install -m 0755 ${WORKDIR}/nfsserver ${D}${sysconfdir}/init.d/nfsserver
-- 
1.7.7

Re: [PATCH] nfs-utils: separate nfs-utils-client and nfs-utils-stats

[Richard Purdie]

On Thu, 2011-10-13 at 13:44 +0200, Martin Jansa wrote:
> * move python runtime dependency only to nfs-utils-stats
> 
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  .../nfs-utils/nfs-utils_1.2.3.bb                   |    9 +++++++--
>  1 files changed, 7 insertions(+), 2 deletions(-)

Merged to master, thanks.

Richard